Alex Lourie has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine_validators.py
Line 160: def validatePassword(param, options=[]):
Line 161: logging.debug("Validating password")
Line 162: if not validateStringNotEmpty(param, options):
Line 163: return False
Line 164: if "'" in param:
well, as we are only looking for one specific char, I believe it is simpler and
more readable to use just the 'a in b' syntax.
Line 165: logging.error(output_messages.ERR_NOT_ALLOWED_CHAR)
Line 166: print output_messages.ERR_NOT_ALLOWED_CHAR
Line 167: return False
Line 168: if re.search("\s", param):
--
To view, visit http://gerrit.ovirt.org/8723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa3cf2e17ff8f5da670f901da7c681b8be86e8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
