Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Support newer versions M2E plugin
..
core: Support newer versions M2E plugin
Recent versions of the M2E plugin (e.g., the one bundled with Eclips
Yair Zaslavsky has posted comments on this change.
Change subject: core: Support newer versions M2E plugin
..
Patch Set 2: Verified; Looks good to me, approved
Verified by Allon Mureinik.
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Support newer versions M2E plugin
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6669
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: ignore address-less interfaces when creating id
..
Patch Set 1:
> Right, but this code may be executed on various distro's, and some may not
> have it
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: ignore address-less interfaces when creating id
..
Patch Set 1:
Right, but this code may be executed on various distro's,
and some may not have it in
Itamar Heim has posted comments on this change.
Change subject: core: Prevent migrating paused VM
..
Patch Set 1:
I thought it is not supported only for a VM paused for EIO/ENOSPACE?
what is the behaviour if i try to move a hos
Moti Asayag has posted comments on this change.
Change subject: core:Edit job message referencing template(#818295)
..
Patch Set 3: (2 inline comments)
File
backend/manager/
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix GetVdsCertificateSubject query
..
core: fix GetVdsCertificateSubject query
This patch fixes two bugs in this query:
1. succeeded setting
2. Ret
Oved Ourfali has posted comments on this change.
Change subject: core: fix GetVdsCertificateSubject query
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6670
To unsubscribe, visit
Einav Cohen has posted comments on this change.
Change subject: core: fix GetVdsCertificateSubject query
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6670
To unsubscribe, visit http://ger
Oved Ourfali has posted comments on this change.
Change subject: core: fix GetVdsCertificateSubject query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6670
To unsubscribe, visit http://gerrit.ovirt.org/set
Oved Ourfali has uploaded a new change for review.
Change subject: core: fix GetVdsCertificateSubject query
..
core: fix GetVdsCertificateSubject query
This patch fixes two bugs in this query:
1. succeeded setting
2. Return valu
Allon Mureinik has posted comments on this change.
Change subject: core: Support newer versions M2E plugin
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6669
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has uploaded a new change for review.
Change subject: core: Support newer versions M2E plugin
..
core: Support newer versions M2E plugin
Recent versions of the M2E plugin (e.g., the one bundled with Eclipse
Juno)
Allon Mureinik has posted comments on this change.
Change subject: core: Move servlet utilities to the utils module
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
please remove the TWS in po
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: remove nic's vlan from add/edit dialog
..
webadmin: remove nic's vlan from add/edit dialog
https://bugzilla.redhat.com/842734
vlan networks attached t
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fixing log4j.xml of engine-config
..
core: fixing log4j.xml of engine-config
This patch fixes log4j.xml of engine-config
In such a way that the o
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6665
To unsubscribe, visi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: excluding log4.xml from engine-config
..
tools: excluding log4.xml from engine-config
log4j.xml should not be included at engine-config.jar
Engi
Yair Zaslavsky has posted comments on this change.
Change subject: tools: excluding log4.xml from engine-config
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6664
To unsubscribe, visit http://gerrit.ovirt.o
Yair Zaslavsky has posted comments on this change.
Change subject: tools: excluding log4.xml from engine-config
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6664
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6665
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6665
To unsubs
Juan Hernandez has posted comments on this change.
Change subject: tools: excluding log4.xml from engine-config
..
Patch Set 1: Verified
With a fresh build the log4.xml file is no longer included in the
engine-config.jar file.
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: remove inaccurate audit log message when creating VMs
in Pool
..
Engine: remove inaccurate audit log message when creating VMs in Pool
When cre
Shahar Havivi has posted comments on this change.
Change subject: Engine: remove inaccurate audit log message when creating VMs
in Pool
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 2:
Patchset2: followed Juan's comments
--
To view, visit http://gerrit.ovirt.org/6665
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 1: (1 inline comment)
File backend/manager/tools/engin
Juan Hernandez has posted comments on this change.
Change subject: core: fixing log4j.xml of engine-config
..
Patch Set 1: (1 inline comment)
File backend/manager/tools/engin
Juan Hernandez has posted comments on this change.
Change subject: tools: excluding log4.xml from engine-config
..
Patch Set 1: Looks good to me, but someone else must approve
You may want to exclude all the other files in the
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: fixing log4j.xml of engine-config
..
core: fixing log4j.xml of engine-config
This patch fixes log4j.xml of engine-config
In such a way that the output ca
Yair Zaslavsky has uploaded a new change for review.
Change subject: tools: excluding log4.xml from engine-config
..
tools: excluding log4.xml from engine-config
log4j.xml should not be included at engine-config.jar
Engine-confi
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fixing lock vm
..
core: Fixing lock vm
Fixing lock vm
Change-Id: I7803349223ab6b1860cdeee165a2e6a226f7cb22
Signed-off-by: Michael Kublin
---
M
Michael Kublin has posted comments on this change.
Change subject: core: Fixing lock vm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing lock vm
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6661
To unsubscribe, visit http://gerrit.ovirt.org/set
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing lock vm
..
core: Fixing lock vm
Fixing lock vm
Change-Id: I7803349223ab6b1860cdeee165a2e6a226f7cb22
Signed-off-by: Michael Kublin
---
M
backend
Roy Golan has uploaded a new change for review.
Change subject: core: Prevent migrating paused VM
..
core: Prevent migrating paused VM
Migrating a paused VM is currently not supported.
Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1
Omer Frenkel has posted comments on this change.
Change subject: core: Prevent migrating paused VM
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6660
To unsubscribe, visit http://gerrit.ov
Eli Mesika has posted comments on this change.
Change subject: Engine: remove inaccurate audit log message when creating VMs
in Pool
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6656
To
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fixing vm left at status ImageLocked
..
core: Fixing vm left at status ImageLocked
Fixing vm left at status ImageLocked
Change-Id: I50eddbabb0f5
Michael Kublin has posted comments on this change.
Change subject: core: Fixing vm left at status ImageLocked
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6657
To unsubscribe, v
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing vm left at status ImageLocked
..
core: Fixing vm left at status ImageLocked
Fixing vm left at status ImageLocked
Change-Id: I50eddbabb0f50c13dfab
Shahar Havivi has posted comments on this change.
Change subject: Engine: remove inaccurate audit log message when creating VMs
in Pool
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6656
To unsubscribe, vi
Shahar Havivi has uploaded a new change for review.
Change subject: Engine: remove inaccurate audit log message when creating VMs
in Pool
..
Engine: remove inaccurate audit log message when creating VMs in Pool
When creating VM
Gilad Chaplik has posted comments on this change.
Change subject: core:Edit job message referencing template(#818295)
..
Patch Set 3: (1 inline comment)
File
backend/manager
Itamar Heim has posted comments on this change.
Change subject: core: vds comparison with a drools
..
Patch Set 2:
indeed.
I think an ovirt feature page describing the interface is needed.
--
To view, visit http://gerrit.ovirt
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fixing import storage domain to save additional NFS
options (#835961)
..
core: fixing import storage domain to save additional NFS options (#835961
Oved Ourfali has posted comments on this change.
Change subject: core: fixing import storage domain to save additional NFS
options (#835961)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.
Oved Ourfali has posted comments on this change.
Change subject: core: fixing import storage domain to save additional NFS
options (#835961)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6618
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: core: fixing import storage domain to save additional NFS
options (#835961)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6
Maor Lipchuk has posted comments on this change.
Change subject: core: Change audit log sevirity type
..
Patch Set 2: Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org/6389
To unsubscribe, visit
Ofer Schreiber has posted comments on this change.
Change subject: core:pre upgrade scripts will not run ...(#842119)
..
Patch Set 1: Looks good to me, but someone else must approve
ACK on the push for 3.1
--
To view, visit ht
Maor Lipchuk has posted comments on this change.
Change subject: core:Edit job message referencing template(#818295)
..
Patch Set 2:
Where is this bundle used?
ExecutionMessageDirector#getMessage + resolveJobMessage
Are you s
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: ignore address-less interfaces when creating id
..
Patch Set 1:
> Full patch is used since some utils are not always in the PATH.
All utilities are fr
Ori Liel has posted comments on this change.
Change subject: restapi: Add sync networks to Setup Networks call
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6654
To unsubscribe, visit http
Ori Liel has posted comments on this change.
Change subject: restapi: Add "custom network definition" field to NIC
..
Patch Set 1: Looks good to me, approved
I just noticed that 'definition' is only in the commit message. You g
Ori Liel has posted comments on this change.
Change subject: restapi: Add "custom network definition" field to NIC
..
Patch Set 1:
Looks great, the only thing I'm thinking is maybe
"custom_network_configuration" is slightly be
Ori Liel has posted comments on this change.
Change subject: restapi: Fix matching of empty list
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6652
To unsubscribe, visit http://gerrit.ovir
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Add error message for network not in sync
..
core: Add error message for network not in sync
Network that is not in sync cannot be edited, so added an err
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Add "custom network definition" field to NIC
..
restapi: Add "custom network definition" field to NIC
This field will indicate if a NIC is out-of-sync,
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Add sync networks to Setup Networks call
..
restapi: Add sync networks to Setup Networks call
Added the sync network functionality to the BackendHostNi
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Fix matching of empty list
..
restapi: Fix matching of empty list
If empty list is expected in test, then the matcher would fail because
it contains no
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add create from network to tests
..
engine: Add create from network to tests
This method is needed to create initially a NIC that is synchronized to
the
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add sync networks to Setup Networks
..
engine: Add sync networks to Setup Networks
Added list of networks that need to be synced to SetupNetworks
parame
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Add network details to host's network device
..
core: Add network details to host's network device
Added an inner class to hold various details regarding
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Fill network details of host NICs query
..
engine: Fill network details of host NICs query
Added filling of the details in the query.
Change-Id: Ie6f39
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Added method to fill network details
..
core: Added method to fill network details
This method accepts list of interfaces, and a map of networks, and fill
Oved Ourfali has submitted this change and it was merged.
Change subject: backend: fix verifyAddVm in VmHandler
..
backend: fix verifyAddVm in VmHandler
This patch fixes a behaviour in which the verifyAddVm method returned
"tru
Oved Ourfali has posted comments on this change.
Change subject: backend: fix verifyAddVm in VmHandler
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6645
To unsubscribe, visit ht
Omer Frenkel has posted comments on this change.
Change subject: backend: fix verifyAddVm in VmHandler
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6645
To unsubscribe, visit http://gerri
Tomas Jelinek has posted comments on this change.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
..
Patch Set 1: (1 inline comment)
File
fronte
Ofer Schreiber has posted comments on this change.
Change subject: userportal: not passing hostsubject to spice-xpi
..
Patch Set 1: Looks good to me, but someone else must approve
ACK from me to push this, didn't reviewed the c
Doron Fediuck has posted comments on this change.
Change subject: webadmin: translation of cpu err msg (#834870)
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Need minor fixups.
See inline.
.
Oved Ourfali has uploaded a new change for review.
Change subject: backend: fix verifyAddVm in VmHandler
..
backend: fix verifyAddVm in VmHandler
This patch fixes a behaviour in which the verifyAddVm method returned
"true", alth
Allon Mureinik has posted comments on this change.
Change subject: core: Animal-sniffer to check JDK6 compatibility
..
Patch Set 3:
it's one of codehaus' projects:
http://mojo.codehaus.org/animal-sniffer-maven-plugin/
--
To vi
Doron Fediuck has posted comments on this change.
Change subject: core: Animal-sniffer to check JDK6 compatibility
..
Patch Set 3:
Is this internal to maven or needs additional external artifact?
--
To view, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
..
Patch Set 1: (1 inline comment)
minor comment
engine side looks ok
please run test and verify edit
Omer Frenkel has posted comments on this change.
Change subject: core: store the username owning the current spice session ticket
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6546
To unsu
Doron Fediuck has posted comments on this change.
Change subject: core: vds comparison with a drools
..
Patch Set 2:
Laszlo,
Blessed work.
Please remember we need pluggable architecture first, in order to suggest such
nice i
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: ignore address-less interfaces when creating id
..
Patch Set 1: Looks good to me, approved
Full patch is used since some utils are not always in the P
Roy Golan has posted comments on this change.
Change subject: core: store the username owning the current spice session ticket
..
Patch Set 4:
added a nullness check for username and a junit
--
To view, visit http://gerrit.ovi
Michael Kublin has posted comments on this change.
Change subject: core: fixing import storage domain to save additional NFS
options (#835961)
..
Patch Set 3: Looks good to me, but someone else must approve
>From engine logic
Oved Ourfali has posted comments on this change.
Change subject: engine: Import linux VM with legacy usb policy (#834254)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6612
To unsubscribe,
Tomas Jelinek has posted comments on this change.
Change subject: userportal: not passing hostsubject to spice-xpi
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6640
T
Juan Hernandez has posted comments on this change.
Change subject: core: Animal-sniffer to check JDK6 compatibility
..
Patch Set 3: Looks good to me, but someone else must approve
Great! I think this is a very good solution.
-
Allon Mureinik has posted comments on this change.
Change subject: core: Animal-sniffer to check JDK6 compatibility
..
Patch Set 3:
mvn animal-sniffer:check
--
To view, visit http://gerrit.ovirt.org/6540
To unsubscribe, visit
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: added remote db upgrade.
..
packaging: added remote db upgrade.
Change-Id: I2906d93831f9af53be6166d7ccfed80cc34172b5
Signed-off-by: Yaniv Dary
Yaniv Dary has posted comments on this change.
Change subject: packaging: added remote db upgrade.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6642
To unsubscribe, visit http:/
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: added remote db upgrade.
..
packaging: added remote db upgrade.
Change-Id: I2906d93831f9af53be6166d7ccfed80cc34172b5
Signed-off-by: Yaniv Dary
---
M pa
Roy Golan has posted comments on this change.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
..
Patch Set 1: (3 inline comments)
File
backend/m
Eli Mesika has uploaded a new change for review.
Change subject: core:pre upgrade scripts will not run ...(#842119)
..
core:pre upgrade scripts will not run ...(#842119)
pre upgrade scripts will not run correctly upon 3.0 DB res
Hello Tomas Jelinek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6640
to review the following change.
Change subject: userportal: not passing hostsubject to spice-xpi
..
userportal: not passing
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Import linux VM with legacy usb policy (#834254)
..
Patch Set 1: (1 inline comment)
File
backend/m
Selvasundaram has posted comments on this change.
Change subject: engine: Brick existance validation for add brick
..
Patch Set 1: (4 inline comments)
File
backend/manager/m
Michael Kublin has submitted this change and it was merged.
Change subject: core: Clean up of HandleVdsVersionCommand
..
core: Clean up of HandleVdsVersionCommand
These patch is clean up:
1. Annotattion for warnings
2. Disable
Michael Kublin has posted comments on this change.
Change subject: core: Clean up of HandleVdsVersionCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/6639
To unsubsc
Tal Nisan has posted comments on this change.
Change subject: webadmin: Disable storage type selectbox when editing DC
(#834890)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6624
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up of HandleVdsVersionCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6639
To unsubscribe, visit http:/
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removing unneeded select during unlockVM
..
core: Removing unneeded select during unlockVM
The following patch will remove unneeded selects for v
Michael Kublin has posted comments on this change.
Change subject: core: Removing unneeded select during unlockVM
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6637
To u
1 - 100 of 115 matches
Mail list logo
