Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 11: Looks good to me, but someone else must approve
(2 inline comments)
Moti Asayag has submitted this change and it was merged.
Change subject: core: Reduce VM class instantiation in
VmManagementParametersBase
..
core: Reduce VM class instantiation in VmManagementParametersBase
Each call to VmMan
Moti Asayag has posted comments on this change.
Change subject: core: Reduce VM class instantiation in
VmManagementParametersBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6446
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Michael Kublin has posted comments on this change.
Change subject: core: Reduce VM class instantiation in
VmManagementParametersBase
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6446
To
Ayal Baron has posted comments on this change.
Change subject: core: added information to ConnectStorageVDScommand logs
(#835546)
..
Patch Set 3: Looks good to me, but someone else must approve
Acking as current structure is w
Ayal Baron has posted comments on this change.
Change subject: core: added information to ConnectStorageVDScommand logs
(#835546)
..
Patch Set 3: (1 inline comment)
File
ba
Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed uneeded null value check
..
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
...
Moti Asayag has uploaded a new change for review.
Change subject: core: Reduce VM class instantiation in
VmManagementParametersBase
..
core: Reduce VM class instantiation in VmManagementParametersBase
Each call to VmManagementP
Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6
Ayal Baron has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/63
Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Ayal Baron has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5718
To
Moti Asayag has posted comments on this change.
Change subject: core:VM name and Data Domain appears ...(#839727)
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Please fix typo on commit message before submittin
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: VM Snapshots sub-tab re-design
..
webadmin: VM Snapshots sub-tab re-design
Virtual Machines main-tab -> Snapshots sub-tab,
Re-implementing sub-tab desig
Juan Hernandez has posted comments on this change.
Change subject: packaging: Moved configuring ovirt-engine to utils.
..
Patch Set 1:
Most of the python code in the setup tools uses camelCaseStyle, but some of the
new names u
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added function to parse web-conf.js
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6377
To
Juan Hernandez has posted comments on this change.
Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy
..
Patch Set 1:
This was suggested by Alon Bar-Lev in http://gerrit.ovirt.org/6349.
--
To view, vi
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy
..
packaging: Disable HTTP and HTTPS when using Apache as proxy
This patch changes the setup appli
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bind ports to loopback by default
..
Patch Set 3:
Please disregard patch set 2, it was a mistake. Patch set 3 is in fact the same
that patch set 1.
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: separate storage & cluster quota
..
webadmin: separate storage & cluster quota
This patch separates quota for storage and cluster limitation,
from now
Gilad Chaplik has uploaded a new change for review.
Change subject: core: quota - fix in relvant quota for entity
..
core: quota - fix in relvant quota for entity
added a check to the 'get relevant quota by cluster/storage' SP,
Gilad Chaplik has uploaded a new change for review.
Change subject: core: updating disks quota
..
core: updating disks quota
Currently when moving or coping a disk, the quota snapshots
of that disk is not changed, according to t
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: allow customization of package
..
Patch Set 2:
Ofer, as you requested %if %{boolen}.
--
To view, visit http://gerrit.ovirt.org/6370
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed uneeded null value check
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: allow customization of package
..
Patch Set 1: (2 inline comments)
File packaging/fedora/spec/ovir
Alon Bar-Lev has abandoned this change.
Change subject: build: use spec macros for program whenever we can
..
Patch Set 12: Abandoned
Thanks for Ofer, we have reference[1] to settle this.
These macros seems obsolete now.
Thank
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5631
To
Allon Mureinik has posted comments on this change.
Change subject: core: Support diskless snapshots
..
Patch Set 4: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6387
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Allow remove snapshot w/o disks (#825809)
..
Patch Set 12: Verified; Looks good to me, but someone else must approve
rebased, no code change since rgolan'
Allon Mureinik has posted comments on this change.
Change subject: core: Prepare RemoveSnapshotCommand for testing
..
Patch Set 12: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6118
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: Remove disk from snapshots (#828192)
..
Patch Set 18: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6025
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveImageCommand: Extract initializers
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6409
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveImageCommand: remove commented line
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6408
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: RemvoeImageCommand: removed DbFacade refs
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6407
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveImageCommand: suppress serial
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6406
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: use runVdsCommand
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6405
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: pull down remove methods
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6404
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: non-static setImageStatus
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit.ovirt.org/6403
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: Don't use static DbFacade
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no code change.
echoing +
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: remove useless null check
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no code changes, but fixed
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: soled Eclipse warnings
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no code changes, but fixed ty
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: remove commented out line
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no code changes, but fixed
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: remove useless null check
..
Patch Set 1: (1 inline comment)
Commit Message
Line 1
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: sovle eclipse warnings
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7: c
Allon Mureinik has posted comments on this change.
Change subject: core: BaseImagesCommand: remove commented out line
..
Patch Set 1: (1 inline comment)
Commit Message
Line 9
Allon Mureinik has posted comments on this change.
Change subject: core: export/import of diskless VM/VM with no snappable
disks(#838937)
..
Patch Set 2: I would prefer that you didn't submit this
(7 inline comments)
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Redesign Cluster->Add Network dialog
..
webadmin: Redesign Cluster->Add Network dialog
https://bugzilla.redhat.com/833715
Make the Cluster->logical ne
Ofer Schreiber has submitted this change and it was merged.
Change subject: build: user editable configuration files should be protected
..
build: user editable configuration files should be protected
The following configuratio
Ofer Schreiber has posted comments on this change.
Change subject: build: user editable configuration files should be protected
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6347
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup SearchObjectAutoCompleter
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6411
To unsubs
Ofer Schreiber has posted comments on this change.
Change subject: build: user editable configuration files should be protected
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6347
To unsubscribe, visit http:
Ofer Schreiber has posted comments on this change.
Change subject: build: user editable configuration files should be protected
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6347
To unsubs
Ofer Schreiber has posted comments on this change.
Change subject: packaging: allow customization of package
..
Patch Set 1: (2 inline comments)
File packaging/fedora/spec/ov
Alex Lourie has posted comments on this change.
Change subject: packaging: Added function to parse web-conf.js
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Eli Mesika has posted comments on this change.
Change subject: engine: removing default quota
..
Patch Set 2: (16 inline comments)
File backend/manager/dbscripts/quota_sp.sql
Eli Mesika has posted comments on this change.
Change subject: database: do not use git when building
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6255
To unsubscribe, visit htt
Eli Mesika has uploaded a new change for review.
Change subject: core:VM name and Data Domain appears ...(#839727)
..
core:VM name and Data Domain appears ...(#839727)
virt-engine-backend [Task Manager]: VM name and Data Domain
Juan Hernandez has posted comments on this change.
Change subject: packaging: Removed obsolete jboss checking code (#837812)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added function to parse web-conf.js
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
.
Omer Frenkel has posted comments on this change.
Change subject: engine: Added Enable / Disable CIFS option feature
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6397
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Ports 8006, 8007 and 8008 are not required
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6386
To unsubscribe, visit http://gerri
Tal Nisan has submitted this change and it was merged.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
core: RegisterVdsQuery - BitSet instead of indexOf
instead of using String's indexOf function for chec
Tal Nisan has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe
Tal Nisan has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit ht
Shahar Havivi has submitted this change and it was merged.
Change subject: engine: wrong error when trying to run VM pinned to host with
down status
..
engine: wrong error when trying to run VM pinned to host with down status
Shahar Havivi has posted comments on this change.
Change subject: engine: wrong error when trying to run VM pinned to host with
down status
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Roy Golan has posted comments on this change.
Change subject: packaging: Run with OpenJDK 7 regardless of what is installed
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6223
To unsubscrib
Omer Frenkel has posted comments on this change.
Change subject: engine: wrong error when trying to run VM pinned to host with
down status
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/63
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bind ports to loopback by default
..
Patch Set 1:
> If we use proxy and apache, why not limit the http as well?
Good idea. In fact we should complet
Allon Mureinik has posted comments on this change.
Change subject: engine: Improve RemoveStorageDomainCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6413
To uns
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
..
webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
Change-Id: I044a353cb1551f2fc
Alexey Chub has posted comments on this change.
Change subject: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6414
To
Tal Nisan has posted comments on this change.
Change subject: core:Edit job message referencing template(#818295)
..
Patch Set 2:
Same question as Allon, what is the use of ExecutionMessages bundle?
Does it parsed without addin
Shahar Havivi has posted comments on this change.
Change subject: engine: wrong error when trying to run VM pinned to host with
down status
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6398
To unsubscribe
Einav Cohen has posted comments on this change.
Change subject: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6414
To
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup SearchObjectAutoCompleter
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks right (see minor inline issue)
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
..
webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
Change-Id: I044a353cb1551f2fcffad9ff1
Gilad Chaplik has abandoned this change.
Change subject: core: updating quota for snapshots
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/6307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Michael Kublin has posted comments on this change.
Change subject: engine: Improve RemoveStorageDomainCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6413
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has uploaded a new change for review.
Change subject: engine: Improve RemoveStorageDomainCommand
..
engine: Improve RemoveStorageDomainCommand
The following patch will perform a following improvements:
1. Disable
Roy Golan has submitted this change and it was merged.
Change subject: core: clear VM device address when changing a vm disk interface
(#838462)
..
core: clear VM device address when changing a vm disk interface (#838462)
http
Roy Golan has posted comments on this change.
Change subject: core: clear VM device address when changing a vm disk interface
(#838462)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Tal Nisan has submitted this change and it was merged.
Change subject: core: Change "VM is locked" message to contain disk name
(819291)
..
core: Change "VM is locked" message to contain disk name (819291)
https://bugzilla.red
Tal Nisan has posted comments on this change.
Change subject: core: Change "VM is locked" message to contain disk name
(819291)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4945
To unsubscribe, visit http
Eli Mesika has posted comments on this change.
Change subject: core: cleanup SearchObjectAutoCompleter
..
Patch Set 1: Looks good to me, but someone else must approve
First of all kudos, that's great
However, due to search sens
Maor Lipchuk has posted comments on this change.
Change subject: core: Change "VM is locked" message to contain disk name
(819291)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4945
To un
Alex Lourie has posted comments on this change.
Change subject: packaging: Added function to parse web-conf.js
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Ayal Baron has posted comments on this change.
Change subject: core: BaseImagesCommand: Don't use static DbFacade
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6402
To
Ayal Baron has posted comments on this change.
Change subject: core: BaseImagesCommand: remove useless null check
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Ayal Baron has posted comments on this change.
Change subject: core: BaseImagesCommand: sovle eclipse warnings
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Bind ports to loopback by default
..
Patch Set 1: Looks good to me, but someone else must approve
That's great.
One question though...
If we use prox
Ayal Baron has posted comments on this change.
Change subject: core: BaseImagesCommand: remove commented out line
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Alon Bar-Lev has posted comments on this change.
Change subject: build: user editable configuration files should be protected
..
Patch Set 3:
rebased
--
To view, visit http://gerrit.ovirt.org/6347
To unsubscribe, visit http://
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: Do not allow runon/pin-to host (#839230)
..
userportal: Do not allow runon/pin-to host (#839230)
https://bugzilla.redhat.com/839230
Removed the who
1 - 100 of 171 matches
Mail list logo
