Ofer Schreiber has posted comments on this change.
Change subject: packaging: allow customization of package
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 3: %global product_name_short oVirt Engine
Any reason to use two definitions here?
Line 33: /usr/bin/getent passwd %{engine_user} >/dev/null || /usr/sbin/useradd
-c "%{user_description} Manager" -u %{engine_uid} -g %{engine_group} -M -d
%{engine_state} %{engine_user}
Actually, I think the right name is just "oVirt" and not "oVirt Manager"
--
To view, visit http://gerrit.ovirt.org/6370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25198ee1b4855ab69fccf5e36d1bf8bd5935dfcf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
