Daniel Erez has posted comments on this change.
Change subject: webadmin: use enums properly
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5356
To unsubscribe, visit http://gerrit.ovirt.or
Michael Kublin has posted comments on this change.
Change subject: core: remove uneeded logging from StorageHelperDirector
..
Patch Set 3: (1 inline comment)
File
backend/ma
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Fix vNIC count parameter for add VM
..
core: Fix vNIC count parameter for add VM
The parameter is the number of vNICs about to be allocated, so changed
it
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Reduce flood of polling attempts/logs
..
engine: Reduce flood of polling attempts/logs
When SetupNetworksCommand was run and the host didn't los
Mike Kolesnik has posted comments on this change.
Change subject: engine: Reduce flood of polling attempts/logs
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ack by masayag
--
To view, visit http://gerrit.ovirt
Mike Kolesnik has posted comments on this change.
Change subject: engine: Reduce flood of polling attempts/logs
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Kanagaraj M has posted comments on this change.
Change subject: restapi: Adding Enum validations in create volume (#831096)
..
Patch Set 5:
Comments are implemented. Please review it.
--
To view, visit http://gerrit.ovirt.org/
Kanagaraj M has posted comments on this change.
Change subject: restapi: Adding Enum validations in create volume (#831096)
..
Patch Set 4: (1 inline comment)
File
backend/m
Sharad Mishra has posted comments on this change.
Change subject: engine: Removing deprecated RefObject class.
..
Patch Set 2:
Actually, I meant to submit a second patch instead of a patch set #2. I wanted
to make the first as
Keith Robertson has uploaded a new change for review.
Change subject: tools: ISO Uploader not refreshing domains (#832158)
..
tools: ISO Uploader not refreshing domains (#832158)
https://bugzilla.redhat.com/832158
Signed-off-by
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Removing deprecated RefObject class.
..
engine: Removing deprecated RefObject class.
This is just a small part of the effort to remove RefObject class.
Shahar Havivi has submitted this change and it was merged.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
engine: Fix NPE when no CreationDate given in OvfVmReader
Change-Id: I803ce5f24a607cb877fda
Shahar Havivi has posted comments on this change.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5457
To
Daniel Erez has posted comments on this change.
Change subject: core: Testing MaxBlockDiskSize validation
..
Patch Set 1: (5 inline comments)
File
backend/manager/modules/bl
Sharad Mishra has posted comments on this change.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/5457
To unsubscribe, visit
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Attach disk from VmGuideModel
..
webadmin: Attach disk from VmGuideModel
Added missing support for attaching a disk through GuideMe.
Change-Id:
Daniel Erez has posted comments on this change.
Change subject: webadmin: Attach disk from VmGuideModel
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5422
To unsubscribe
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Remove redundant casting on UpdateVmDisk
..
webadmin: Remove redundant casting on UpdateVmDisk
UpdateVmDiskParameters - removed redundant castin
Daniel Erez has posted comments on this change.
Change subject: webadmin: Remove redundant casting on UpdateVmDisk
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5421
To
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1580/
Build Number: 1580
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,768
-
Ch
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: No red warning when export template that already
exists.
..
Patch Set 2: (1 inline comment)
you are doing a great thing creating a base class to vm/te
Daniel Erez has posted comments on this change.
Change subject: userportal: Extended view/Basic view visibility fixes
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/542
Daniel Erez has posted comments on this change.
Change subject: webadmin: No red warning when export template that already
exists.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 5:
The only change in this patch set is that the setting of the "nofile" limit has
been m
Shahar Havivi has posted comments on this change.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
Patch Set 1:
you need to add the +1 verified flag in order to merge your changes, also you
need to
Shahar Havivi has posted comments on this change.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5457
To unsubscrib
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader
..
engine: Fix NPE when no CreationDate given in OvfVmReader
Change-Id: I803ce5f24a607cb877fda1284b162
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1351/
Build Number: 1351
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,767
-
Change
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: replace sysprep tab with intial run
..
Patch Set 4:
there were some changes in run once, and the patch doesn't apply, please rebase
and resend :)
--
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1350/
Build Number: 1350
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,766
-
Chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1579/
Build Number: 1579
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,767
-
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: fix IndexOutOfBounds in remove quotaStorage
..
core: fix IndexOutOfBounds in remove quotaStorage
In case CreateAllSnapshotsFromVmCommand doesn't c
Gilad Chaplik has posted comments on this change.
Change subject: core: fix IndexOutOfBounds in remove quotaStorage
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5448
To unsubscr
Shahar Havivi has posted comments on this change.
Change subject: core: fix IndexOutOfBounds in remove quotaStorage
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5448
To unsubscribe, visit
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: DateRenderer - handle empty dates
..
webadmin: DateRenderer - handle empty dates
Change-Id: Iec84d2b03a799437798e8244cfc10938f65eb9b5
Signed-o
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DateRenderer - handle empty dates
..
Patch Set 2: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/5455
To unsu
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DateRenderer - handle empty dates
..
Patch Set 2:
rebased.
--
To view, visit http://gerrit.ovirt.org/5455
To unsubscribe, visit http://gerrit.ovirt.or
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin, userportal: ui design for run once dialog
..
webadmin, userportal: ui design for run once dialog
* divide into expandible sections
* new backg
Gilad Chaplik has posted comments on this change.
Change subject: webadmin, userportal: ui design for run once dialog
..
Patch Set 3: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/5447
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: custom property - style buttons
..
webadmin: custom property - style buttons
Change-Id: I53a57a29b4859aea25604cffc9c9e9bc676618ab
Signed-off-b
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: custom property - style buttons
..
Patch Set 3: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/5446
To unsubs
Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: ui design for run once dialog
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5447
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: webadmin: custom property - style buttons
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5446
To unsubscribe, visit http://ge
Daniel Erez has posted comments on this change.
Change subject: webadmin: DateRenderer - handle empty dates
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5455
To unsubscribe, vis
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5449
To unsubsc
Shahar Havivi has submitted this change and it was merged.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Fix NPE when importing VMs that have no ExportDate
Change-Id: I6490142bd0c8b6bdd908015aaab7a633d57
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: DateRenderer - handle empty dates
..
webadmin: DateRenderer - handle empty dates
Change-Id: Iec84d2b03a799437798e8244cfc10938f65eb9b5
Signed-off-by: G
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: edit pool- disable fields
..
webadmin: edit pool- disable fields
in edit pool we cannot edit fields except description, num of vms
and prestar
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: edit pool- disable fields
..
Patch Set 5: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/5385
To
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Consolidate HasEnabled interface
..
webadmin,userportal: Consolidate HasEnabled interface
Created HasEnabledWithHints interface tha
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Consolidate HasEnabled interface
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Consolidate HasEnabled interface
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5452
To unsubscribe, v
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: edit pool- disable fields
..
Patch Set 4: Looks good to me, approved
Verified with patch [http://gerrit.ovirt.org/5452] applied before this.
--
To vie
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5449
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove uneeded logging from StorageHelperDirector
..
Patch Set 2: (1 inline comment)
File
backend/ma
Omer Frenkel has posted comments on this change.
Change subject: core: added tests to updateVmCommand
..
Patch Set 2: Verified
no changes, added dependent patch to refacor updateVmCommand
--
To view, visit http://gerrit.ovirt.
Omer Frenkel has uploaded a new change for review.
Change subject: core: refactor UpdateVmCommand
..
core: refactor UpdateVmCommand
refactor UpdateVmCommand to make sense and try to be a little more readable
this is done before
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 1:
basically you are right...
but this is a new feature that there are vms in export domain witho
Omer Frenkel has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 1: Looks good to me, approved
looks good but please reply on previous comment before you merge (ma
Sharad Mishra has posted comments on this change.
Change subject: core:Validate attach disk to contained VM (#833077)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/544
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Send empty collection for spec params
..
core: Send empty collection for spec params
The patch sends empty map value for spec params as the
xml rp
Mike Kolesnik has posted comments on this change.
Change subject: core: Send empty collection for spec params
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5453
To unsubscribe, v
Sharad Mishra has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 1: Looks good to me, but someone else must approve
Don't we need a similar check at line # 173?
Mike Kolesnik has posted comments on this change.
Change subject: core: Send empty collection for spec params
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5453
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove uneeded logging from StorageHelperDirector
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5451
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove uneeded logging from StorageHelperDirector
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5451
To unsubscribe
Alona Kaplan has uploaded a new change for review.
Change subject: core: Send empty collection for spec params
..
core: Send empty collection for spec params
The patch sends empty map value for spec params as the
xml rpc require
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Consolidate HasEnabled interface
..
webadmin,userportal: Consolidate HasEnabled interface
Created HasEnabledWithHints interface that extend
Sharad Mishra has posted comments on this change.
Change subject: engine & webadmin: 'IMPORTEXPORT' and 'Import/Export' ->
'EXPORT' and 'Export'
..
Patch Set 1: Looks good to me, but someone else must approve
Naming convention
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Liron Aravot has uploaded a new change for review.
Change subject: core: remove uneeded logging from StorageHelperDirector
..
core: remove uneeded logging from StorageHelperDirector
some of the StorageType enum values doesn't re
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5449
To unsubscribe, visit http://gerrit.ov
Shahar Havivi has uploaded a new change for review.
Change subject: Fix NPE when importing VMs that have no ExportDate
..
Fix NPE when importing VMs that have no ExportDate
Change-Id: I6490142bd0c8b6bdd908015aaab7a633d57865b7
Si
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Validating brick directory in Add Bricks (#829664)
..
webadmin: Validating brick directory in Add Bricks (#829664)
https://bugzilla.redhat.com
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Validating brick directory in Add Bricks (#829664)
..
Patch Set 2: Verified; Looks good to me, approved
rebased & reviewed
--
To view, visit http://ge
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Setup networks- edit dialogs
..
webadmin: Setup networks- edit dialogs
https://bugzilla.redhat.com/show_bug.cgi?id=823881
- The "edit pencil"
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Setup networks- edit dialogs
..
Patch Set 8: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5400
To unsubscrib
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: LOCALFS storage path regex validation.
..
webadmin: LOCALFS storage path regex validation.
LOCALFS storage path is not validated with regex in
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: LOCALFS storage path regex validation.
..
Patch Set 5: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.o
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fix IndexOutOfBounds in remove quotaStorage
..
core: fix IndexOutOfBounds in remove quotaStorage
In case CreateAllSnapshotsFromVmCommand doesn't contains
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: custom property - style buttons
..
webadmin: custom property - style buttons
Change-Id: I53a57a29b4859aea25604cffc9c9e9bc676618ab
Signed-off-by: Gilad
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin, userportal: ui design for run once dialog
..
webadmin, userportal: ui design for run once dialog
* divide into expandible sections
* new background co
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fix logging in StorageHelperDirector
..
core: fix logging in StorageHelperDirector
change log output to debug in case of ClassNotFoundException w
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix logging in StorageHelperDirector
..
Patch Set 6: Verified; Looks good to me, approved
Giving +2 in order to remove error level of log, but we still fi
Oved Ourfali has uploaded a new change for review.
Change subject: core+ui: allow vm/template/pool/disk name to contain period
..
core+ui: allow vm/template/pool/disk name to contain period
This patch allows the name of vm/disk/
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix logging in StorageHelperDirector
..
Patch Set 5:
I think we should filter out ALL and UNKNOWN, I would not like to see debug
errors for them , even i
Tomas Jelinek has posted comments on this change.
Change subject: userportal: List all templates according to user permissions.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Validate attach disk to contained VM (#833077)
..
core:Validate attach disk to contained VM (#833077)
https://bugzilla.redhat.com/833077
Use validation whe
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Don't modifiy limits.conf during setup
..
packaging: Don't modifiy limits.conf during setup
Instead of modifying the /etc/security/limits.co
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Don't modifiy limits.conf during setup
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5375
To unsubscribe, visi
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't modifiy limits.conf during setup
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/5375
To unsubscribe, visit http://gerrit.ov
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't modifiy limits.conf during setup
..
Patch Set 4:
Rebased.
--
To view, visit http://gerrit.ovirt.org/5375
To unsubscribe, visit http://gerrit.o
Liron Aravot has posted comments on this change.
Change subject: core: minor cleanup on RegisterVdsQuery
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/5352
To unsubscribe, visit http://gerrit.ovirt.org/sett
Liron Aravot has posted comments on this change.
Change subject: core: fix logging in StorageHelperDirector
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/5398
To unsubscribe, visit http://gerrit.ovirt.org/s
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Update disk hot-plug availability
..
webadmin: Update disk hot-plug availability
https://bugzilla.redhat.com/833040
Calling UpdateIsDiskHotPlug
Daniel Erez has posted comments on this change.
Change subject: webadmin: Update disk hot-plug availability
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5443
To unsubscribe, visit http://gerrit.ovirt.org/s
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Update disk hot-plug availability
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5443
To unsubscribe, visit http:
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Update disk hot-plug availability
..
webadmin: Update disk hot-plug availability
https://bugzilla.redhat.com/833040
Calling UpdateIsDiskHotPlugAvailabl
Moti Asayag has posted comments on this change.
Change subject: engine: Reduce flood of polling attempts/logs
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
please change the type to long.
.
Omer Frenkel has posted comments on this change.
Change subject: core: added tests to updateVmCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5442
To unsubscribe, visit http://gerrit.ovirt.org/setting
1 - 100 of 250 matches
Mail list logo
