Moti Asayag has posted comments on this change.
Change subject: core: after running vm as stateless we can no longer run the vm
..
Patch Set 2: (1 inline comment)
a comment about typo
..
Michael Kublin has posted comments on this change.
Change subject: core: after running vm as stateless we can no longer run the vm
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4153
To uns
Muli Salem has posted comments on this change.
Change subject: core: Scheduling Jobs with Configurable Delay
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3829
To unsubscribe, vi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fix db schema
..
core: fix db schema
Change-Id: I64b609a0d91e687a74503d6a979fdefc879da543
Signed-off-by: Laszlo Hornyak
---
M backend/manager/db
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix db schema
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messa
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix db schema
..
--
To view, visit http://gerrit.ovirt.org/4288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerri
ShaoHe Feng has uploaded a new change for review.
Change subject: __extendCollection miss one argument, add it
..
__extendCollection miss one argument, add it
error, when run main.py
TypeError: __extendCollection() takes exactly
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix db schema
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4288
To unsubscribe, visit http://gerrit.ovirt.org/sett
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: rebase to latest api
..
sdk: rebase to latest api
sdk: Add session support
sdk: Infinite recursion when calling non-existent method #808124
Network.up
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/952/
Build Number: 952
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,129
--
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/846/
Build Number: 846
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,129
-
Allon Mureinik has posted comments on this change.
Change subject: core: db - prevent installing same script content twice
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Remove snapshots on Import VM fail (#813854)
..
core: Remove snapshots on Import VM fail (#813854)
https://bugzilla.redhat.com/813854
If the comm
Mike Kolesnik has posted comments on this change.
Change subject: core: Remove snapshots on Import VM fail (#813854)
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ack by yzaslavs
--
To view, visit http://gerrit
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/951/
Build Number: 951
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,128
--
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/845/
Build Number: 845
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,128
-
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add try/catch to compensate on start (#813159)
..
core: Add try/catch to compensate on start (#813159)
https://bugzilla.redhat.com/813159
Added t
Mike Kolesnik has posted comments on this change.
Change subject: core: Add try/catch to compensate on start (#813159)
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ack by yzaslavs
--
To view, visit http://gerr
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/950/
Build Number: 950
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,127
--
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/844/
Build Number: 844
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,127
-
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Fix query result exceptionString NPE
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4285
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: userportal: Remove legacy UserPortal from build process
..
Patch Set 1:
Since SPICE RPM cabs are extracted into UserPortal's folder (and used for both
UserPortal
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/843/
Build Number: 843
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,126
-
Change
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/949/
Build Number: 949
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,126
-
Ch
Eli Mesika has posted comments on this change.
Change subject: core: fix split function and its use for spice security channels
..
Patch Set 1: (1 inline comment)
File backen
Daniel Erez has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3209
To unsubsc
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing spelling error in luns table column name
..
core: fixing spelling error in luns table column name
1) Renaming column in luns table from phisic
Eli Mesika has posted comments on this change.
Change subject: core: fixing spelling error in luns table column name
..
Patch Set 2: Verified; Looks good to me, approved
rebase + rename upgrade script
--
To view, visit http://
Itamar Heim has posted comments on this change.
Change subject: core: fix EST display value from GMT +05:00 to GMT -05:00
..
Patch Set 2:
Roy,
1. how does the patch handles upgrade for customers already using this value
(it's
Eli Mesika has posted comments on this change.
Change subject: core: fix split function and its use for spice security channels
..
Patch Set 1: (2 inline comments)
File backe
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Fix query result exceptionString NPE
..
webadmin,userportal: Fix query result exceptionString NPE
This fixes a NPE in case query result exc
Eli Mesika has posted comments on this change.
Change subject: core: Support Sysprep for 3.1 and up (#811587)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4277
To unsubscribe, v
Eli Mesika has posted comments on this change.
Change subject: core: Adding disk changes boot_order
..
Patch Set 4: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/4104
To unsubscribe, vis
Eli Mesika has submitted this change and it was merged.
Change subject: core: Adding disk changes boot_order
..
core: Adding disk changes boot_order
This patch resolve a bug when adding disk changes the boot order.
VM disks are
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add missing element defenitions in schema
..
restapi: add missing element defenitions in schema
Signed-off-by: Michael Pasternak
Change-Id
Michael Pasternak has posted comments on this change.
Change subject: restapi: add missing element defenitions in schema
..
Patch Set 1: Verified; Looks good to me, approved
fix for upcoming build
--
To view, visit http://gerr
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add missing element defenitions in schema
..
restapi: add missing element defenitions in schema
Signed-off-by: Michael Pasternak
Change-Id: I64997
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 11:
Rebased new version of this patch (no changes since last time).
Verified that both "display" and "requ
Michael Kublin has posted comments on this change.
Change subject: frontend: Add active disks when creating a snapshot.
..
Patch Set 4: (1 inline comment)
File
backend/manag
Michael Kublin has posted comments on this change.
Change subject: core: Clear NPEs from unit-tests
..
Patch Set 1: Looks good to me, approved
Please apply Allon comments.
--
To view, visit http://gerrit.ovirt.org/4276
To uns
Michael Kublin has posted comments on this change.
Change subject: core: Adding disk changes boot_order
..
Patch Set 3: Verified; Looks good to me, approved
U can use VmHandler.updateDisksFromDb(VM vm) and we need a little clea
Einav Cohen has posted comments on this change.
Change subject: userportal: Remove legacy UserPortal from build process
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4
Einav Cohen has posted comments on this change.
Change subject: userportal: Remove legacy UserPortal from build process
..
Patch Set 1: Verified
Applied and tested on my environment - looks OK.
--
To view, visit http://gerrit.
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/487/
Build Number: 487
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,115,
Started by upstream project "ovirt_engine" build nu
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix UpdateVmTemplateCommand failure
..
core: Fix UpdateVmTemplateCommand failure
Fix the failure in UpdateVmTemplateCommand due to new fields in th
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix UpdateVmCommand failure
..
core: Fix UpdateVmCommand failure
Fix the failure in UpdateVmCommand due to new fields in the VM.
Change-Id: I7512c
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix UpdateVmCommand failure
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4272
To unsubscribe, visit http:/
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix UpdateVmTemplateCommand failure
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4274
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Fix UpdateVmTemplateCommand failure
..
Patch Set 2: Verified
moved test to the test folder, fixed typo
--
To view, visit http://gerrit.ovirt.org/4274
To
Allon Mureinik has posted comments on this change.
Change subject: core: Fix UpdateVmCommand failure
..
Patch Set 3: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/4272
To unsubscribe, visit http://gerrit.ovirt.org/
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/486/
Build Number: 486
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,112,
Started by upstream project "ovirt_engine"
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Remove legacy UserPortal from build process
..
Patch Set 1:
Verified in both web and dev mode.
--
To view, visit http://gerrit.ovirt.org/4273
To uns
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: localization of the documentation/context sensitive
help url
..
webadmin: localization of the documentation/context sensitive help url
The do
Allon Mureinik has posted comments on this change.
Change subject: core: Clear NPEs from unit-tests
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: localization of the documentation/context sensitive
help url
..
Patch Set 2: Verified; Looks good to me, approved
rebased & verified
--
To view, visi
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Support for Remove Volume
..
webadmin: Support for Remove Volume
Note: Volume has to be stopped before removing it.
Change-Id: I02eab9ad75083
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Support for Remove Volume
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4105
To unsubscribe,
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - add copy action
..
webadmin: Quota - add copy action
Only ui action (combination of new & edit)
Change-Id: I6ee031dc1c62438f4ef31c6398fe7c8a4
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: disable DC in tree context
..
webadmin: disable DC in tree context
Change-Id: I446fa98e5ffa34770251230b426cc8e449b14f0f
Signed-off-by: Gilad Chaplik
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - enfore change quota name
..
webadmin: Quota - enfore change quota name
when editing default quota to a regular quota, you must remove the
'Def
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: limit quota threshold to 100
..
webadmin: limit quota threshold to 100
Change-Id: Ie15e9a371d4bffbe015846199f29d8bf24b5f9c6
Signed-off-by: Gilad Chapl
Michael Kublin has posted comments on this change.
Change subject: packaging: Don't try to package the VDS broker bean
..
Patch Set 1: Verified; Looks good to me, approved
Actually testing that patch right now. Thanks
--
To vi
Michael Kublin has submitted this change and it was merged.
Change subject: packaging: Don't try to package the VDS broker bean
..
packaging: Don't try to package the VDS broker bean
This bean has been removed in commit
d86788c
Moti Asayag has uploaded a new change for review.
Change subject: core: Clear NPEs from unit-tests
..
core: Clear NPEs from unit-tests
The patch replaces a direct call in AuditLogableBase to
DbFacade.getInstance() called on me
Moti Asayag has uploaded a new change for review.
Change subject: core: Support Sysprep for 3.1 and up (#811587)
..
core: Support Sysprep for 3.1 and up (#811587)
https://bugzilla.redhat.com/811587
The patch uses the VM Payload
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/939/
Build Number: 939
Build Status: Fixed
Triggered By: Started by user eedri
-
Changes Since Last Success:
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't try to package the VDS broker bean
..
packaging: Don't try to package the VDS broker bean
This bean has been removed in commit
d86788c4bf54d0f
Allon Mureinik has posted comments on this change.
Change subject: core: Fix UpdateVmTemplateCommand failure
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4274
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix UpdateVmTemplateCommand failure
..
core: Fix UpdateVmTemplateCommand failure
Fix the failure in UpdateVmTemplateCommand due to new fields in the
VM T
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: Remove legacy UserPortal from build process
..
userportal: Remove legacy UserPortal from build process
Summary of changes:
1. Legacy (SmartGWT-base
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/938/
Build Number: 938
Build Status: Still Failing
Triggered By: Started by user eedri
-
Changes Since Last Success:
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Allon Mureinik has posted comments on this change.
Change subject: core: Fix UpdateVmCommand failure
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix UpdateVmCommand failure
..
Patch Set 1: (1 inline comment)
Looks good, minor comments
File
backen
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix UpdateVmCommand failure
..
core: Fix UpdateVmCommand failure
Fix the failure in UpdateVmCommand due to new fields in the VM.
Change-Id: I7512ce817b5
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Added missing message in userportal-gwtp.
..
userportal: Added missing message in userportal-gwtp.
Change-Id: Ib04feaa39af5fc2055f3f721a6cf52e
Einav Cohen has posted comments on this change.
Change subject: userportal: Added missing message in userportal-gwtp.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4244
To unsubs
Gilad Chaplik has posted comments on this change.
Change subject: engine: Import VM more than once (#567580)
..
Patch Set 2: (5 inline comments)
replied to the comments..
Fi
Daniel Erez has posted comments on this change.
Change subject: searchbackend: Add search for shared and snapshotable
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/424
Oved Ourfali has abandoned this change.
Change subject: core: spice security channels fix
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/4266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Daniel Erez has posted comments on this change.
Change subject: frontend: Add active disks when creating a snapshot.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4225
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/485/
Build Number: 485
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,110,
Started by upstream project "ovirt_engine"
Oved Ourfali has uploaded a new change for review.
Change subject: core: fix split function and its use for spice security channels
..
core: fix split function and its use for spice security channels
Previous commit added the sp
Daniel Erez has posted comments on this change.
Change subject: webadmin: DataProvider now returns also POSIX for DC types
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3736
To unsubscrib
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Mike Kolesnik has posted comments on this change.
Change subject: core: Validate shared disk for export vm/template
..
Patch Set 5:
ExportVmTemplateCommand is a separate command but you didn't add check there so
either commit
Mike Kolesnik has posted comments on this change.
Change subject: core: Validate shared disk for export vm/template
..
Patch Set 8: (1 inline comment)
ExportVmTemplateCommand is a separate command but you didn't add check there
Haim Ateya has posted comments on this change.
Change subject: engine: Import VM more than once (#567580)
..
Patch Set 2: Verified
pre-ing test passed successfully (positive flows)
--
To view, visit http://gerrit.ovirt.org/416
Haim Ateya has posted comments on this change.
Change subject: core: search VM & Template by object id
..
Patch Set 2: Verified
pre-ing test passed successfully (positive flows)
--
To view, visit http://gerrit.ovirt.org/4159
T
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Basic Quota API Support
..
restapi: Basic Quota API Support
This patch enables viewing basic meta-data of the quotas within
a datacenter by GET on:
Ori Liel has posted comments on this change.
Change subject: restapi: Basic Quota API Support
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4188
To unsubscribe, visit http://gerr
Daniel Erez has posted comments on this change.
Change subject: webadmin: Filter out versions less than 3.1 for Posix DC
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3738
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove snapshots on Import VM fail (#813854)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4270
To unsubscribe, vis
Mike Kolesnik has posted comments on this change.
Change subject: core: Validate update disk for shared disk
..
Patch Set 3: (3 inline comments)
File
backend/manager/modules
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Mike Kolesnik has posted comments on this change.
Change subject: core: Add missing message in app errors
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3735
To unsubscribe, visit http://ge
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/484/
Build Number: 484
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,107,
Started by upstream project "ovirt_engine" build
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Remove snapshots on Import VM fail (#813854)
..
core: Remove snapshots on Import VM fail (#813854)
https://bugzilla.redhat.com/813854
If the command fail
Ori Liel has posted comments on this change.
Change subject: restapi: fix rsdl regression
..
Patch Set 1:
do not submit at this stage
--
To view, visit http://gerrit.ovirt.org/4269
To unsubscribe, visit http://gerrit.ovirt.org
1 - 100 of 476 matches
Mail list logo