Mike Kolesnik has posted comments on this change. Change subject: core: Validate shared disk for export vm/template ......................................................................
Patch Set 8: (1 inline comment) ExportVmTemplateCommand is a separate command but you didn't add check there so either commit message is wrong, or you missing that code.. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java Line 192: * Validate shared disk is not part of the VM which is export. This doc is redundant, you can just name the method validateVmHasNoSharedDisks -- To view, visit http://gerrit.ovirt.org/3792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b905fedb8f32451efbdb118da9613be3931b619 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
