Michael Kublin has posted comments on this change.
Change subject: core: Introduce allow snapshot attribute for disk
..
Patch Set 2:
why we need such field? It is a pm requirement?
--
To view, visit http://gerrit.ovirt.org/422
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/815/
Project: ovirt_engine_dao_unit_tests
Date of build: Wed, 09 May 2012 02:04:41 -0400
Build duration: 49 min
CHANGE SET
Revision ca129db1fa6553cf2753ad929953690fbd1fa611 by lhornyak: (core: [rmd]
move ListUtils
Michael Kublin has posted comments on this change.
Change subject: core: Add support for export/import regarding alias
..
Patch Set 5: (1 inline comment)
File
backend/manage
Michael Kublin has posted comments on this change.
Change subject: core: Validate shared disk for export vm/template
..
Patch Set 5: (2 inline comments)
File
backend/manager
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
..
Patch Set 4: Looks good to me, but someone else must approve
Reviewed .py, Makefile and .spec changes.
All good.
+1 unti
Shahar Havivi has posted comments on this change.
Change subject: restapi: add VmPayload support
..
Patch Set 8: Verified
(1 inline comment)
Commit Message
Line 19:
Please
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Doron Fediuck has posted comments on this change.
Change subject: core: Introducing MockConfigRule
..
Patch Set 3: (1 inline comment)
See inline
File pom.xml
Line 432:
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup VmStatic warnings
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/common/src/m
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Remove pubkey2ssh
..
core: Remove pubkey2ssh
Including this binary forces the Fedora RPM to be architecture
specific instead of noarch. It can be
Doron Fediuck has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 15: Verified; Looks good to me, approved
Rebased patch
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4217
To unsubscribe, visit http://gerrit.ovirt.org/
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Removing deprecated commands
..
webadmin: Removing deprecated commands
Hiding 'Move VM' and 'Copy Template'
Change-Id: Ieaa8d685d204238e81da24ab532af0b
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing MockConfigRule
..
Patch Set 3: Verified
Moved test-jar generation to the "root" pom, as per Laszlo's review.
--
To view, visit http://gerrit.
Omer Frenkel has posted comments on this change.
Change subject: core: license usage cleanup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4115
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: WIP: Introducing MockConfigRule
..
Patch Set 1: (1 inline comment)
File backend/manager/modules/utils
Doron Fediuck has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4222
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup of DiskImageDaoWrapper
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4228
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup of DiskImageDaoWrapper
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4228
To unsubscri
Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for shared when adding template
..
Patch Set 5:
rebase
--
To view, visit http://gerrit.ovirt.org/3790
To unsubscribe, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: core: Adding can do action messages for shared
..
Patch Set 4:
Changed few messages to include boot option in shared disk
--
To view, visit http://gerrit.ovirt.o
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use allow snapshot when Adding a disk to VM.
..
core: Use allow snapshot when Adding a disk to VM.
Set allow_snapshot to a new disk.
If the disk which is a
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Using snapshot with allow snapshot attribute
..
core: Using snapshot with allow snapshot attribute
Disk which are not allowed to be snapshot, should not be
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use allow snapshot attribute on disk update.
..
core: Use allow snapshot attribute on disk update.
Update allow snapshot field in the disk according to the
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use shareable disk when creating VM
..
core: Use shareable disk when creating VM
Use shareable indication when creating a VM, and need to transfer the
disk
Maor Lipchuk has uploaded a new change for review.
Change subject: frontend: Add active disks when creating a snapshot.
..
frontend: Add active disks when creating a snapshot.
Adding active disks in the parameters when creating
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Cleanup of DiskImageDaoWrapper
..
core: Cleanup of DiskImageDaoWrapper
Use overide annotation and final decleration.
Signed-off-by: Maor Lipchuk
Change-I
Maor Lipchuk has uploaded a new change for review.
Change subject: rest: Add comment for potential bug
..
rest: Add comment for potential bug
The equals should probably be changed since
there is no relation between id and vm sna
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use getAllForVm to filter by allow snapshot
..
core: Use getAllForVm to filter by allow snapshot
Adding an indication for allow snapshot disk in addAllForV
Maor Lipchuk has uploaded a new change for review.
Change subject: core: introduce allow snapshot attribute for disk
..
core: introduce allow snapshot attribute for disk
Adding field of allow snapshot to disk entity.
For now thi
Daniel Erez has posted comments on this change.
Change subject: core: [rmd] move ListUtils to common
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4141
To unsubscribe, visit http
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 14: Verified
Rebased and verified setup and installation. The following message appears in
the event log:
Installing Host
Allon Mureinik has posted comments on this change.
Change subject: core: Fix warnings in VmTemplateDAOTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4223
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStatic warnings
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - VM and VmTemplate (819603)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4224
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4222
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmTemplate warnings
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - DiskImage (819603)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4206
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup DiskImageDAO and its test
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pen
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix warnings in VmTemplateDAOTest
..
core: Fix warnings in VmTemplateDAOTest
Made private assert methods static, since they don't need instance
variables
Allon Mureinik has uploaded a new change for review.
Change subject: core: Quota UI fields - VM and VmTemplate (819603)
..
core: Quota UI fields - VM and VmTemplate (819603)
https://bugzilla.redhat.com/819603
Added fields to sh
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
core: Cleanup VmStaticDAODbFacadeImpl
Use a static instance of the row mapper, as per
http://ovirt.org/wiki/Backend_Co
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: DiskByAliasComparer
..
webadmin: DiskByAliasComparer
Sort disks by alias instead of internal drive mapping.
Change-Id: Iffc91961faf62cb80b1a0d107cd3cc9
BUILD FAILURE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/814/
Project: ovirt_engine_dao_unit_tests
Date of build: Tue, 08 May 2012 15:02:35 -0400
Build duration: 17 sec
CHANGE SET
Revision 84b6a8ef881aa4c450eb2d8bd1f0ad31648e906f by derez:
(webadmin,userportal: GetPermit
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: GetPermittedStorageDomainsByStoragePoolId
..
--
To view, visit http://gerrit.ovirt.org/4030
To unsubscribe, visit http://gerrit.ovirt.org/set
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks Permissions sub-tab
..
webadmin: Disks Permissions sub-tab
Added Permissions sub-tab under Disks main-tab.
Change-Id: I705178a780fc610d06
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: GetPermittedStorageDomainsByStoragePoolId
..
webadmin,userportal: GetPermittedStorageDomainsByStoragePoolId
Querying GetPermittedStor
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks Permissions sub-tab
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4031
To unsubscribe, vi
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: GetPermittedStorageDomainsByStoragePoolId
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: license usage cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
Note that you will have to rename the upgrade script.
03_01_1040 has
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmTemplate warnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStatic warnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - DiskImage (819603)
..
Patch Set 2: Verified
fiixed missed dependencies
--
To view, visit http://gerrit.ovirt.org/4206
To unsubscribe, v
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup VmStatic warnings
..
core: Cleanup VmStatic warnings
Addressed issues discovered by Eclipse IDE.
Change-Id: Ie7242569beb8b102318a4214a16fd7511b8
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup VM warnings
..
core: Cleanup VM warnings
Addressed issues discovered by Eclipse IDE.
Change-Id: I2a0005d567edd0969b1d8de9017eca630f82214c
Signed
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup DiskImageDAO and its test
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pen
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup VmTemplate warnings
..
core: Cleanup VmTemplate warnings
Addressed issues discovered by Eclipse IDE.
Change-Id: Ic668403ebdac61fad8d41e348ac2f61
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - grace & threshold
..
webadmin: Quota - grace & threshold
Signed-off-by: Gilad Chaplik
Change-Id: I006fe002dc87c73b10b2ba45586aa5c735bdfbad
--
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - filter admins from consumers
..
webadmin: Quota - filter admins from consumers
Signed-off-by: Gilad Chaplik
Change-Id: I6024b7f74e04214500d7a
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fix bug in disk search
..
webadmin: fix bug in disk search
Signed-off-by: Gilad Chaplik
Change-Id: Ic625e11336ccd18ee4eae4b81e6f2fb6762f0384
---
M
f
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - add search support in webadmin
..
webadmin: Quota - add search support in webadmin
also quota tab will be visible only in DC tree context.
Si
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Quota - UX improvements
..
webadmin: Quota - UX improvements
mainly rephrasing
Signed-off-by: Gilad Chaplik
Change-Id: Ie9e946587445aa1bb213f24d41b5
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: change locale location in login screen
..
webadmin: change locale location in login screen
no bz
move the locale box to the right buttom corner of the
Daniel Erez has posted comments on this change.
Change subject: webadmin: default values to appErrors
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4054
To unsubscribe, visit http://gerrit
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/779/
Project: ovirt_engine_unit_tests
Date of build: Tue, 08 May 2012 11:10:30 -0400
Build duration: 50 min
CHANGE SET
Revision 662470ad7b0e0a86bbf7d0956e6c0bdc0ee27994 by achub: (webadmin: Add
prestarted VMs field to
Adam Litke has posted comments on this change.
Change subject: gitignore: ignore PLY-generated files
..
Patch Set 4: Verified
Are there any outstanding issues with this patch?
--
To view, visit http://gerrit.ovirt.org/3516
To
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Eli Mesika has posted comments on this change.
Change subject: core: Cleanup DiskImageDAO and its test
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4205
To unsubscribe, visit http://gerri
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/778/
Project: ovirt_engine_unit_tests
Date of build: Tue, 08 May 2012 10:22:11 -0400
Build duration: 48 min
CHANGE SET
No changes
JUNIT RESULTS
Name: org.ovirt.engine.api.common.invocation Failed: 0 test(s),
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Add console reconnect
..
webadmin: Add console reconnect
This patch adds the user webadmin changes needed to support the
allow reconnect flag. T
Einav Cohen has posted comments on this change.
Change subject: userportal: Add console reconnect
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/817
To unsubscribe, visit http://
Einav Cohen has posted comments on this change.
Change subject: restapi: Add console reconnect
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/819
To unsubscribe, visit http://ger
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Add console reconnect
..
userportal: Add console reconnect
This patch adds the user portal changes needed to support the
allow reconnect flag.
Einav Cohen has submitted this change and it was merged.
Change subject: restapi: Add console reconnect
..
restapi: Add console reconnect
This patch adds the RESTAPI changes needed to support the allow
reconnect flag.
Change-I
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add console reconnect
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/818
To unsubscribe, visit http://ge
Einav Cohen has posted comments on this change.
Change subject: restapi: Add console reconnect
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/819
To unsubscribe, visit http://ger
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add console reconnect
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/818
To unsubscribe, visit http://ge
Einav Cohen has posted comments on this change.
Change subject: userportal: Add console reconnect
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/817
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Einav Cohen has posted comments on this change.
Change subject: userportal: Add console reconnect
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/817
To unsubscribe, visit http://gerrit.ovi
Ofer Schreiber has submitted this change and it was merged.
Change subject: tools: Separate tools into different packages (BZ803240)
..
tools: Separate tools into different packages (BZ803240)
https://bugzilla.redhat.com/803240
Ofer Schreiber has posted comments on this change.
Change subject: tools: Separate tools into different packages (BZ803240)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4194
To
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add console reconnect
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/818
To unsubscribe, visit http://gerrit.ovirt
Einav Cohen has posted comments on this change.
Change subject: userportal: Add console reconnect
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/817
To unsubscribe, visit http://gerrit.ovi
Einav Cohen has posted comments on this change.
Change subject: restapi: Add console reconnect
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/819
To unsubscribe, visit http://gerrit.ovirt.
Keith Robertson has posted comments on this change.
Change subject: tools: Separate tools into different packages (BZ803240)
..
Patch Set 3: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/4194
To unsubscribe, visit
Ofer Schreiber has posted comments on this change.
Change subject: tools: Separate tools into different packages (BZ803240)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4194
To unsubscrib
Alexey Chub has posted comments on this change.
Change subject: webadmin: Add prestarted VMs field to pool dialog
..
Patch Set 7: Verified; Looks good to me, approved
Rebased
--
To view, visit http://gerrit.ovirt.org/4079
To u
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: Add prestarted VMs field to pool dialog
..
webadmin: Add prestarted VMs field to pool dialog
Signed-off-by: Alexey Chub
change-Id: I02d707adbff
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add console reconnect
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/819
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Juan Hernandez has posted comments on this change.
Change subject: userportal: Add console reconnect
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/817
To unsubscribe, visit http://gerrit.ovirt.org/settings
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/777/
Project: ovirt_engine_unit_tests
Date of build: Tue, 08 May 2012 09:33:49 -0400
Build duration: 48 min
CHANGE SET
Revision 46cf1ba9dffaed227a8254a1dd74c6b28081ed3f by dgopal: (engine:
getUpServer method moved to
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Add console reconnect
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alexey Chub has posted comments on this change.
Change subject: webadmin: Add prestarted VMs field to pool dialog
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4079
To unsubscribe, visit h
Daniel Erez has posted comments on this change.
Change subject: webadmin: Add prestarted VMs field to pool dialog
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4079
To unsubscribe, visit h
Alexey Chub has posted comments on this change.
Change subject: webadmin: Add prestarted VMs field to pool dialog
..
--
To view, visit http://gerrit.ovirt.org/4079
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
1 - 100 of 238 matches
Mail list logo
