Michael Kublin has posted comments on this change. Change subject: core: Validate shared disk for export vm/template ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java Line 94: ImagesHandler.fillImagesBySnapshots(getVm()); the check at wrong place at any case, it it should be down, and maybe better to make it inside a method? Line 101: } Maybe better to allow export with out shared disk, for example at direct lun export will work but with out direct lun disks? -- To view, visit http://gerrit.ovirt.org/3792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b905fedb8f32451efbdb118da9613be3931b619 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
