Oved Ourfali has posted comments on this change.
Change subject: wip - engine: adding new support for native USB
..
Patch Set 1:
Allon - I'll address the comments.
Thank you.
--
To view, visit http://gerrit.ovirt.org/4121
To
Allon Mureinik has posted comments on this change.
Change subject: wip - backend: adding config entry for number of USB slots
..
Patch Set 1:
Can you explain the logic of choosing a default of 4 ports, or is it arbitrary?
Does
Allon Mureinik has posted comments on this change.
Change subject: wip - engine: adding new support for native USB
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
The code itself look ok, see
Ori Liel has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5:
Regarding 'gluster' prefix - I know that Geert thinks the prefix should be
removed as well. I'll
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetAllIsoImagesListParameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4146
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: new base classes for GetAllImageListQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4147
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: New queries to get ISOs by StoragePoolIds
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4148
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllIsoImagesListParameters
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4146
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup IsoDomainListSyncronizer
..
Patch Set 3: Verified
Rebased, solved merge conflicts with 0176243c77cfd06f46521ddeed0da4004d251ce6.
--
To view, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup RepoFileMetaDataDAO and its test
..
Patch Set 3: Verified
rebased, no changes since last review
--
To view, visit http://gerrit.ovirt.org/4076
To
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup repo_files_meta_data_sp.sql
..
Patch Set 9: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
--
Allon Mureinik has posted comments on this change.
Change subject: core: Removed unused license query types.
..
Patch Set 9: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
--
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup GetAllIsoImagesListParameters
..
core: Cleanup GetAllIsoImagesListParameters
Replaced * import with FQCN import.
Change-Id: I1e33d02a8b7ae362998
Allon Mureinik has uploaded a new change for review.
Change subject: core: new base classes for GetAllImageListQuery
..
core: new base classes for GetAllImageListQuery
Extracted base classes for the query and its parameter that
Allon Mureinik has uploaded a new change for review.
Change subject: core: New queries to get ISOs by StoragePoolIds
..
core: New queries to get ISOs by StoragePoolIds
Introduced two new queries to get ISO and Floppy RepoFileMet
Allon Mureinik has posted comments on this change.
Change subject: core: test for backend checkDBConnectivity
..
Patch Set 1: (4 inline comments)
Basically looks good, see inline comments.
.
Allon Mureinik has posted comments on this change.
Change subject: core: license usage cleanup
..
Patch Set 1:
looks OK on a SQL standpoint, but like ofrenkel, I don't quite understand the
removal of the table from the creatio
Allon Mureinik has posted comments on this change.
Change subject: core: some NFS mount options cleanup and test
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Generally looks good, but see
Allon Mureinik has posted comments on this change.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
Patch Set 3: (1 inline comment)
File
backend
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] move ListUtils to common
..
Patch Set 3: Looks good to me, but someone else must approve
The change itself seems fine to me - but I'm not quite sure
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 5:
uploading the patch is not enough, you need to verify it also (and mark it in
gerrit)
--
To view, visit http://gerri
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Display volumes in Search bar for Volumes related
Events
..
Patch Set 5: (2 inline comments)
upload a new patch, rebase & verify
22 matches
Mail list logo
