Allon Mureinik has posted comments on this change. Change subject: core: test for backend checkDBConnectivity ......................................................................
Patch Set 1: (4 inline comments) Basically looks good, see inline comments. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackendTest.java Line 87: @Test(expected = IllegalStateException.class) I Don't like the _ convention - why not plain old java-style checkDBConnectivityFailWithConnection Line 93: @Test(expected = IllegalStateException.class) Same here. Line 121: Consider extracting this method to a utility class - it may come in handy in other tests too. Line 126: modifiersField.setAccessible(true); I think that setAccessible should do the trick - is setting it as non-final and non-private really required? -- To view, visit http://gerrit.ovirt.org/4130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icab143177ff26f2af8580fa9b49bb9a6ec9cbfc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
