Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7: (2 inline comments)
This change looks very close, I agree with Omer's comments and added a small
one of my
Omer Frenkel has posted comments on this change.
Change subject: core: renaming Posix fs storage helper
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3743
To unsubscribe, visit http://gerr
Ori Liel has posted comments on this change.
Change subject: rest: split the hierarchy of BackendGroupsResource and
BackendDomainGroupsResource
..
Patch Set 1:
looks good, needs rebase to be merged
--
To view, visit http://ge
Ori Liel has posted comments on this change.
Change subject: rest: split the hierarchy of BackendGroupsResource and
BackendDomainGroupsResource
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerr
Mike Kolesnik has posted comments on this change.
Change subject: core : Change inheritance tree of DiskImage
..
Patch Set 2: Looks good to me, approved
In this case, from backend side it looks good.
Please make sure to get +2
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up VM Business Entity
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebase, no changes since last review.
--
To view, v
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmBase
..
Patch Set 4: Verified
rebae, fixed typo found by masayag in the previous patchset.
--
To view, visit http://gerrit.ovirt.org/3717
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmTemplate Bussiness Entity
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
--
Allon Mureinik has posted comments on this change.
Change subject: core: [DO NOT SUBMIT] Default quota name
..
Patch Set 7:
Changed QUOTA_NAME_SIZE in BussinessEntityDefinitions so it will fit the new
column definition in the
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanip VmBase
..
Patch Set 3: (1 inline comment)
Commit Message
Line 7: core: Cleanip VmBase
nice ci
Omer Frenkel has posted comments on this change.
Change subject: core: Refactor SchedulerUtilQuartz
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3247
To unsubscribe, visit http://gerrit.o
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7: (2 inline comments)
File
backend/manager/modules/bll/
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 11:
still missing set for vm type and action in the canDoAction of VmLogoffCommand
and VmLogonCommand
--
To view, visi
Michael Kublin has posted comments on this change.
Change subject: core : Change inheritance tree of DiskImage
..
Patch Set 2:
agree regards compensation, but we are not using a compensation mechanism at
any diskImage scenario
Moti Asayag has uploaded a new change for review.
Change subject: core: Change spec params type to HashMap
..
core: Change spec params type to HashMap
In order to support VM Payload feature, the spec param type is changed
from S
Moti Asayag has uploaded a new change for review.
Change subject: core: Extract deviceId from specParams of VmDevice
..
core: Extract deviceId from specParams of VmDevice
The patch extracts the deviceId from specParams into an e
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 6:
Remove redundant checks on the key algorithm.
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit http
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 5:
Removed references to pubkey2ssh binary from the makefile and the spec.
--
To view, visit http://gerrit.ovirt.org/3138
Danny Rankevich has posted comments on this change.
Change subject: webadmin: add MTU and Vm Network flags
..
Patch Set 2: Looks good to me, but someone else must approve
Looks Ok.
The NPE was caused by me (copy & paste :)
I t
Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 8: Looks good to me, but someone else must approve
Looks ok to me, but you removed the Display Network Ac
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
webadmin: adding externalize check to the frontend checkstyle
no bz
see http://gerrit.ovirt.org
Alona Kaplan has posted comments on this change.
Change subject: webadmin: user portal and webadmin localization
..
Patch Set 7:
Hi Vojtech, thanks for the comments.
* Why was UICommonWeb.gwt.xml deleted?
-I have deleted it by
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: user portal and webadmin localization
..
Patch Set 7:
Adding Einav as a reviewer
Einav, can you please also refer to all of the above comments? startin
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: user portal and webadmin localization
..
Patch Set 7:
Vojtech, can you please refer also to Daniel's and mine comments?
--
To view, visit http://gerri
24 matches
Mail list logo
