Mike Kolesnik has posted comments on this change.
Change subject: core: DAO to get a VMPool by it's ID, filtered
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3526
To unsubscribe, visit ht
Mike Kolesnik has posted comments on this change.
Change subject: core: Clean up VmPoolDAO and its test
..
Patch Set 3: (2 inline comments)
File
backend/manager/modules/dal/
Michael Kublin has uploaded a new change for review.
Change subject: restapi : Adding support for multiplre storage domains at rest
part for add vm scenarious
..
restapi : Adding support for multiplre storage domains at rest par
Michael Kublin has uploaded a new change for review.
Change subject: core : Clean up at add vm scenario
..
core : Clean up at add vm scenario
The following patch is removing unneeded parameters from engine part, the clean
up sh
Michael Kublin has uploaded a new change for review.
Change subject: userportal : Removing duplicated parameters at add vm scenarious
..
userportal : Removing duplicated parameters at add vm scenarious
The following patch is rem
ovirt_engine - Build # 804 - Fixed:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/804/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Remove description calculation for image
..
core: Remove description calculation for image
The description is a snapshot field so no need to calcu
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: full DiskImage on diskInfoDestinationMap
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/354
Michael Kublin has posted comments on this change.
Change subject: core: Remove description calculation for image
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3541
To unsubscribe, visit h
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: System Tree - Disks handling
..
webadmin: System Tree - Disks handling
Display 'Disks' main-tab on the following tree-items:
System, Datacenter and Stor
Daniel Erez has uploaded a new change for review.
Change subject: engine: SearchBackend DiskImageCrossRefAutoCompleter
..
engine: SearchBackend DiskImageCrossRefAutoCompleter
Added DiskImageCrossRefAutoCompleter to SearchBackend
Mike Kolesnik has posted comments on this change.
Change subject: core: Remove description calculation for image
..
Patch Set 2: Verified
Fixed after mkublin's comment
--
To view, visit http://gerrit.ovirt.org/3541
To unsubscr
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: create gluster volume implementation
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Gilad Chaplik has posted comments on this change.
Change subject: core: Retrieve job with steps by correlation ID
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
merge it, thanks
--
To view, visit htt
Tal Nisan has uploaded a new change for review.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
core: Permission filtering for GetVmTemplatesDisks
Change-Id: Ia9566bc9036a653d9477231fd05b9626e2f83d79
---
M
Roy Golan has posted comments on this change.
Change subject: engine: Validation of collections
..
Patch Set 1: Do not submit
following the discussion at engine-de...@redhat.com, the validator supports
validating arrays, lists
Michael Kublin has posted comments on this change.
Change subject: core: Remove description calculation for image
..
Patch Set 1: (1 inline comment)
small remark
File
backe
ovirt_engine - Build # 803 - Failure:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/803/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
ovirt_engine_dao_unit_tests - Build # 579 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/579/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman
Yair Zaslavsky has posted comments on this change.
Change subject: core: Lose disk alias upper case
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3544
To unsubscribe, visit http://gerrit.o
ovirt_engine_dao_unit_tests - Build # 578 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/578/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailm
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Linq DiskModelByAliasComparer
..
webadmin: Linq DiskModelByAliasComparer
Nullity check in DiskModelByAliasComparer
Change-Id: I1af055c911847647
Daniel Erez has posted comments on this change.
Change subject: webadmin: Linq DiskModelByAliasComparer
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3538
To unsubscribe
Moti Asayag has posted comments on this change.
Change subject: core: Add disk alias after removed
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3545
To unsubscribe, visit http://gerrit.ov
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: full DiskImage on diskInfoDestinationMap
..
webadmin: full DiskImage on diskInfoDestinationMap
Passing full DiskImage objects (instead of stubs)
on disk
Moti Asayag has posted comments on this change.
Change subject: core: Lose disk alias upper case
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
File
backend/
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed incorrect upgrade flow (#810685)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Fixed incorrect upgrade flow (#810685)
..
packaging: Fixed incorrect upgrade flow (#810685)
https://bugzilla.redhat.com/show_bug.cgi?id=810685
Fixed i
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add disk alias after removed
..
core: Add disk alias after removed
Adding disk alias when adding a disk, after it was mistackly removed in
the laast merge.
Maor Lipchuk has posted comments on this change.
Change subject: core: Add disk map to query
..
Patch Set 2: Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/3536
To unsubscribe, visit htt
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Lose disk alias upper case
..
core: Lose disk alias upper case
Use Disk instead of DISK, when automaticaly adding alias name.
This patch should fix the upg
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove description calculation for image
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3541
To u
Tal Nisan has uploaded a new change for review.
Change subject: core: permission filtering for getAllForVdsGroup
..
core: permission filtering for getAllForVdsGroup
Added permission filtering for getAllForVdsGroup and added a ne
Eli Mesika has uploaded a new change for review.
Change subject: core: New server vm is created without monitor device
..
core: New server vm is created without monitor device
Removing the condition that updates VM ceated from
ovirt_engine - Build # 800 - Fixed:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/800/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Omer Frenkel has posted comments on this change.
Change subject: engine: Stop Gluster Volume
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3348
To unsubscribe, visit http://gerrit.ovirt.or
Eli Mesika has submitted this change and it was merged.
Change subject: core: duplicate cdrom created when cloning a VM from snapshot
..
core: duplicate cdrom created when cloning a VM from snapshot
When a VM is created from sn
Eli Mesika has posted comments on this change.
Change subject: core: duplicate cdrom created when cloning a VM from snapshot
..
Patch Set 4: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org
ovirt_engine - Build # 799 - Failure:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/799/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Omer Frenkel has posted comments on this change.
Change subject: core: Add disk map to query
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3536
To unsubscribe, visit http://gerrit.ovirt.or
Omer Frenkel has posted comments on this change.
Change subject: engine: Start Gluster Volume
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3215
To unsubscribe, visit http://gerrit.ovirt.o
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Remove description calculation for image
..
core: Remove description calculation for image
The description is a snapshot field so no need to calculate it
Yair Zaslavsky has posted comments on this change.
Change subject: reports: adding EngineAuthentication jar to support
webadmin-reports integration
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, vi
Ofer Schreiber has submitted this change and it was merged.
Change subject: packagin: closing unnecessary opened iptables ports (#771665)
..
packagin: closing unnecessary opened iptables ports (#771665)
https://bugzilla.redhat.
Ofer Schreiber has posted comments on this change.
Change subject: packagin: closing unnecessary opened iptables ports (#771665)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/353
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetVmCustomPropertiesQuery a user query
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3540
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmCustomPropertiesQuery
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3539
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmByVmIdQuery
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3530
To unsubscribe, visit htt
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VM by it's ID, filtered
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3529
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: Minor cleanup in VmHandler and its test
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3528
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmPoolByIdQuery
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3527
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VMPool by it's ID, filtered
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3526
To unsubscribe, visit http
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up VmPoolDAO and its test
..
Patch Set 3: Verified
rebased only.
--
To view, visit http://gerrit.ovirt.org/3525
To unsubscribe, visit http://gerrit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup GetVmCustomPropertiesQuery
..
core: Cleanup GetVmCustomPropertiesQuery
General java cleanup - removed useless and auto-generated comments,
better
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetVmCustomPropertiesQuery a user query
..
core: Made GetVmCustomPropertiesQuery a user query
The query was redefined as a User query, so it could b
Oved Ourfali has posted comments on this change.
Change subject: core: use config value as LDAP provider type
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules
Yair Zaslavsky has posted comments on this change.
Change subject: core: use config value as LDAP provider type
..
Patch Set 3: (1 inline comment)
File
backend/manager/modul
Oved Ourfali has posted comments on this change.
Change subject: core: use config value as LDAP provider type
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules
Ofer Schreiber has posted comments on this change.
Change subject: packagin: closing unnecessary opened iptables ports (#771665)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3537
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: core: ValidateSession servlet fixes
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3535
To unsubscrib
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix update vm disk command
..
core: Fix update vm disk command
Use boolean value whether quota was changed or not.
With this indication I check if
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix update vm disk command
..
Patch Set 2: Verified; Looks good to me, approved
Acked by massayag
--
To view, visit http://gerrit.ovirt.org/3392
To unsubsc
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Linq DiskModelByAliasComparer
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3538
To unsubscribe, visit http://ge
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Linq DiskModelByAliasComparer
..
webadmin: Linq DiskModelByAliasComparer
Nullity check in DiskModelByAliasComparer
Change-Id: I1af055c9118476476e272f2b
Alex Lourie has posted comments on this change.
Change subject: packagin: closing unnecessary opened iptables ports (#771665)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://ge
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: added support for AMD Bulldozer cpu
..
engine: added support for AMD Bulldozer cpu
Change-Id: Ic0108c1c610ec4183ac0612183af74180d045350
---
A bac
Omer Frenkel has posted comments on this change.
Change subject: engine: added support for AMD Bulldozer cpu
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3531
To unsubscribe, visit http:/
Shahar Havivi has posted comments on this change.
Change subject: engine: added support for AMD Bulldozer cpu
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3531
To unsubscribe, visit http://gerrit.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: engine: added support for AMD Bulldozer cpu
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3531
To unsubscribe, visit http:/
Shahar Havivi has posted comments on this change.
Change subject: engine: added support for AMD Bulldozer cpu
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3531
To unsubscribe, visit http://gerrit.ovirt.org
Alex Lourie has uploaded a new change for review.
Change subject: packagin: closing unnecessary opened iptables ports (#771665)
..
packagin: closing unnecessary opened iptables ports (#771665)
https://bugzilla.redhat.com/show_bu
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add disk map to query
..
core: Add disk map to query
1. Setting disk map when fetching next availabe disk
2. User Disk instead of DISK in the diskAlias.
C
Oved Ourfali has posted comments on this change.
Change subject: core: use config value as LDAP provider type
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
See minor comment. worth fixing.
Oved Ourfali has posted comments on this change.
Change subject: core: add config value for LDAP servers provider types
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3532
To unsu
Omer Frenkel has posted comments on this change.
Change subject: engine: added support for AMD Bulldozer cpu
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3531
To unsubscribe, visit http:/
Oved Ourfali has uploaded a new change for review.
Change subject: core: ValidateSession servlet fixes
..
core: ValidateSession servlet fixes
Previous commit added this servlet, that validates the session, and
returns the logged
ovirt_engine_gwt_admin - Build # 366 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/366/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinf
Yaniv Dary has uploaded a new change for review.
Change subject: dwh: fixed regression in engine check
..
dwh: fixed regression in engine check
- Errors will not happen on date context.
- Will report errors on sampling to log.
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
--
To
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
Allon Mureinik has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 7: Verified
rebase, answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/3424
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: Support for reusing default quotas
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
--
Allon Mureinik has posted comments on this change.
Change subject: core: Remove PowerMockito from QuotaHelperTest
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: Minor clean up in QuotaHelper
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
--
To vi
Allon Mureinik has posted comments on this change.
Change subject: core: Improvements for AddEmptyStoragePoolCommand
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 rev
Roy Golan has uploaded a new change for review.
Change subject: core: use config value as LDAP provider type
..
core: use config value as LDAP provider type
https://bugzilla.redhat.com/808129
make the UsersDomainsCacheManagerSe
Roy Golan has uploaded a new change for review.
Change subject: core: add config value for LDAP servers provider types
..
core: add config value for LDAP servers provider types
https://bugzilla.redhat.com/808129
Change-Id: Ibb0
ovirt_engine_unit_tests - Build # 588 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/588/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinf
Shahar Havivi has uploaded a new change for review.
Change subject: engine: added support for AMD Bulldozer cpu
..
engine: added support for AMD Bulldozer cpu
Change-Id: Ic0108c1c610ec4183ac0612183af74180d045350
---
A backend/ma
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmByVmIdQuery
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3530
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VM by it's ID, filtered
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3529
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Minor cleanup in VmHandler and its test
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3528
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmPoolByIdQuery
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3527
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VMPool by it's ID, filtered
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3526
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up VmPoolDAO and its test
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3525
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmByVmIdQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3530
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VM by it's ID, filtered
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3529
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Minor cleanup in VmHandler and its test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3528
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmPoolByIdQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3527
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: DAO to get a VMPool by it's ID, filtered
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3526
To unsubscribe, visit http://gerrit.ovirt
1 - 100 of 188 matches
Mail list logo