Mike Kolesnik has posted comments on this change.
Change subject: core: Clean up VmPoolDAO and its test
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 22: * {@link org.ovirt.engine.core.dal.dbbroker.DbFacad}.
Why delete 'e' at the end?
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDAOTest.java
Line 156
You sure this should be deleted instead of uncommented and fixed?
I don't see any other test for this method so this reduces our DAO test
coverage.
--
To view, visit http://gerrit.ovirt.org/3525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08d8e317e6ef9a2c7e469e8ccc6792af99204c70
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
