[Engine-patches] Change in ovirt-engine[master]: core : Introducing of use of locks at related to disk comman...

2012-04-10 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Introducing of use of locks at related to disk commands .. core : Introducing of use of locks at related to disk commands The following patch wi

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of use of locks at related to disk comman...

2012-04-10 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Introducing of use of locks at related to disk commands .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of use of locks at related to disk comman...

2012-04-10 Thread lpeer
Livnat Peer has posted comments on this change. Change subject: core : Introducing of use of locks at related to disk commands .. Patch Set 2: Looks good to me, approved (3 inline comments) I rephrased dome of the comments you

[Engine-patches] Change in ovirt-engine[master]: engine: [DO-NOT-MERGE] Project Lombok POC

2012-04-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: [DO-NOT-MERGE] Project Lombok POC .. Patch Set 2: Fails Rebased, returned @NotNull validation to diskInterface. Again, do not merge -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Reuse default quota on DC update

2012-04-10 Thread lpeer
Livnat Peer has posted comments on this change. Change subject: core: Reuse default quota on DC update .. Patch Set 2: (3 inline comments) File backend/manager/modules/bll/s

[Engine-patches] Change in ovirt-engine[master]: core: Check permission on Storage Domain when adding disk

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Check permission on Storage Domain when adding disk .. Patch Set 2: Applied comments from ofrenkel. -- To view, visit http://gerrit.ovirt.org/3399 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: Add disk actions and predefined roles

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Add disk actions and predefined roles .. Patch Set 2: renamed function name to be unique and updated upgrade scripts name due to a version collision. -- To

[Engine-patches] Change in ovirt-engine[master]: core: Add Disk and Quota to get_entity_by_name STP

2012-04-10 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Add Disk and Quota to get_entity_by_name STP .. core: Add Disk and Quota to get_entity_by_name STP The patch adds support for Disk and Quota in the

[Engine-patches] Change in ovirt-engine[master]: core: Add Disk and Quota to get_entity_by_name STP

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Add Disk and Quota to get_entity_by_name STP .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3395 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: Minor cleanup for Image Parameters classes

2012-04-10 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Minor cleanup for Image Parameters classes .. core: Minor cleanup for Image Parameters classes Minor cleanup for Image Parameters classes Change-Id

[Engine-patches] Change in ovirt-engine[master]: core: Minor cleanup for Image Parameters classes

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Minor cleanup for Image Parameters classes .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3394 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: Check permission on Storage Domain when adding disk

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Check permission on Storage Domain when adding disk .. Patch Set 1: (4 inline comments) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: webadmin: manage cluster networks dialog

2012-04-10 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: webadmin: manage cluster networks dialog .. Patch Set 7: The "Required" flag should be set during the Attach/Detach Action on the backend. The flag should be

[Engine-patches] Change in ovirt-engine[master]: webadmin: manage cluster networks dialog

2012-04-10 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: webadmin: manage cluster networks dialog .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3209 To unsu

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clone VM from snapshots tweaks

2012-04-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: webadmin: Clone VM from snapshots tweaks .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3418 To unsub

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #229

2012-04-10 Thread Jenkins oVirt Server
See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 555 - Fixed!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 555 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/555/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #228

2012-04-10 Thread Jenkins oVirt Server
See -- [...truncated 2075 lines...] [INFO] [WARN] Template with variable in CSS attribute context: The template code generator cannot guarantee HTML-safety of the template --

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #227

2012-04-10 Thread Jenkins oVirt Server
See -- [...truncated 2089 lines...] [INFO] Invoking generator com.google.gwt.rpc.rebind.RpcServiceGenerator [INFO]Generating client proxy for remote service interface

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 554 - Failure!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 554 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/554/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailm

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #226

2012-04-10 Thread Jenkins oVirt Server
See Changes: [mlipchuk] userportal: Use underline instead of dot in message -- [...truncated 2313 lines...] [ERROR] [AppClassLoader@61ba34f2] info using configuration

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 566 - Fixed!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 566 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/566/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: core: Add queries for fetching Permitted Storage Domains

2012-04-10 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: core: Add queries for fetching Permitted Storage Domains .. core: Add queries for fetching Permitted Storage Domains The patch adds two queries for fetching Stora

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 325 - Still Failing!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_user - Build # 325 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/325/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/lis

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #225

2012-04-10 Thread Jenkins oVirt Server
See Changes: [yzaslavs] core: Fixing of DC version for AddVmFromSnapshot -- [...truncated 2979 lines...] [INFO] ERROR_CANNOT_EXTEND_CONNECTION_FAILED [INFO]

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup storage server connection DAO

2012-04-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Cleanup storage server connection DAO .. core: Cleanup storage server connection DAO Defining a single mapper , and setting it to be static Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: common: Adding more fields to storage_server_connections

2012-04-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: common: Adding more fields to storage_server_connections .. common: Adding more fields to storage_server_connections Adding spec, mountOptions and vfsType to s

[Engine-patches] Change in ovirt-engine[master]: userportal: Use underline instead of dot in message

2012-04-10 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: userportal: Use underline instead of dot in message .. userportal: Use underline instead of dot in message Fixing exception by using underline instead of

[Engine-patches] Change in ovirt-engine[master]: userportal: Use underline instead of dot in message

2012-04-10 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Use underline instead of dot in message .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3433 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: userportal: Use underline instead of dot in message

2012-04-10 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: userportal: Use underline instead of dot in message .. userportal: Use underline instead of dot in message Fixing exception by using underline instead of dot in

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 324 - Still Failing!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_user - Build # 324 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/324/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/lis

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #224

2012-04-10 Thread Jenkins oVirt Server
See -- [...truncated 3010 lines...] [INFO] CAN_DO_ACTION_GENERAL_FAILURE [INFO] [WARN] For the following type(s), generated source was never committed (did you

[Engine-patches] Change in ovirt-engine[master]: webadmin: manage cluster networks dialog

2012-04-10 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: manage cluster networks dialog .. Patch Set 7: Submitted new patch that sets up ClusterNetworkManageModel's "vmNetwork" and "required" fields accordin

[Engine-patches] Change in ovirt-engine[master]: core: Remove JAXB from storage_server_connections

2012-04-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Remove JAXB from storage_server_connections .. core: Remove JAXB from storage_server_connections Removing JAXB annotations from storage_server_connection

[Engine-patches] Change in ovirt-engine[master]: core: Adding PosixFS storage helper

2012-04-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Adding PosixFS storage helper .. core: Adding PosixFS storage helper Change-Id: Ibff515ccf588315e28b1424438dda0b526978ecc --- M backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: Fixing of DC version for AddVmFromSnapshot

2012-04-10 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing of DC version for AddVmFromSnapshot .. core: Fixing of DC version for AddVmFromSnapshot DC version for AddVmFromSnapshot should be 3.1 Ch

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 565 - Failure!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 565 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/565/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] Change in ovirt-engine[master]: core: Fixing of DC version for AddVmFromSnapshot

2012-04-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing of DC version for AddVmFromSnapshot .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3430 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Fixing of DC version for AddVmFromSnapshot

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fixing of DC version for AddVmFromSnapshot .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3430 To unsubscribe, visit h

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #223

2012-04-10 Thread Jenkins oVirt Server
See Changes: [mlipchuk] engine: Fix NPE for VM from snapshot (#810897) -- [...truncated 2998 lines...] [INFO] ACTION_TYPE_FAILED_ROLE_IS_READ_ONLY [INFO]

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 323 - Still Failing!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_user - Build # 323 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/323/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/lis

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 322 - Still Failing!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_user - Build # 322 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/322/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/lis

[Engine-patches] Change in ovirt-engine[master]: core: Fixing DC version for AddVmFromSnapshot

2012-04-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fixing DC version for AddVmFromSnapshot .. core: Fixing DC version for AddVmFromSnapshot DC version for AddVmFromSnapshot should be 3.1 Change-Id: I87ea

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #222

2012-04-10 Thread Jenkins oVirt Server
See Changes: [lhornyak] rest-api: close stream [mlipchuk] searchbackend: Change disk search to use new view [mlipchuk] core: Add can do action message for disk alias [mlipchuk] core: Add validation for disk alias name. [mlipc

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 321 - Failure!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_user - Build # 321 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/321/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/

[Engine-patches] Change in ovirt-engine[master]: core: Reuse default quota on DC update

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Reuse default quota on DC update .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3426 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup UpdateStoragePoolCommand, etc.

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup UpdateStoragePoolCommand, etc. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3425 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Set quota as non default when edited

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Set quota as non default when edited .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3424 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Support for reusing default quotas

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Support for reusing default quotas .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3423 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: Remove PowerMockito from QuotaHelperTest

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove PowerMockito from QuotaHelperTest .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3422 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Minor clean up in QuotaHelper

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Minor clean up in QuotaHelper .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3421 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: Improvements for AddEmptyStoragePoolCommand

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Improvements for AddEmptyStoragePoolCommand .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3420 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE for VM from snapshot (#810897)

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Fix NPE for VM from snapshot (#810897) .. engine: Fix NPE for VM from snapshot (#810897) Fix create VM from snapshot, after refactor of multiple

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE for VM from snapshot (#810897)

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Fix NPE for VM from snapshot (#810897) .. Patch Set 3: Verified; Looks good to me, approved Acked by Yair Zaslavski -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE for VM from snapshot (#810897)

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Fix NPE for VM from snapshot (#810897) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3416 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE for VM from snapshot (#810897)

2012-04-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Fix NPE for VM from snapshot (#810897) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3416 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Check permissions on disk when removing a disk

2012-04-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Check permissions on disk when removing a disk .. Patch Set 1: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: Check permissions on disk when removing a disk

2012-04-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Check permissions on disk when removing a disk .. Patch Set 1: (2 inline comments) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: searchbackend: Change disk search to use new view

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: searchbackend: Change disk search to use new view .. searchbackend: Change disk search to use new view 1. Changing existing view to use postgres function

[Engine-patches] Change in ovirt-engine[master]: core:Add support for disk alias to commands

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core:Add support for disk alias to commands .. core:Add support for disk alias to commands Add support for disk alias to the following actions: 1. Add/Up

[Engine-patches] Change in ovirt-engine[master]: core: Add upgrade script for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add upgrade script for disk alias .. core: Add upgrade script for disk alias Adding an upgrade script for nitialization of disk alias name. Each di

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for disk alias name.

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add validation for disk alias name. .. core: Add validation for disk alias name. Use 255 characters for disk alias, and changing the DB accordingly

[Engine-patches] Change in ovirt-engine[master]: core: Add can do action message for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add can do action message for disk alias .. core: Add can do action message for disk alias Adding can do action message for validating disk alias n

[Engine-patches] Change in ovirt-engine[master]: core: Add query for suggested disk alias name

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add query for suggested disk alias name .. core: Add query for suggested disk alias name Add query which suppose to return suggested disk name. Ch

[Engine-patches] Change in ovirt-engine[master]: core: Refactor method to handler

2012-04-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Refactor method to handler .. core: Refactor method to handler Refactoring suggested image name with next internal drive mapping to be used from VM

[Engine-patches] Change in ovirt-engine[master]: searchbackend: Change disk search to use new view

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: searchbackend: Change disk search to use new view .. Patch Set 8: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: Add can do action message for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add can do action message for disk alias .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for disk alias name.

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add validation for disk alias name. .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Add upgrade script for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add upgrade script for disk alias .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Refactor method to handler

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Refactor method to handler .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Add query for suggested disk alias name

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add query for suggested disk alias name .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core:Add support for disk alias to commands

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Add support for disk alias to commands .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: searchbackend: Change disk search to use new view

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: searchbackend: Change disk search to use new view .. Patch Set 7: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: Add can do action message for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add can do action message for disk alias .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for disk alias name.

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add validation for disk alias name. .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Add upgrade script for disk alias

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add upgrade script for disk alias .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Refactor method to handler

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Refactor method to handler .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Add query for suggested disk alias name

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add query for suggested disk alias name .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core:Add support for disk alias to commands

2012-04-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Add support for disk alias to commands .. Patch Set 6: Verified; Looks good to me, approved Acked by ofrenkel + Passed preintegration -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: [DO-NOT-MERGE] Project Lombok POC

2012-04-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: [DO-NOT-MERGE] Project Lombok POC .. Patch Set 1: Fails Do not merge, POC only -- To view, visit http://gerrit.ovirt.org/3427 To unsubscribe, visit http

[Engine-patches] Change in ovirt-guest-agent[master]: agent: renamed to rhevm-guest-agent in RHEL distribution.

2012-04-10 Thread ghammer
Gal Hammer has posted comments on this change. Change subject: agent: renamed to rhevm-guest-agent in RHEL distribution. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3419 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: [DO-NOT-MERGE] Project Lombok POC

2012-04-10 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: engine: [DO-NOT-MERGE] Project Lombok POC .. engine: [DO-NOT-MERGE] Project Lombok POC Project Lombok allows to write simpler POJOs while taking care of the boi

[Engine-patches] Change in ovirt-guest-agent[master]: updated change-log for version 1.0.2-1.

2012-04-10 Thread ghammer
Gal Hammer has posted comments on this change. Change subject: updated change-log for version 1.0.2-1. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3149 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: Set quota as non default when edited

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Set quota as non default when edited .. core: Set quota as non default when edited Upon editing a quota (via the UpdateQuotaCommand) the quota will be se

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup UpdateStoragePoolCommand, etc.

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Cleanup UpdateStoragePoolCommand, etc. .. core: Cleanup UpdateStoragePoolCommand, etc. Clean up UpgradeStoragePoolCommand, its superclass and its test.

[Engine-patches] Change in ovirt-engine[master]: core: Reuse unlimited quota on DC update

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Reuse unlimited quota on DC update .. core: Reuse unlimited quota on DC update When updating a Data Center to disable its quota enforcement, reuse an exi

[Engine-patches] Change in ovirt-engine[master]: core: Support for reusing default quotas

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Support for reusing default quotas .. core: Support for reusing default quotas Added overloading to QutoaHelper's method to allow reusing a default quota

[Engine-patches] Change in ovirt-engine[master]: core: Remove PowerMockito from QuotaHelperTest

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove PowerMockito from QuotaHelperTest .. core: Remove PowerMockito from QuotaHelperTest Changed QuotaHelperTest to use spying instead of PowerMocking

[Engine-patches] Change in ovirt-engine[master]: core: Improvements for AddEmptyStoragePoolCommand

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Improvements for AddEmptyStoragePoolCommand .. core: Improvements for AddEmptyStoragePoolCommand Made some minor improvements: 1. Java cleanup 2. Extract

[Engine-patches] Change in ovirt-engine[master]: core: Minor clean up in QuotaHelper

2012-04-10 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Minor clean up in QuotaHelper .. core: Minor clean up in QuotaHelper Marked the Long constants with L notation instead of l notation for better readabili

[Engine-patches] Change in ovirt-engine[master]: core: Update integer value of StorageType.All

2012-04-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update integer value of StorageType.All .. Patch Set 1: (1 inline comment) looks ok, need frontend to verify ..

[Engine-patches] Change in ovirt-guest-agent[master]: agent: renamed to rhevm-guest-agent in RHEL distribution.

2012-04-10 Thread ghammer
Gal Hammer has uploaded a new change for review. Change subject: agent: renamed to rhevm-guest-agent in RHEL distribution. .. agent: renamed to rhevm-guest-agent in RHEL distribution. Change-Id: I7825920f81a37cf4139aa4f37f111510

[Engine-patches] Change in ovirt-engine[master]: core: Add DISK_OPERATOR role to user when creating disk

2012-04-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add DISK_OPERATOR role to user when creating disk .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3400 To unsubscribe,

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 339 - Failure!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_gwt_admin - Build # 339 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/339/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: webadmin: QuotaEnforcementTypeEnum typo fix

2012-04-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: QuotaEnforcementTypeEnum typo fix .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3415 To un

[Engine-patches] Change in ovirt-engine[master]: core: Check permission on Storage Domain when adding disk

2012-04-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Check permission on Storage Domain when adding disk .. Patch Set 1: (5 inline comments) File backend/m

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 547 - Fixed!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 547 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/547/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clone VM from snapshots tweaks

2012-04-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: webadmin: Clone VM from snapshots tweaks .. Patch Set 1: (1 inline comment) Minor comment. File frontend/

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE for VM from snapshot (#810897)

2012-04-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Fix NPE for VM from snapshot (#810897) .. Patch Set 1: I would prefer that you didn't submit this 1. UI does not send DiskInfoList anymore - the line of

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 546 - Still Failing!

2012-04-10 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 546 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/546/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org

  1   2   >