Moti Asayag has posted comments on this change.
Change subject: core: Check permissions on disk when removing a disk
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 39: private List<PermissionSubject> permsList = null;
It is being 1-2 times, depends if the command implementing the
getJobMessageProperties()
Line 219: if (disk.getvm_guid() != null) {
According to the design you're correct. In remove disk we should ask only for a
permissions on the disk.
--
To view, visit http://gerrit.ovirt.org/3401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40a033cafef8eed8cc02f960a02d2f4295e6480a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
