[Engine-patches] Change in ovirt-engine[master]: core: Remove unused fields from image tables

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove unused fields from image tables .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3065 To u

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused fields from image tables

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Remove unused fields from image tables .. Patch Set 3: (2 inline comments) File backend/manager/dbscri

[Engine-patches] Change in ovirt-engine[master]: core: Duplicate key violation during add vm device (#806640)

2012-03-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Duplicate key violation during add vm device (#806640) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3085 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Duplicate key violation during add vm device (#806640)

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Duplicate key violation during add vm device (#806640) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3085 To unsubsc

[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 84 - Still Failing!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 84 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/84/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: packaging: Replace pubkey2ssh with ssh-keygen

2012-03-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Replace pubkey2ssh with ssh-keygen .. Patch Set 1: Note that the option used to import PKCS8 keys was introduced with version 5.6 of openssh, so it

[Engine-patches] Change in ovirt-engine[master]: core : Introducing RemoveDiskCommand

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core : Introducing RemoveDiskCommand .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3022 To un

[Engine-patches] Change in ovirt-engine[master]: core : Clean up and preperation for RemoveDiskCommand

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core : Clean up and preperation for RemoveDiskCommand .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: packaging: Replace pubkey2ssh with ssh-keygen

2012-03-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Replace pubkey2ssh with ssh-keygen .. packaging: Replace pubkey2ssh with ssh-keygen Newer versions of ssh-keygen have the capability to read public

[Engine-patches] Change in ovirt-engine[master]: webadmin: Input widget styling fix (#784379)

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Input widget styling fix (#784379) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2994 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: webadmin : Adding missing const to AppErrors.java

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin : Adding missing const to AppErrors.java .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3074 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs in uicommonweb project

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix findbugs in uicommonweb project .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2912 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Duplicate key violation during add vm device (#806640)

2012-03-25 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Duplicate key violation during add vm device (#806640) .. core: Duplicate key violation during add vm device (#806640) https://bugzilla.redhat.com/806640

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix bug- set quota in dropdown

2012-03-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: fix bug- set quota in dropdown .. webadmin: fix bug- set quota in dropdown edit template, edit vm Change-Id: Iac597ba4088dbc9781b22afb01c5470a73a629c

[Engine-patches] Change in ovirt-engine[master]: webadmin: add quota to add/edit disk

2012-03-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: add quota to add/edit disk .. webadmin: add quota to add/edit disk *the quota dropdown will be visible only if the quota isn't disabled on DC. *in new

[Engine-patches] Change in ovirt-engine[master]: webadmin: quota - fixing typo in package name

2012-03-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: quota - fixing typo in package name .. webadmin: quota - fixing typo in package name Change-Id: Icf4f69c6932d291f811d0481164efa2734e38657 --- M front

[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 83 - Still Failing!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 83 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/83/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused fields from image tables

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove unused fields from image tables .. Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) Basically looks good, see some

[Engine-patches] Change in ovirt-engine[master]: webadmin: Avoid NPE in Enum Translator (#802370)

2012-03-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: Avoid NPE in Enum Translator (#802370) .. webadmin: Avoid NPE in Enum Translator (#802370) https://bugzilla.redhat.com/802370 In this bug the origin

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused fields from image tables

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Remove unused fields from image tables .. Patch Set 3: Verified Patch set 2: Removed fields also from DAO. Patch set 3: Just rebased. -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core:Add support for disk alias to commands

2012-03-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Add support for disk alias to commands .. Patch Set 2: Add snapshot support for disk_alias and disk description -- To view, visit http://gerrit.ovirt.org/30

[Engine-patches] Change in ovirt-engine[master]: searchbackend: Change disk search to use new view

2012-03-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: searchbackend: Change disk search to use new view .. Patch Set 3: Use the disk alias and disk description through images_storage_domain_view instead vm_images_vi

[Engine-patches] Change in ovirt-engine[master]: core: Return general quota in no specific quota

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Return general quota in no specific quota .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3078 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: getQuotaVdsGroupByQuotaGuidWithGlobalDefault

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: getQuotaVdsGroupByQuotaGuidWithGlobalDefault .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3077 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup QuaotaDAOTest

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup QuaotaDAOTest .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerr

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in StorageQuota

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in StorageQuota .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3075 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: Return general quota in no specific quota

2012-03-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Return general quota in no specific quota .. core: Return general quota in no specific quota Fixed GetQuotaVdsGroupByQuotaIdQuery to return the generic q

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in StorageQuota

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in StorageQuota .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/3075 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in StorageQuota

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in StorageQuota .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3075 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: getQuotaVdsGroupByQuotaGuidWithGlobalDefault

2012-03-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: getQuotaVdsGroupByQuotaGuidWithGlobalDefault .. core: getQuotaVdsGroupByQuotaGuidWithGlobalDefault Added a method to QuotaDAO to return the QuotaVdsGroup

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup QuaotaDAOTest

2012-03-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Cleanup QuaotaDAOTest .. core: Cleanup QuaotaDAOTest General java cleanup: 1. Proper use of JUnit features - don't call setUp directly, allow the frameow

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in StorageQuota

2012-03-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Fix warnings in StorageQuota .. core: Fix warnings in StorageQuota Added missing @Override annotations. Change-Id: I86992b1d2b98c359401d3feef1571a4ecaae

[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 82 - Still Failing!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 82 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/82/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: packaging: Allow easy change of JBoss version

2012-03-25 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Allow easy change of JBoss version .. packaging: Allow easy change of JBoss version Move all refrences to JBoss into consts, including: - J

[Engine-patches] Change in ovirt-engine[master]: packaging: Allow easy change of JBoss version

2012-03-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Allow easy change of JBoss version .. Patch Set 2: Verified; Looks good to me, approved Acked by Alex -- To view, visit http://gerrit.ovirt.org/3072

[Engine-patches] Change in ovirt-engine[master]: packaging: Allow easy change of JBoss version

2012-03-25 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Allow easy change of JBoss version .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3072 To uns

[Engine-patches] Change in ovirt-engine[master]: ovirt-engine: update mvn opts in Makefile

2012-03-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: ovirt-engine: update mvn opts in Makefile .. Patch Set 1: Fails (2 inline comments) File Makefile Line 26:

[Engine-patches] Change in ovirt-engine[master]: webadmin : Adding missing const to AppErrors.java

2012-03-25 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: webadmin : Adding missing const to AppErrors.java .. webadmin : Adding missing const to AppErrors.java The following patch will add a missing const to AppError

[Engine-patches] Change in ovirt-engine[master]: core: fixing a bug when importing 3.0 VM or template that ha...

2012-03-25 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: fixing a bug when importing 3.0 VM or template that has interfaces .. core: fixing a bug when importing 3.0 VM or template that has interfaces Templ

[Engine-patches] Change in ovirt-engine[master]: core: fixing a bug when importing 3.0 VM or template that ha...

2012-03-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fixing a bug when importing 3.0 VM or template that has interfaces .. Patch Set 3: Verified; Looks good to me, approved rebase -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core : Clean up and preperation for RemoveDiskCommand

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Clean up and preperation for RemoveDiskCommand .. Patch Set 3: rebased -- To view, visit http://gerrit.ovirt.org/3021 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: packaging: Allow easy change of JBoss version

2012-03-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Allow easy change of JBoss version .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3072 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: ovirt-engine: update mvn opts in Makefile

2012-03-25 Thread eedri
Eyal Edri has uploaded a new change for review. Change subject: ovirt-engine: update mvn opts in Makefile .. ovirt-engine: update mvn opts in Makefile Change-Id: I2b804a4f49b9b1db6cdbe5aea13b17d88091b6b4 --- M Makefile 1 file ch

[Engine-patches] Change in ovirt-engine[master]: packaging: Allow easy change of JBoss version

2012-03-25 Thread oschreib
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: Allow easy change of JBoss version .. packaging: Allow easy change of JBoss version Move all refrences to JBoss into consts, including: - JBoss use

[Engine-patches] Change in ovirt-engine[master]: core: fixing a bug when importing 3.0 VM or template that ha...

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: fixing a bug when importing 3.0 VM or template that has interfaces .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3

[Engine-patches] Change in ovirt-engine[master]: engine: Add query for suggested disk alias name

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Add query for suggested disk alias name .. engine: Add query for suggested disk alias name Add query which suppose to return suggested disk name. Change

[Engine-patches] Change in ovirt-engine[master]: core:Add support for disk alias to commands

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core:Add support for disk alias to commands .. core:Add support for disk alias to commands Add support for disk alias to the following actions: 1. Add/Update dis

[Engine-patches] Change in ovirt-engine[master]: core: Add upgrade script for disk alias

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Add upgrade script for disk alias .. core: Add upgrade script for disk alias Adding an upgrade script for nitialization of disk alias name. Each disk will

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for disk alias name.

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Add validation for disk alias name. .. core: Add validation for disk alias name. Use 255 characters for disk alias, and changing the DB accordingly. Adding

[Engine-patches] Change in ovirt-engine[master]: core: Add can do action message for disk alias

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Add can do action message for disk alias .. core: Add can do action message for disk alias Adding can do action message for validating disk alias name. Ch

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor method to handler

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Refactor method to handler .. engine: Refactor method to handler Refactoring suggested image name with next internal drive mapping to be used from VM and

[Engine-patches] Change in ovirt-engine[master]: core : Clean up and preperation for RemoveDiskCommand

2012-03-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core : Clean up and preperation for RemoveDiskCommand .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3021 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core : Adding grouping of storages at additional queries

2012-03-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Adding grouping of storages at additional queries .. core : Adding grouping of storages at additional queries The following patch is adding addi

[Engine-patches] Change in ovirt-engine[master]: core : Adding grouping of storages at additional queries

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding grouping of storages at additional queries .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core : Adding grouping of storages at additional queries

2012-03-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Adding grouping of storages at additional queries .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3063 To

[Engine-patches] Change in ovirt-engine[master]: core: Change at rollback for MoveOrCopyImageGroup

2012-03-25 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Change at rollback for MoveOrCopyImageGroup .. core: Change at rollback for MoveOrCopyImageGroup For now, the rollback will be supported only for

[Engine-patches] Change in ovirt-engine[master]: core: Change at rollback for MoveOrCopyImageGroup

2012-03-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Change at rollback for MoveOrCopyImageGroup .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3064 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Change at rollback for MoveOrCopyImageGroup

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Change at rollback for MoveOrCopyImageGroup .. -- To view, visit http://gerrit.ovirt.org/3064 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: core: Change at rollback for MoveOrCopyImageGroup

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Change at rollback for MoveOrCopyImageGroup .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3064 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused fields from image tables

2012-03-25 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Remove unused fields from image tables .. core: Remove unused fields from image tables These fields are not used so removing them from DB and related plac

[Engine-patches] Change in ovirt-engine[master]: core: Change at rollback for MoveOrCopyImageGroup

2012-03-25 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Change at rollback for MoveOrCopyImageGroup .. core: Change at rollback for MoveOrCopyImageGroup For now, the rollback will be supported only for Add Vm

[Engine-patches] Change in ovirt-engine[master]: core: Fixing import vm when there is vm with snapshots

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fixing import vm when there is vm with snapshots .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3030 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core : Adding grouping of storages at additional queries

2012-03-25 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Adding grouping of storages at additional queries .. core : Adding grouping of storages at additional queries The following patch is adding additional g

[Engine-patches] Change in ovirt-engine[master]: core: fixing a bug when importing 3.0 VM or template that ha...

2012-03-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fixing a bug when importing 3.0 VM or template that has interfaces .. Patch Set 1: (1 inline comment) #2 : Apply Kublin suggestions Fix incorrect isPlugged

[Engine-patches] Change in ovirt-engine[master]: core: rename DB Script

2012-03-25 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: rename DB Script .. core: rename DB Script Fix collision of upgrade script names. Change-Id: Iee54172afb2085df76b14125c4ce48296eec0505 --- R bac

[Engine-patches] Change in ovirt-engine[master]: core: rename DB Script

2012-03-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: rename DB Script .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3062 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: rename DB Script

2012-03-25 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: core: rename DB Script .. core: rename DB Script Fix collision of upgrade script names. Change-Id: Iee54172afb2085df76b14125c4ce48296eec0505 --- R backend/manage

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for grant mode attribute in permission

2012-03-25 Thread oliel
ol...@redhat.com has posted comments on this change. Change subject: restapi: Add support for grant mode attribute in permission .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for grant mode attribute in permission

2012-03-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Add support for grant mode attribute in permission .. Patch Set 3: Verified rebase only. -- To view, visit http://gerrit.ovirt.org/3004 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: Add grant_mode attribute to permissions entity

2012-03-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Add grant_mode attribute to permissions entity .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2978 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Add grant_mode attribute to permissions entity

2012-03-25 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Add grant_mode attribute to permissions entity .. core: Add grant_mode attribute to permissions entity The patch adds an attribute named grant_mode

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 630 - Fixed!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine - Build # 630 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/630/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: webadmin: Remember user's choise - override IP tables flag (...

2012-03-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Remember user's choise - override IP tables flag (host dialog) .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 629 - Still Failing!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine - Build # 629 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/629/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 628 - Failure!

2012-03-25 Thread Jenkins oVirt Server
ovirt_engine - Build # 628 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/628/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of AttachDiskToVmCommand

2012-03-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Introducing of AttachDiskToVmCommand .. core : Introducing of AttachDiskToVmCommand The following patch is introducing of AttachDiskToVmCommand

[Engine-patches] Change in ovirt-engine[master]: core : Refactoring of disks related commands

2012-03-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Refactoring of disks related commands .. core : Refactoring of disks related commands The following patch is a preperation for Attach/Dettach sc

[Engine-patches] Change in ovirt-engine[master]: core : Refactoring of disks related commands

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Refactoring of disks related commands .. Patch Set 5: Verified; Looks good to me, approved rebase -- To view, visit http://gerrit.ovirt.org/2731 To unsu

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of AttachDiskToVmCommand

2012-03-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Introducing of AttachDiskToVmCommand .. Patch Set 5: Verified; Looks good to me, approved rebase -- To view, visit http://gerrit.ovirt.org/2732 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Fix stored proc for get all snapshots

2012-03-25 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix stored proc for get all snapshots .. core: Fix stored proc for get all snapshots The stored procedure was written incorrectly, which causes i

[Engine-patches] Change in ovirt-engine[master]: core: Fix stored proc for get all snapshots

2012-03-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix stored proc for get all snapshots .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3061 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Fix stored proc for get all snapshots

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix stored proc for get all snapshots .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3061 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Fix stored proc for get all snapshots

2012-03-25 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Fix stored proc for get all snapshots .. core: Fix stored proc for get all snapshots The stored procedure was written incorrectly, which causes it to fail

[Engine-patches] Change in ovirt-engine[master]: core: Extract DAO call to single method

2012-03-25 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Extract DAO call to single method .. core: Extract DAO call to single method In ImportVmCommand there are several places where SnapshotDao is need

[Engine-patches] Change in ovirt-engine[master]: core: Extract DAO call to single method

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Extract DAO call to single method .. Patch Set 3: Verified; Looks good to me, approved Just rebase, ack (+2) by yzaslavs -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Add support for import/export of VM snapshots

2012-03-25 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add support for import/export of VM snapshots .. core: Add support for import/export of VM snapshots Added exporting and importing VM snapshots, w

[Engine-patches] Change in ovirt-engine[master]: core: Add support for import/export of VM snapshots

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Add support for import/export of VM snapshots .. Patch Set 3: Verified; Looks good to me, approved Just rebase, ack (+2) by yzaslavs -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Added get all with config to SnapshotDao

2012-03-25 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added get all with config to SnapshotDao .. core: Added get all with config to SnapshotDao This method is needed to get all VM snapshots with thei

[Engine-patches] Change in ovirt-engine[master]: core: Added get all with config to SnapshotDao

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Added get all with config to SnapshotDao .. Patch Set 3: Verified; Looks good to me, approved Just rebase, ack (+2) by ofrenkel & yzaslavs -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: core: Added get all with config to SnapshotDao

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Added get all with config to SnapshotDao .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3035 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-25 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. engine: DB scripts, entities and DAO for Gluster Volumes - Tables for the Gluster Volume ent

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2936 To u

[Engine-patches] Change in ovirt-engine[master]: core: Added get all with config to SnapshotDao

2012-03-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Added get all with config to SnapshotDao .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3035 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Added get all with config to SnapshotDao

2012-03-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Added get all with config to SnapshotDao .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3035 To

[Engine-patches] Change in ovirt-engine[master]: core: Fix ImportVmCommand for snapshot images

2012-03-25 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix ImportVmCommand for snapshot images .. core: Fix ImportVmCommand for snapshot images Snapshot images should be imported always as active = fal

[Engine-patches] Change in ovirt-engine[master]: core: Fix ImportVmCommand for snapshot images

2012-03-25 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix ImportVmCommand for snapshot images .. Patch Set 2: Verified; Looks good to me, approved Just rebased, ack (+2) by yzaslavs -- To view, visit http://g

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #95

2012-03-25 Thread Jenkins oVirt Server
See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: searchbackend: Change disk search to use new view

2012-03-25 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: searchbackend: Change disk search to use new view .. searchbackend: Change disk search to use new view 1. Introduce a new view to fetch disks from, since storage

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 9: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2936 To un

[Engine-patches] Change in ovirt-engine[master]: core: Add grant_mode attribute to permissions entity

2012-03-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add grant_mode attribute to permissions entity .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2978 To unsubscribe, vis

  1   2   >