[Engine-patches] Change in ovirt-engine[master]: backend: Remove activeImage from Disk for now

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Remove activeImage from Disk for now .. backend: Remove activeImage from Disk for now This field needs to be addressed when snapshots flows wil

[Engine-patches] Change in ovirt-engine[master]: backend: Remove activeImage from Disk for now

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Remove activeImage from Disk for now .. Patch Set 3: Verified; Looks good to me, approved Acked by ofren...@redhat.com -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: backend: Change update of Disk to code

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Change update of Disk to code .. backend: Change update of Disk to code Change so that update of Disk entity is done from the correct places in

[Engine-patches] Change in ovirt-engine[master]: backend: Change update of Disk to code

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Change update of Disk to code .. Patch Set 3: Verified; Looks good to me, approved Acked by ofren...@redhat.com -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: backend: Change removal of Disk to code

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Change removal of Disk to code .. backend: Change removal of Disk to code Change so that removal of Disk entity is done from the correct places

[Engine-patches] Change in ovirt-engine[master]: backend: Change removal of Disk to code

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Change removal of Disk to code .. Patch Set 6: Verified; Looks good to me, approved Acked by ofren...@redhat.com -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: backend: Added saving the disk to flows

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Added saving the disk to flows .. Patch Set 6: Verified; Looks good to me, approved Acked by ofren...@redhat.com -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: backend: Added saving the disk to flows

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Added saving the disk to flows .. backend: Added saving the disk to flows As part of separating Disk from DiskImage, added saving the disk to t

[Engine-patches] Change in ovirt-engine[master]: backend: Change DiskImage to contain Disk

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Change DiskImage to contain Disk .. backend: Change DiskImage to contain Disk DiskImage represents a Disk + Image view, so changing it to conta

[Engine-patches] Change in ovirt-engine[master]: backend: Change DiskImage to contain Disk

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Change DiskImage to contain Disk .. Patch Set 3: Verified; Looks good to me, approved Acked by ofren...@redhat.com -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: backend: Remove status from Disk

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: backend: Remove status from Disk .. backend: Remove status from Disk It has been decided that status should be per image of Disk, and not per entire Dis

[Engine-patches] Change in ovirt-engine[master]: backend: Remove status from Disk

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: backend: Remove status from Disk .. Patch Set 3: Verified; Looks good to me, approved Acked by emes...@redhat.com -- To view, visit http://gerrit.ovirt.org/872

[Engine-patches] Change in ovirt-engine[master]: engine : Code clean up

2012-01-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine : Code clean up .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1138 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: engine : Code clean up

2012-01-21 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: engine : Code clean up .. engine : Code clean up The following commit is performing a simple code clean up inside CommandsFactory Change-Id: I026764ba88e

[Engine-patches] Change in ovirt-engine[master]: core: Remove vm_template & vm_template_image_map

2012-01-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Remove vm_template & vm_template_image_map .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/1172 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Remove vm_template & vm_template_image_map

2012-01-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove vm_template & vm_template_image_map .. core: Remove vm_template & vm_template_image_map These tables are not used anymore, since they have

[Engine-patches] Change in ovirt-engine[master]: core: Variable renaming for CreateVdsComamnd

2012-01-21 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Variable renaming for CreateVdsComamnd .. core: Variable renaming for CreateVdsComamnd mVm => vm mCreateInfo => createInfo Change-Id: I35e0c76ae4712d8cb85b6

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand .. Patch Set 1: (1 inline comment) File backend/manager/modules/vdsbrok

[Engine-patches] Change in ovirt-engine[master]: core : adding common utilities for VmDevice - VmDeviceCommon...

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils .. Patch Set 1: (1 inline comment) File bac

[Engine-patches] Change in ovirt-engine[master]: core: porting old boot order values to new vm_device

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: porting old boot order values to new vm_device .. Patch Set 1: (2 inline comments) File backend/manager/d

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOTest

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding VmDeviceDAOTest .. Patch Set 1: (2 inline comments) File backend/manager/modules/dal/src/main/jav

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDEviceDAO to engine-daos.properties

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding VmDEviceDAO to engine-daos.properties .. Patch Set 1: (1 inline comment) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOHibernateImpl

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding VmDeviceDAOHibernateImpl .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal/src/

[Engine-patches] Change in ovirt-engine[master]: core: Add VmDeviceDAODbFacadeImpl

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Add VmDeviceDAODbFacadeImpl .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal/src/main

[Engine-patches] Change in ovirt-engine[master]: core: Adding VM Device BE

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding VM Device BE .. Patch Set 1: (1 inline comment) File backend/manager/modules/common/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Adding VM Device BE

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding VM Device BE .. Patch Set 1: (1 inline comment) File backend/manager/modules/common/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Adding hash column to Views/SPs and DAL

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Adding hash column to Views/SPs and DAL .. Patch Set 1: (4 inline comments) File backend/manager/dbscript

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand .. Patch Set 1: (4 inline comments) File backend/manager/modules/vdsbro

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: support extracting superclass from list of decorators

2012-01-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: support extracting superclass from list of decorators .. sdk: support extracting superclass from list of decorators Change-Id: If8d310dac8c0e20

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: support extracting superclass from list of decorators

2012-01-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: support extracting superclass from list of decorators .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/118

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: support extracting superclass from list of decorators

2012-01-21 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: support extracting superclass from list of decorators .. sdk: support extracting superclass from list of decorators Change-Id: If8d310dac8c0e208fc87262

[Engine-patches] Change in ovirt-engine[master]: gwt: Removed sharedgwt-deployment module

2012-01-21 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: gwt: Removed sharedgwt-deployment module .. Patch Set 4: Verified; Looks good to me, but someone else must approve ack on functionality (performed basic sanity on