Eli Mesika has posted comments on this change. Change subject: core: porting old boot order values to new vm_device ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_vm_device_upgrade_data.sql Line 5: Create or replace FUNCTION update_vm_video_cards_03_01_0140(v_vm_id UUID, v_old_num_of_monitors int, Done Line 78: CREATE OR REPLACE FUNCTION set_vm_devices_boot_order_03_01_0140(v_vm_id UUID) I have posted an email about that when you were abroad, the reason is that as DB grows , we will have more chance of collision between temp names and real one , in that case , you may replace first an existing non-temp function and drop it at the end. so, this suffix protects us from such cases that may ne hard to find. -- To view, visit http://gerrit.ovirt.org/1162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2711269844ad5e874bc9a75131fbf649f459c79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
