Michael Kublin has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
The number of thread which w
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (4 inline comments)
File
backend/manage
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Failure pop-up is shown after a false success
pop-up(#781822)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovi
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Scroll to target after login (#770639)
..
Patch Set 1: Verified; Looks good to me, approved
acked but need to rebase because of the code format
--
To
Barak Azulay has posted comments on this change.
Change subject: tools: New tool to upload OVF archives (#xx)
..
Patch Set 9:
Need to test it also with:
1 - VM with multiple disks and multiple snapshots per disk
2 - #1 but
Daniel Erez has posted comments on this change.
Change subject: webadmin: Clicking on Enable Power Management does nothing
(#771893)
..
Patch Set 2: Verified; Looks good to me, approved
Please rebase and format according to th
Moti Asayag has uploaded a new change for review.
Change subject: core: minor code cleanup of AsyncTaskCreationInfo
..
core: minor code cleanup of AsyncTaskCreationInfo
Removed C# comments and organized the class.
Change-Id: I9
Moti Asayag has uploaded a new change for review.
Change subject: core: Add StepId property to async_tasks entity
..
core: Add StepId property to async_tasks entity
The patch adds the step ID property to the async_tasks entity a
Moti Asayag has uploaded a new change for review.
Change subject: core: Task Manager Support monitoring of VDSM tasks
..
core: Task Manager Support monitoring of VDSM tasks
The patch adds supports for monitoring VDSM tasks as st
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Jobs handling on server startup
..
core: Add Jobs handling on server startup
The patch handles uncompleted Jobs on server startup.
Jobs with Steps repre
Moti Asayag has uploaded a new change for review.
Change subject: core: Add JobRepositoryFactory to init JobRepository
..
core: Add JobRepositoryFactory to init JobRepository
Adds a factory to initialize the JobRepository and to
Moti Asayag has uploaded a new change for review.
Change subject: core: Task Manager Add Job Support to Multiple Action
..
core: Task Manager Add Job Support to Multiple Action
The patch adds support for the multiple action runn
Moti Asayag has uploaded a new change for review.
Change subject: core: Task Manager Define Actions as Non-Monitored
..
core: Task Manager Define Actions as Non-Monitored
The patch extends the VdcActionType with new property to
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Task Manager Default Command Monitoring
..
core: Add Task Manager Default Command Monitoring
The patch implements the default monitoring of the simple s
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Task Manager business entities
..
core: Add Task Manager business entities
The patch contains the business entities which describe a Job in the
system.
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Task Manager DAO objects
..
core: Add Task Manager DAO objects
The patch adds the DAO interfaces and implementation for the Job,
Step and JobSubjectEnti
Moti Asayag has uploaded a new change for review.
Change subject: core: Organize VdcActionParametersBase class
..
core: Organize VdcActionParametersBase class
organize the VdcActionParametersBase by order:
1. Data members
1.1. s
Moti Asayag has uploaded a new change for review.
Change subject: core: Clean-up of VdcReturnValueBase
..
core: Clean-up of VdcReturnValueBase
The patch cleans WSDL related annotations, removes full package qualifier
where is no
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Task Manager Tables
..
core: Add Task Manager Tables
The patch adds 3 tables for the Task Manager:
Job table - stores the job entity, describes an actio
Moti Asayag has uploaded a new change for review.
Change subject: core: Add Task Manager stored-procedures
..
core: Add Task Manager stored-procedures
The patch adds stored-procedures for the Task Manager feature.
The stored pro
Moti Asayag has uploaded a new change for review.
Change subject: core: Clear C# annotations from VdcActionParametersBase
..
core: Clear C# annotations from VdcActionParametersBase
The patch removes annotations used for producin
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Search bar auto resize (#750293)
..
Patch Set 1: Verified; Looks good to me, approved
acked, but you need to rebase according to the new format :)
--
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: import VM wrong message
..
webadmin: import VM wrong message
a wrong tooltip is shown when provisioning (thin/preallocated) dropdown
is disabled.
Cha
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: configure dialog search
..
webadmin: configure dialog search
activate the search of roles and system permissions only when
the dialog is shown.
Chang
Omer Frenkel has posted comments on this change.
Change subject: ovirt-engine: Add Quota DB tables
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/upgrade/
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: raise minor version 1.1
..
cli: raise minor version 1.1
Change-Id: Ia32b210bc3922861bfc75702a80d1804bdf1380e
---
M Makefile
M ovirt-engine-cli.
Michael Pasternak has posted comments on this change.
Change subject: cli: raise minor version 1.1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1075
To unsubscribe, visit http:/
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: raise minor version 1.1
..
sdk: raise minor version 1.1
Change-Id: If941066a8bdd4eee721c13d2c0b34eeaeeef797e
---
M Makefile
M ovirt-engine-sdk.
Michael Pasternak has posted comments on this change.
Change subject: sdk: raise minor version 1.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1076
To unsubscribe, visit http:/
Ofer Schreiber has posted comments on this change.
Change subject: cli: raise minor version 1.1
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1075
To unsubsc
Ofer Schreiber has posted comments on this change.
Change subject: sdk: raise minor version 1.1
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1076
To unsubsc
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: raise minor version 1.1
..
sdk: raise minor version 1.1
Change-Id: If941066a8bdd4eee721c13d2c0b34eeaeeef797e
---
M Makefile
M ovirt-engine-sdk.spec.in
Michael Pasternak has uploaded a new change for review.
Change subject: cli: raise minor version
..
cli: raise minor version
Change-Id: Ia32b210bc3922861bfc75702a80d1804bdf1380e
---
M Makefile
M ovirt-engine-cli.spec.in
2 files
Jonathan Choate has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (4 inline comments)
File
backend/manag
Doron Fediuck has posted comments on this change.
Change subject: core: Fix network name on default cluster
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1074
To unsubscribe, vis
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix network name on default cluster
..
core: Fix network name on default cluster
This patch renames the network name of default cluster from engin
Ofer Schreiber has uploaded a new change for review.
Change subject: core: Fix network name on default cluster
..
core: Fix network name on default cluster
This patch renames the network name of default cluster from engine to
ov
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: unable to create data-center: problem with --version param
#781834
..
cli: unable to create data-center: problem with --version param #781834
Michael Pasternak has posted comments on this change.
Change subject: cli: unable to create data-center: problem with --version param
#781834
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Michael Pasternak has uploaded a new change for review.
Change subject: cli: unable to create data-center: problem with --version param
#781834
..
cli: unable to create data-center: problem with --version param #781834
https://
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix network name on default cluster
..
core: Fix network name on default cluster
This patch renames the network name of default cluster from engin
Doron Fediuck has posted comments on this change.
Change subject: core: Fix network name on default cluster
..
Patch Set 1: Verified
Verification details:
./create_db_devel.sh
Running original create_db script...
Creating the
Omer Frenkel has posted comments on this change.
Change subject: core: Fix network name on default cluster
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1072
To unsubscribe, visit http://g
Doron Fediuck has uploaded a new change for review.
Change subject: core: Fix network name on default cluster
..
core: Fix network name on default cluster
This patch renames the network name of default cluster from engine to
ovi
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Rename nic interfaces in capabilities (#748289)
..
restapi: Rename nic interfaces in capabilities (#748289)
https://bugzilla.redhat.com/748
Michael Pasternak has posted comments on this change.
Change subject: restapi: Rename nic interfaces in capabilities (#748289)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/865
T
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Enable Detach Of Local Storage (#770553)
..
restapi: Enable Detach Of Local Storage (#770553)
Detach of local-storage means removing it. So
Michael Pasternak has posted comments on this change.
Change subject: restapi: Enable Detach Of Local Storage (#770553)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/812
To unsub
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi FCP Luns Not Displayed (#770870)
..
restapi FCP Luns Not Displayed (#770870)
https://bugzilla.redhat.com/770870
Change-Id: Idabdc2acb9e1ed1
Michael Pasternak has posted comments on this change.
Change subject: restapi FCP Luns Not Displayed (#770870)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/988
To unsubscribe, v
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: authentication so called succeeded with bad password
#781820
..
cli: authentication so called succeeded with bad password #781820
https://bugz
Michael Pasternak has posted comments on this change.
Change subject: cli: authentication so called succeeded with bad password
#781820
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Michael Pasternak has uploaded a new change for review.
Change subject: cli: authentication so called succeeded with bad password
#781820
..
cli: authentication so called succeeded with bad password #781820
https://bugzilla.red
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: add connectivity check and disconnect methods for #781820
..
sdk: add connectivity check and disconnect methods for #781820
Change-Id: Ibf43562
Michael Pasternak has posted comments on this change.
Change subject: sdk: add connectivity check and disconnect methods for #781820
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: add connectivity check and disconnect methods for #781820
..
sdk: add connectivity check and disconnect methods for #781820
Change-Id: Ibf43562d8d6af10
Jonathan Choate has submitted this change and it was merged.
Change subject: engine-core: removing * import on MoveVmParameters
..
engine-core: removing * import on MoveVmParameters
The title says it all.
Change-Id: I76f691131
Jonathan Choate has posted comments on this change.
Change subject: engine-core: removing * import on MoveVmParameters
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1036
To unsub
Jonathan Choate has posted comments on this change.
Change subject: engine-core: removing redundancy in ImportExportCommon
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1035
To u
Jonathan Choate has submitted this change and it was merged.
Change subject: engine-core: removing redundancy in ImportExportCommon
..
engine-core: removing redundancy in ImportExportCommon
Removing initializtion of booleans th
Jonathan Choate has uploaded a new change for review.
Change subject: engine-core: Multiple storage domains when importing VM
..
engine-core: Multiple storage domains when importing VM
Fixing ImportVmCommand and ImportVmTemplate
Jonathan Choate has uploaded a new change for review.
Change subject: engine-core: create a VM from a template
..
engine-core: create a VM from a template
Made a change to AddVmFromTemplateCommand to ensure that
VM disks go the
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Failure pop-up is shown after a false success
pop-up(#781822)
..
webadmin: Failure pop-up is shown after a false success pop-up(#781822)
https://bugz
Itamar Heim has posted comments on this change.
Change subject: engine : Hotplug feature - error messages
..
Patch Set 2: (3 inline comments)
see comments in line.
also - why are we fixing all these files and committing them ra
Danny Rankevich has posted comments on this change.
Change subject: webadmin- tag in single line error
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1026
To unsubscribe, visit h
Itamar Heim has posted comments on this change.
Change subject: engine : Hotplug feature - db scripts
..
Patch Set 2: (3 inline comments)
File backend/manager/dbscripts/image
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug feature - error messages
..
Patch Set 2: (1 inline comment)
Waiting for other comments, after that will send a new version
...
Eli Mesika has posted comments on this change.
Change subject: engine-core: Fix Unit Test in VdsDaoTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1063
To unsubscribe, visit h
Eli Mesika has submitted this change and it was merged.
Change subject: engine-core: Fix Unit Test in VdsDaoTest
..
engine-core: Fix Unit Test in VdsDaoTest
This patch changes the storage_pool_id sent in the
unit test that test
Muli Salem has uploaded a new change for review.
Change subject: engine-core: Fix Unit Test in VdsDaoTest
..
engine-core: Fix Unit Test in VdsDaoTest
This patch changes the storage_pool_id sent in the
unit test that tests the Ge
Roy Golan has uploaded a new change for review.
Change subject: engine-core: setupNetworks api change
..
engine-core: setupNetworks api change
Introducing the new api of setupNetworks.
The new form to attach/detach multiple netw
Roy Golan has uploaded a new change for review.
Change subject: engine-core: add validations on VdsNetworkInterface
..
engine-core: add validations on VdsNetworkInterface
move validations which doesn't depends on the model from
Roy Golan has uploaded a new change for review.
Change subject: engine-core: clean and fix typos
..
engine-core: clean and fix typos
Change-Id: I5d516b6b0cdba3232982be0253ad56de4e062c3e
---
M
backend/manager/modules/bll/src/mai
Michael Kublin has posted comments on this change.
Change subject: engine-core: cancel search task on exception
..
Patch Set 2:
Now, the patch is irrelevant , should be rewritten with new API and based on
results of tests in d
Moti Asayag has posted comments on this change.
Change subject: tools: Adjust notification services path
..
Patch Set 3: Verified; Looks good to me, approved
Acked by Doron Fedicuk.
--
To view, visit http://gerrit.ovirt.org/96
Moti Asayag has submitted this change and it was merged.
Change subject: tools: Adjust notification services path
..
tools: Adjust notification services path
The patch aligns the paths created by ovirt fedora spec file for the
Doron Fediuck has posted comments on this change.
Change subject: engine-core: fix context and registration servlet name
..
Patch Set 2:
WRT Dan's comment;
1. Please verify this can work with older ovirt nodes.
2. Please veri
Doron Fediuck has posted comments on this change.
Change subject: remove scripts dependencies on specific jar versions
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/837
To unsubs
Doron Fediuck has submitted this change and it was merged.
Change subject: engine-core: cancel search task on exception
..
engine-core: cancel search task on exception
Cancel with an interrupt a search task on exception.
This s
Doron Fediuck has posted comments on this change.
Change subject: engine-core: cancel search task on exception
..
Patch Set 2: Verified; Looks good to me, approved
Rebased patch, Acked by Kublin.
--
To view, visit http://gerri
Doron Fediuck has submitted this change and it was merged.
Change subject: 3rdparty: fix pukey2ssh.sh compile command
..
3rdparty: fix pukey2ssh.sh compile command
use gcc instead of specific alias g++
Change-Id: I64a0d9ffab5b
Doron Fediuck has posted comments on this change.
Change subject: 3rdparty: fix pukey2ssh.sh compile command
..
Patch Set 2: Verified; Looks good to me, approved
Rebased patch.
--
To view, visit http://gerrit.ovirt.org/319
To
Doron Fediuck has posted comments on this change.
Change subject: tools: Adjust notification services path
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/964
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: engine-core:REST API does not validate required parameters for
power managment
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
84 matches
Mail list logo
