Michael Kublin has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
The number of thread which will be open by that command is around 7-8, if the
comand will be run via rest api script for 100 vdsms, we will have 700-800 open
threads , our default thread pool is 500. I think we should make better solution
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
Line 172: ThreadPoolUtil.execute(setupNetworksTask);
This line of code will open two threads , one inside of other
Line 187: } finally {
will not do anything a thread will left.
Line 199: */
Also couple of threads
Line 258: ThreadUtils.sleep(2000);// delay the calls a bit to not DoS
attack VDSM
This is also bad, firts of all should be call to ThreadUtils, where we at leas
can count how many sleeps we have in the system
Line 260:
This is two threads
--
To view, visit http://gerrit.ovirt.org/880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I340df50a5889cb57b9919079d196f3d950e5272d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
