On Wed, 2019-10-30 at 16:49 -0700, Omar Sandoval wrote:
> On Wed, Oct 30, 2019 at 01:47:52PM +0100, Mark Wielaard wrote:
> > Also, if we would adopt dwfl_attach_thread then I think it should take
> > a Dwfl_Thread object not a pid/tid as argument.
>
> In that case, we'
On Wed, 2019-10-30 at 16:55 -0700, Omar Sandoval wrote:
> On Wed, Oct 30, 2019 at 02:04:42PM +0100, Mark Wielaard wrote:
> > Hi Omar,
> >
> > On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote:
> > > The next change will need to have the Dwarf_Frame readily a
On Wed, 2019-10-30 at 16:59 -0700, Omar Sandoval wrote:
> On Wed, Oct 30, 2019 at 02:23:06PM +0100, Mark Wielaard wrote:
> > Having some examples/testcases would also show how/where to get the
> > DWARF expressions to use with this new function.
>
> Sounds good, I'll pu
Hi Jonathon,
On Wed, Oct 30, 2019 at 09:29:02PM -0500, Jonathon Anderson wrote:
> fake_{loc,loclists,addr}_cu are Dwarf_CUs that are created separate from
> all the others, so their contents are minimal and mostly initialized by
> a calloc. On dwarf_end however, they are freed through the same cod
On Thu, Oct 31, 2019 at 06:42:18PM -0500, Jonathon Anderson wrote:
> fake_{loc,loclists,addr}_cu are Dwarf_CUs that are created separate from
> all the others, so their contents are minimal and mostly initialized by
> a calloc. On dwarf_end however, they are freed through the same code path
> as al
Hi Jonathon,
On Fri, 2019-11-01 at 08:14 -0500, Jonathon Anderson wrote:
> How about a bit of both, I'll be happy if I don't initialize
> `unit_type`.
> Does this work?
Looks perfect. Pushed to master.
Thanks,
Mark
I'll have to defer to Srdan on this one.
Srdan, any feedback on this?
Thanks,
Mark
From b70b350242d9752f41407c0ed7fe4683c8f31ce6 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sat, 26 Oct 2019 01:54:43 +0200
Subject: [PATCH] no compare or val pass
---
lib/dynamicsizehas
Hi,
On Mon, 2019-10-28 at 21:12 +0100, Mark Wielaard wrote:
> On Sun, 2019-10-27 at 17:13 +0100, Mark Wielaard wrote:
> > On Fri, 2019-10-25 at 23:11 -0500, Jonathon Anderson wrote:
> > > A quick grep -r shows that ITERATE and REVERSE are used for the
> > > asm_s
Hi,
On Mon, 2019-11-04 at 10:39 -0600, Jonathon Anderson wrote:
> Apologies, I talked with Srdan in person and forgot to relay the
> message. He gave me an updated version of the hash table that handles
> that issue (and another previously harmless typo).
This looks good. I am about to commit thi
Hi Jonathon,
On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote:
> +2019-08-25 Jonathon Anderson
> +
> + * configure.ac: Add new --enable-valgrind-annotations
> + * configure.ac: Add new --with-valgrind (headers only)
I think this looks fine. In theory we could also tr
Hi Jonathan,
On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote:
> Pthread's thread-local variables are highly limited, which makes
> it difficult to use many Dwarfs. This replaces that with a
> less efficient (or elegant) but more robust method.
Thanks, it looks good (similar
Hi,
On Thu, 2019-11-07 at 09:24 -0600, Jonathon Anderson wrote:
> On Thu, Nov 7, 2019 at 12:07, Mark Wielaard wrote:
> > Looking at the difference between the previous version and this one,
> > it
> > incorporates my simplification of FIND and lookup functions. And f
On Thu, 2019-11-07 at 12:40 -0600, Jonathon Anderson wrote:
> I haven't benchmarked this version, but I did benchmark the equivalent
> earlier version (this version is almost quite literally a rebase of the
> other). I don't have the exact results on hand, what I remember is that
> the pthread_k
Hi,
On Thu, 2019-11-07 at 12:13 -0600, Jonathon Anderson wrote:
> On Thu, Nov 7, 2019 at 18:20, Mark Wielaard wrote:
> > Do we really need this?
> > We already use __thread unconditionally in the rest of the code.
> > The usage of threads.h seems to imply we actually want
> collision), in that case the new Abbrev would stick around until the
> dwarf_end.
Since the memblocks are per thread, it seems we could easily back out
an allocation we don't need as long as the thread hasn't done any other
allocation from the memblock. What do you think of the
Hi,
On Mon, 2019-10-28 at 15:06 -0400, Frank Ch. Eigler wrote:
> From 3e1f8d93569004d06902459d84baceb636e139d5 Mon Sep 17 00:00:00 2001
> From: Aaron Merey
> Date: Mon, 28 Oct 2019 13:29:26 -0400
> Subject: [PATCH 1/2] debuginfod 1/2: client side
>
> Introduce the debuginfod/ subdirectory, conta
Hi,
On Mon, 2019-10-28 at 15:06 -0400, Frank Ch. Eigler wrote:
> Introduce the debuginfod/ subdirectory, containing the client for a
> new debuginfo-over-http service, in shared-library and command-line
> forms. Two functions in libdwfl make calls into the client library to
> fetch elf/dwarf file
Hi Jonathon,
On Mon, 2019-11-11 at 17:38 -0600, Jonathon Anderson wrote:
> > Since the memblocks are per thread, it seems we could easily back out
> > an allocation we don't need as long as the thread hasn't done any
> > other
> > allocation from the memblock. What do you think of the attached pa
Hi Frank,
On Tue, 2019-11-12 at 10:14 -0500, Frank Ch. Eigler wrote:
> > My only concern is that these might slow down configure when
> > debuginfod
> > isn't enabled? Can/Should they be moved later after the enable
> > test?
>
> It'd be fractions of a second per configure run ... worth worrying
+
> + * dwfl_build_id_find_elf.c (dwfl_build_id_find_elf): Call debuginfod
> + client functions via dlopen to look for elf/dwarf files as fallback.
> + * find-debuginfo.c (dwfl_standard_find_debuginfo): Ditto.
> +
> 2019-08-12 Mark Wielaard
>
> * gzip.
> +2019-10-28 Frank Ch. Eigler
> +
> + * eu.am (AM_CXXFLAGS): Clone & amend AM_CFLAGS for c++11 code.
> + * debuginfod.service, debuginfod.sysconfig: New files: systemd.
> + * Makefile.am: Install them.
> + * elfutils.spec.in: Add debuginfod and debug
On Mon, 2019-10-28 at 15:07 -0400, Frank Ch. Eigler wrote:
> Add the server to the debuginfod/ subdirectory. This is a highly
> multithreaded c++11 program (still buildable on rhel7's gcc 4.8,
> which is only partly c++11 compliant). Includes an initial suite
> of tests, man pages, and a sample s
Hi,
On Mon, 2019-10-28 at 15:07 -0400, Frank Ch. Eigler wrote:
> Add the server to the debuginfod/ subdirectory. This is a highly
> multithreaded c++11 program (still buildable on rhel7's gcc 4.8,
> which is only partly c++11 compliant). Includes an initial suite
> of tests, man pages, and a sam
On Thu, Nov 14, 2019 at 02:54:58PM +0100, Andreas Schwab wrote:
> Avoid spurious failure if errno is modified by any other library call in
> the test.
Looks correct. Pushed to master.
Thanks,
Mark
On Thu, Nov 14, 2019 at 04:50:26PM +0100, Andreas Schwab wrote:
> +2019-11-14 Andreas Schwab
> +
> + * run-large-elf-file.sh: Skip if available memory cannot be
> + determined.
Yes, good idea. When /usr/bin/free isn't installed we would otherwise
always run the test. Pushed to master.
On Thu, 2019-11-14 at 21:44 +0100, Mark Wielaard wrote:
> > + // validate buildid
> > + if ((buildid.size() < 2) || // not empty
> > + (buildid.size() % 2) || // even number
> > + (buildid.find_first_not_of("0123456789abcdef") !=
> >
* run-debuginfod-find.sh, debuginfod_build_id_find.c: New test.
> + * testfile-debuginfod-*.rpm.bz2: New data files for test.
> + * Makefile.am: Run it.
> +
> 2019-09-02 Mark Wielaard
>
> * run-readelf-s.sh: Add --dyn-syms case.
> diff --git a/tests/Makefile.am b
Hi,
On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote:
> At the wise counsel of gdb folks such as and :
>
> debuginfod 3/3: client interruptability
>
> For interactive clients such as gdb, interruptibility is important for
> usability during longer downloads. This patch
Hi Frank,
On Thu, 2019-11-07 at 04:07 -0500, Frank Ch. Eigler wrote:
> From: "Frank Ch. Eigler"
> Date: Wed, 6 Nov 2019 18:53:31 -0500
> Subject: [PATCH 1/2] debuginfod 4: symbolic link traversal mode
>
> In order to support file/rpm archives that are organized via symlink
> trees, add an "-L" o
Hi,
On Thu, 2019-11-07 at 04:08 -0500, Frank Ch. Eigler wrote:
> This webapi extensions allows admins to hook up debuginfod to a
> prometheus-compatible monitoring system for general situational
> statistics. The metrics are simple enough that local curl requests
> can give a user a sense of what
Hi Aaron,
On Fri, 2019-11-15 at 12:03 -0500, Aaron Merey wrote:
> On Fri, Nov 15, 2019 at 11:16 AM Mark Wielaard wrote:
> > On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote:
> > > At the wise counsel of gdb folks such as and :
> > >
> > > deb
On Tue, 2019-11-12 at 10:14 -0500, Frank Ch. Eigler wrote:
> > My only concern is that these might slow down configure when debuginfod
> > isn't enabled? Can/Should they be moved later after the enable test?
>
> It'd be fractions of a second per configure run ... worth worrying about?
Probably no
Hi,
On Wed, 2019-11-13 at 18:24 -0500, Frank Ch. Eigler wrote:
> Hurrah! Documentation! Thanks.
> >
> > But given that all other documentation is under doc/ could you move it
> > there (guarded by DEBUGINFOD). It is just more consistent. If you leave
> > it in this subdir I think you should also
On Thu, 2019-11-14 at 06:24 -0500, Frank Ch. Eigler wrote:
> > [...libdw* debuginfod_find_* calls]
> > But given that they are almost similar, I would suggest to move both
> > into their own file sharing most of the code to do the dlopen dance.
>
> Where? It can't be in the solib. We're talking
Hi Frank,
On Thu, 2019-11-14 at 06:54 -0500, Frank Ch. Eigler wrote:
> > > +++ b/config/debuginfod.sysconfig
> > > +#DEBUGINFOD_VERBOSE="-v"
> > > +DEBUGINFOD_PATHS="/usr/lib/debug /usr/bin /usr/sbin /usr/lib /usr/lib64
> > > /usr/local"
> >
> > Should this also include /usr/libexec ?
> > Isn't
Hi,
While testing Frank's new spec/rpms for the run-debuginfod-find.sh
testcase I found a couple of issues that I pushed to the debuginfod-
submit branch.
Add tests/debuginfod-rpms to EXTRA_DISTS.
Fix two small memory leaks in debuginfod-find and testcase.
Increase timeout for run-debuginfo
Hi,
On Sat, 2019-11-16 at 17:42 +0100, Mark Wielaard wrote:
> While testing Frank's new spec/rpms for the run-debuginfod-find.sh
> testcase I found a couple of issues that I pushed to the debuginfod-
> submit branch.
>
> Add tests/debuginfod-rpms to EXTRA_DISTS.
> Fix
Hi,
On Fri, 2019-11-15 at 18:14 +, Pedro Alves wrote:
> On 11/15/19 5:35 PM, Mark Wielaard wrote:
>
> > IMHO it would be best to avoid any global state from the start. Since
> > we haven't released this api yet we can make it so that it is easy to
> > have state
Hi,
On Thu, 2019-11-14 at 07:29 -0500, Frank Ch. Eigler wrote:
> > > -bin_PROGRAMS = debuginfod-find
> > > +bin_PROGRAMS = debuginfod debuginfod-find
> > > +debuginfod_SOURCES = debuginfod.cxx
> > > +debuginfod_cxx_CXXFLAGS = -Wno-unused-functions
> >
> > Should that be debuginfod_CXXFLAGS?
> > W
Hi Frank,
On Fri, 2019-11-15 at 16:00 -0500, Frank Ch. Eigler wrote:
> > > + string popen_cmd = string("/usr/bin/rpm2cpio " +
> > > shell_escape(b_source0));
> >
> > Why the hardcoded path?
> > Could you check at startup if rpm2cpio is in the PATH?
>
> Hm, since this is run under popen(), so it
Hi,
On Fri, 2019-11-15 at 14:54 -0500, Frank Ch. Eigler wrote:
> > > +set -x
> >
> > Is this really necessary?
> > It makes the log files very verbose.
> > Or is that the intention?
>
> I've found it tricky to debug failing tests without this.
OK, but note that you can place echo "starting phas
Hi,
On Fri, 2019-11-15 at 12:57 -0500, Frank Ch. Eigler wrote:
> Could you also add a reference to the Prometheus Exposition format. I
> > see it is already in a comment in the code. Best to also add it as See
> > also in the docs.
>
> OK.
Thanks, that would be good.
> > > +control. The \fI/me
Hi,
On Fri, 2019-11-15 at 13:31 -0500, Frank Ch. Eigler wrote:
> > > In order to support file/rpm archives that are organized via symlink
> > > trees, add an "-L" option to debuginfod, meaning about the same as for
> > > find(1) or ls(1): to traverse rather than ignore symlinks.
> >
> > Could you
Hi,
On Sat, 2019-11-16 at 13:52 -0500, Frank Ch. Eigler wrote:
> Yeah, maybe a different automake version made it work after my earlier
> failing tests. (dead horse PS. It remains my opinion that we should
> commit auto* generated files into git.)
>
> > > Possible, but since these bits are just
w/elfutils/log/?h=debuginfod-client-context
If you think those patches are ok I can squash them and add them to the
debuginfod-submit branch.
Cheers,
Mark
From 8006db933298ecca35a04207aad3991b242c21da Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Tue, 19 Nov 2019 13:09:24 +0100
Subject: [P
Hi,
On Mon, 2019-11-18 at 13:41 -0500, Frank Ch. Eigler wrote:
> > > I see where you're going with it, it's a reasonable concern. For now,
> > > we can consider it covered by the "debuginfod should be given
> > > trustworthy binaries" general rule.
> >
> > This does keep me slightly worried. Eve
Hi,
On Mon, 2019-11-18 at 15:33 -0500, Frank Ch. Eigler wrote:
> > > > Do you know how other libraries that use libcurl deal with this?
> > >
> > > I looked over some other libcurl users in fedora. Some don't worry
> > > about the issue at all, relying on implicit initialization, which is
> > >
Hi,
On Mon, 2019-11-18 at 11:47 -0500, Frank Ch. Eigler wrote:
> > > > > +control. The \fI/metrics\fP webapi endpoint is probably not
> > > > > +appropriate for disclosure to the public.
> > > >
> > > > So, should there be an option to turn it off?
> > >
> > > IMHO not necessary. The security
Hi Frank,
On Tue, Nov 19, 2019 at 11:13:48AM -0500, Frank Ch. Eigler wrote:
> > > > This does keep me slightly worried. Even "trustworthy binaries" could
> > > > be produced by buggy compilers.
> > >
> > > Those would be untrustworthy binaries.
> > But then every binary could be untrustworthy :)
Hi Frank,
On Tue, Nov 19, 2019 at 11:20:34AM -0500, Frank Ch. Eigler wrote:
> > > Doing a redundant initialization later is not a problem; there is a
> > > counter in there. The problematic case would be
> > > - a multithreaded application
> > > - loading debuginfod.so multiply concurrently someh
On Tue, 2019-11-19 at 16:15 -0500, Frank Ch. Eigler wrote:
> Hi -
>
>
> > [...] What I want is simply make it easy for the user to say where
> > they expect the sources are. So there is no surprises.
>
> If this were a mandate, it would be a hassle, for any build that's
> more than one directory
Hi,
On Tue, 2019-11-19 at 16:22 -0500, Frank Ch. Eigler wrote:
> On Tue, Nov 19, 2019 at 09:15:20PM +0100, Mark Wielaard wrote:
> > > That's what the doc says. What the code does, as far back as the year
> > > 2001, is have a static flag/counter in curl_global_init() th
On Wed, 2019-11-20 at 08:29 -0500, Frank Ch. Eigler wrote:
> Hi -
>
> > But it isn't just about interference with other libcurl activity.
> > If
> > you look at the curl_global_init code you see that it actually
> > calls
> > a lot of code in other libraries. It is the curl_global_init code
> > th
Hi,
On Wed, 2019-11-20 at 12:53 +0100, Mark Wielaard wrote:
> Sure, you could use that if you wanted to share your whole build/source
> trees and don't mind serving any other files on some local network. I
> just think it shouldn't be the default. If you go look for odd path
On Thu, 2019-11-21 at 15:16 +0100, Mark Wielaard wrote:
> Hi,
>
> On Wed, 2019-11-20 at 12:53 +0100, Mark Wielaard wrote:
> > Sure, you could use that if you wanted to share your whole
> > build/source
> > trees and don't mind serving any other files on some local
Hi Frank,
On Thu, 2019-11-21 at 10:57 -0500, Frank Ch. Eigler wrote:
> > It simply splits the paths into those scanned for rpms, those scanned
> > for files and (optional) paths that are extra trusted prefixes for
> > source files. The paths that are scanned for files are trusted source
> > prefix
Hi Frank,
On Thu, 2019-11-21 at 12:18 -0500, Frank Ch. Eigler wrote:
> If the perceived problem is that build tree scans (-F) may
> > > contain
> > > binaries that refer to source files that are not appropriate for
> > > later sharing, then IMO this is too much change, and unnecessarily
> > > comp
Hi,
On Thu, 2019-11-21 at 21:41 +0100, Mark Wielaard wrote:
> I think what makes the discussion somewhat difficult is that there are
> basically three cases:
>
> - Serving trees of rpms where only the contents of the rpms is shared.
> - Serving of a build directory where it makes
utes.
I have committed the patch below and will monitor whether all buildbot
workers will now succeed.
Cheers,
Mark
From 1e651ad457f445ff933b4fdd7e2c82bd1fc0f2cd Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sat, 23 Nov 2019 14:09:42 +0100
Subject: [PATCH] tests: Use 127.0.0.1 in run-debugin
Hi,
The following two patches add some metrics to debuginfod that can be
used ito see whether the scanners are still finding new executables,
debuginfo files or find new sources. They can also be used in the
run-debuginfod-find.sh testcase to see whether the server is ready
or not for the next tes
Keeps metrics of how many executables, debuginfo and sourcerefs were
found in total for file and rpm scanners.
Signed-off-by: Mark Wielaard
---
debuginfod/ChangeLog | 8
debuginfod/debuginfod.cxx | 24
2 files changed, 32 insertions(+)
diff --git a
Wait for the debuginfod server to finish and use the metrics to see
when a server is ready for the next test instead of sleeping. Also
remove DEBUGINFOD_TEST_WEBAPI_SLEEP.
Signed-off-by: Mark Wielaard
---
debuginfod/ChangeLog | 6 +++
debuginfod/debuginfod.cxx| 8 ---
tests
Hi,
On Sun, Nov 24, 2019 at 08:58:13PM +0100, Mark Wielaard wrote:
> The following two patches add some metrics to debuginfod that can be
> used ito see whether the scanners are still finding new executables,
> debuginfo files or find new sources. They can also be used in the
> ru
As the buildbot just pointed out...
The run-debuginfod-find.sh now relies on curl to fetch the metrics.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 4
config/elfutils.spec.in | 1 +
2 files changed, 5 insertions(+)
diff --git a/config/ChangeLog b/config/ChangeLog
index
Signed-off-by: Mark Wielaard
---
update-coverage.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/update-coverage.sh b/update-coverage.sh
index bff5461d..46f30ab2 100755
--- a/update-coverage.sh
+++ b/update-coverage.sh
@@ -30,7 +30,8 @@ ${tempdir}/elfutils/configure
libdw now always needs -lpthread and -ld even when BUILD_STATIC.
BUILD_STATIC is only used when doing a gcov enabled build.
Enable gcov coverage also for debuginfod.
Signed-off-by: Mark Wielaard
---
ChangeLog | 4
configure.ac | 1 +
debuginfod/ChangeLog | 5
Set version to 0.178.
Update NEWS and elfutils.spec.in.
Regenerate po/*.po files.
Signed-off-by: Mark Wielaard
---
ChangeLog | 5 +
NEWS| 22 +
config/elfutils.spec.in | 15 +
configure.ac| 2 +-
po/ChangeLog| 4 +
po/de.po
, add post/postun ldconfig for elfutils-libs and
elfutils debuginfod-client subpackages, remove default
defattr(-,root,root) for file lists and order binaries by name.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 9 +++
config/elfutils.spec.in | 145
be thread-safe.
libdw: Don't free uninitialized Dwarf_Abbrev_Hash's of "fake" CUs.
Add configure options for Valgrind annotations.
libdw: Rewrite the memory handler to be more robust.
Mark Wielaard (24):
readelf: Add optional "SECTION" argument for --no
The versioned library (links) should be in the runtime package.
The debuginfod-client-devel package should just contain the .so
(symlink). This isn't fatal, just sloppy. ldconfig will correct
the missing symlinks when it was missing.
Signed-off-by: Mark Wielaard
---
config/ChangeLog
elfutils-debuginfod depends indirectly already on the client library.
Make that explicit so they are always updated in sync. Which isn't
technically required, but makes things clearer and simpler on updates.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 5 +
c
> Buildbot URL: https://builder.wildebeest.org/buildbot/
>
> Worker for this Build: debian-i386
>
> Build Reason:
> Blamelist: Mark Wielaard
>
> BUILD FAILED: failed test (failure)
Note that this was a build failure some (8) days ago. The ppc64 builder
was offline and
,
|^
libcurl has different error code enums. The "easy" interfaces return
a CURLcode error. The "multi" interface functions return a CURLMcode.
Signed-off-by: Mark Wielaard
---
debuginfod/ChangeLog | 5 +
debuginfod/debuginfod-client.c | 9 -
1,root,root) /usr/local/bin/hello
%files two
%defattr(-,root,root)
%attr(0751,root,root) /usr/local/bin/hello2
%changelog
* Thu Nov 14 2019 Frank Ch. Eigler
- Added source code right here to make spec file self-contained.
- Dropped misc files not relevant to debuginfod testing.
* Wed May 18 201
Otherwise elfcompress might run against the system libelf which might
be too old or missing.
Signed-off-by: Mark Wielaard
---
tests/ChangeLog | 4
tests/run-elfclassify.sh | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
didn't up to now. Support for
compressed ELF files was added in 2009 and the code was updated to
to try to find the .gz, .bz2 or .xz extension variants in 2011.
But not the vmlinuz named variant.
Reported-by: Aaron Merey
Tested-by: Frank Ch. Eigler
Signed-off-by: Mark Wielaard
---
li
on to match the current Fedora
text.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 5 +
config/elfutils.spec.in | 19 ++-
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/config/ChangeLog b/config/ChangeLog
index d71fb39..4e28970 100644
--- a/c
For some reason gcc might fail to recognize the assert (0) will never
return and emit an implicit-fallthrough warning. Just add a break to
silence it.
Signed-off-by: Mark Wielaard
---
tests/ChangeLog| 4
tests/backtrace-data.c | 1 +
2 files changed, 5 insertions(+)
diff --git a
Otherwise strip might run against the system libelf which might be too
old or missing.
Signed-off-by: Mark Wielaard
---
tests/ChangeLog | 4
tests/run-debuginfod-find.sh | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
We really need build-ids for various things. If the system compiler
doesn't generate build-ids warn and generate them anyway for both the
binaries and the tests.
Signed-off-by: Mark Wielaard
---
ChangeLog| 4
configure.ac | 9 +
tests/Chan
On Fri, 2019-12-06 at 17:21 +0100, Florian Weimer wrote:
> * Mark Wielaard:
>
> > For some reason gcc might fail to recognize the assert (0) will never
> > return and emit an implicit-fallthrough warning. Just add a break to
> > silence it.
>
> Is this with -D
02 Frank Ch. Eigler
> +
> + * debuginfod.cxx (*_rpm_*): Rename to *_archive_* throughout.
> + (scan_archives): New read-mostly global to identify archive
> + file extensions and corresponding extractor commands.
> + (parse_opt): Handle new -U flag.
> +
>
the library is used in a confined
setup.
Signed-off-by: Mark Wielaard
---
debuginfod/ChangeLog | 5 +
debuginfod/debuginfod-client.c | 20 +++-
2 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 10b6bfed..
On Thu, 2019-12-05 at 15:21 +0100, Mark Wielaard wrote:
> Both the dwfl_linux_kernel_find_elf callback and the
> dwfl_linux_kernel_report_offline reporting function only handled
> vmlinix images possibly compressed with .gz, .bz2 or .xz extension.
> They did not find or handle the much
On Wed, 2019-12-04 at 02:43 +0100, Mark Wielaard wrote:
> GCC10 warns when converting the value of one enum type into another:
>
> debuginfod-client.c:530:24: error: implicit conversion from ‘CURLcode’
>to ‘CURLMcode’ [-Werror=enum-convers
; + (debuginfod_query_server): Call progressfn -after- rather than
> + before curl ops, to make it likely that a successful transfer
> + results in final a=b call. Tweak cleanup sequence.
> + * debuginfod.h: Document $DEBUGINFOD_PROGRESS name.
> +
> 2019-11-26 Ma
On Thu, Dec 05, 2019 at 02:23:56PM +0100, Mark Wielaard wrote:
> Otherwise elfcompress might run against the system libelf which might
> be too old or missing.
I pushed this to master.
On Thu, Dec 05, 2019 at 03:27:54PM +0100, Mark Wielaard wrote:
> Consistently require version-release subpackages so that everything
> is updated together. Technically this isn't always required (it is
> for elfutils-libelf and elfutils-libs). But this makes things more
> consis
On Fri, Dec 06, 2019 at 03:49:14PM +0100, Mark Wielaard wrote:
> Otherwise strip might run against the system libelf which might be too
> old or missing.
Pushed to master.
Hi,
On Fri, Dec 06, 2019 at 05:22:41PM +0100, Mark Wielaard wrote:
> We really need build-ids for various things. If the system compiler
> doesn't generate build-ids warn and generate them anyway for both the
> binaries and the tests.
I pushed this to master with one change:
ChangeLog
> @@ -1,3 +1,8 @@
> +2019-12-06 Frank Ch. Eigler
> +
> + * elfutils.spec.in (debuginfod): Add BuildRequire dpkg
> + for deb testing. (Available on Fedora & EPEL, not base RHEL.)
> +
> 2019-11-28 Mark Wielaard
>
> * elfutils.spec.in (debu
Hi Frank,
On Fri, 2019-12-06 at 22:03 -0500, Frank Ch. Eigler wrote:
> @@ -851,7 +867,11 @@ handle_buildid_r_match (int64_t b_mtime,
> > >return 0;
> > > }
> > >
> > > - string popen_cmd = string("rpm2cpio " + shell_escape(b_source0));
> > > + string archive_decoder = "/dev/null";
On Mon, 2019-12-09 at 19:49 +0100, Mark Wielaard wrote:
> If the debuginfod-client isn't configured we should do as little
> as possible. Simply return early with ENOSYS if no servers are
> configured. This means we won't check
>
> This does change the behavior of
On Wed, 2019-12-11 at 16:23 -0800, Omar Sandoval wrote:
> This small series fixes a couple of issues I encountered when building
> elfutils. Patch 1 fixes an issue when compiling with CFLAGS='-Wno-error
> -O0'. Patch 2 gets rid of a warning.
Both look good, pushed to master. Thanks.
Do you still
On Thu, 2019-12-12 at 21:03 -0800, Omar Sandoval wrote:
> Reading the kernel code, the main sections are indeed contiguous. So
> this was entirely my bug. Sorry for the noise!
>
> On the bright side, patch 2 ("libdwfl: remove broken coalescing logic in
> dwfl_report_segment") does seem like a legi
Hi Frank,
On Thu, 2019-12-12 at 12:18 -0500, Frank Ch. Eigler wrote:
> > I like this idea but have a bit of a security concern about the ability
> > to set it to any file. If someone manages to set it then they can
> > overwrite anything a process using the library can write to.
>
> That's not t
Hi Frank,
On Fri, 2019-12-13 at 11:57 -0500, Frank Ch. Eigler wrote:
> Pushed the following additional patch to fche/debuginfod-progress-env.
> Hand-tested on a ginormous download with various length timeouts; hard
> to test reliably within the elfutils testsuite (esp after removal of
> that induc
Hi Frank,
On Fri, 2019-12-13 at 14:25 -0500, Frank Ch. Eigler wrote:
> > I see, I missed that both functions are only called after first
> > checking the archive type. I think it might be helpful/clearer if
> > both methods would be called with the intended archive type then,
> > also because that
Hi Frank,
On Wed, 2019-12-18 at 19:47 -0500, Frank Ch. Eigler wrote:
> [...]
> > I would add something like:
> >
> > /* Make sure there is at least some progress,
> > try to get at least 1K per progress timeout seconds. */
> > curl_easy_setopt(curl, CURLOPT_LOW_SPEED_TIME, 5 * 1024L);
>
Hi Berkeley,
On Fri, 2019-12-20 at 17:21 +0200, Berkeley Churchill wrote:
> Any interest in integrating with oss-fuzz? It's a google project
> that supports open source projects by fuzzing. It allows Google to
> find and report bugs, especially security bugs, to the project.
> I'm willing to work
1501 - 1600 of 2671 matches
Mail list logo
