Hi Frank, On Tue, 2019-11-12 at 10:14 -0500, Frank Ch. Eigler wrote: > > My only concern is that these might slow down configure when > > debuginfod > > isn't enabled? Can/Should they be moved later after the enable > > test? > > It'd be fractions of a second per configure run ... worth worrying > about?
Probably not, but if it is easy to hide after the check, why not do it? Don't if it requires nasty trickery though. > > > +PKG_PROG_PKG_CONFIG > > > +AC_ARG_ENABLE([debuginfod], AC_HELP_STRING([--enable-debuginfod], [Build > > > debuginfo server and client solib])) > > > +AS_IF([test "x$enable_debuginfod" = "xyes"], [ > > > + AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfo-server]) > > > + PKG_CHECK_MODULES([libmicrohttpd],[libmicrohttpd >= 0.9.33]) > > > + PKG_CHECK_MODULES([libcurl],[libcurl >= 7.29.0]) > > > + PKG_CHECK_MODULES([sqlite3],[sqlite3 >= 3.7.17]) > > > + PKG_CHECK_MODULES([libarchive],[libarchive >= 3.1.2]) > > > +], [enable_debuginfod="no"]) > > > +AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" = "xyes"]) > > > > Would it be better to enable by default with an error to disable if any > > dependencies (and CXX compiler?) aren't found? > > That's up to you as a policy question. We could keep it this way > (manually opt in) for this release to minimize build complications for > our non-rpm/intimate distro partners and then switch to opt-out the > later. I think it is better to enable it by default and error out when the dependencies aren't found. Just add an explicit notice that people can disable it when they don't want it. AC_MSG_NOTICE([checking debuginfod dependencies, disable to skip]) or something like that. Thanks, Mark
