Hi Mao Han,
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> test binary:
> https://github.com/c-sky/test-result/blob/master/elfutils/divzero
> https://github.com/c-sky/test-result/blob/master/elfutils/core
I was looking at these, but they seem to have a wrong e_machine value
of EM_RCE, not EM
Hi Mao Han,
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> +const char *
> +csky_section_type_name (int type,
> + char *buf __attribute__ ((unused)),
> + size_t len __attribute__ ((unused)))
> +{
> + if (type == SHT_CSKY_ATTRIBUTES)
> +return "CS
On Thu, 2019-07-11 at 11:11 +0800, Mao Han wrote:
> On Wed, Jul 10, 2019 at 11:33:23PM +0200, Mark Wielaard wrote:
> > On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> > > test binary:
> > > https://github.com/c-sky/test-result/blob/master/elfutils/divzero
> >
On Fri, 2019-07-12 at 19:22 +0800, Mao Han wrote:
> I've generated binaries/core with an upstream toolchain, however the
> divzero testcase doesn't cause any coredump, so I used a zeroptr
> testcase instead.
> https://github.com/c-sky/test-result/blob/master/elfutils/zeroptr
> https://github.com/c-
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> 5. run-reverse-sections-self.sh
> elfcopy --reverse-offs dose not work properly on C-SKY object file,
> seems not related to arch specific code.
> size.o before copy:
> https://github.com/c-sky/test-result/blob/master/elfutils/size.o
> size.o.rev
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> diff --git a/backends/csky_reloc.def b/backends/csky_reloc.def
> new file mode 100644
> index 000..1108f0c
> --- /dev/null
> +++ b/backends/csky_reloc.def
> @@ -0,0 +1,86 @@
> +/* List the relocation types for csky. -*- C -*-
> + Copyright
Hi,
In another thread I said I would like to do a release end of this week
with the csky backend and the elfclassify tool integrated. But I didn't
make enough time for reviews, so that moves to next week. Sorry.
I should have enough time next week. But we will have to see if we can
polish the csk
On Thu, 2019-07-11 at 11:19 +0800, Mao Han wrote:
> On Thu, Jul 11, 2019 at 12:11:17AM +0200, Mark Wielaard wrote:
> > As far as I can see this is like a SHT_GNU_ATTRIBUTES or
> > SHT_ARM_ATTRIBUTES section. If so, you will also want something
> > like:
> >
> >
On Sat, 2019-07-13 at 00:36 +0200, Mark Wielaard wrote:
> In another thread I said I would like to do a release end of this week
> with the csky backend and the elfclassify tool integrated. But I didn't
> make enough time for reviews, so that moves to next week. Sorry.
>
>
at present.
OK. It is fine as is then. Just wanted to make sure it was as intended.
> > On Thu, 2019-07-11 at 11:19 +0800, Mao Han wrote:
> > > On Thu, Jul 11, 2019 at 12:11:17AM +0200, Mark Wielaard wrote:
> > > > As far as I can see this is like a SHT_GNU_ATTRIBUTES o
On Tue, 2019-07-16 at 19:14 +0800, Mao Han wrote:
> > > The ELF_ARCH was defined as 39 inside linux kernel(before 4.20),
> > > so
> > > the the core file generated was EM_RCE.
> > > I'v regenerated the core file with ELF_ARCH defined as 252:
> > > https://github.com/c-sky/test-result/blob/master/el
Hi Mao Han,
On Wed, 2019-07-17 at 09:19 +0800, Mao Han wrote:
> > The new patch looks really good. Thanks. The addition of the testcases
> > really helps showing things look good. I can make that one small fix
> > s/gnu/csky/ in csky_attrs.c if you agree that is what was intended.
> > Then I'll pu
Hi,
Sorry, this took way too long. But I really like this code.
On Thu, 2019-04-18 at 13:17 +0200, Florian Weimer wrote:
> * Florian Weimer:
>
> > > BTW. Florian, the extra options are certainly not required for you to
> > > implement to get eu-elfclassify accepted. They are just suggestions,
>
Hi,
Some answers to this older discussion to explain some of my recent
commits suggested for elfclassify.
On Tue, 2019-04-16 at 13:38 +0200, Florian Weimer wrote:
> * Mark Wielaard:
> > --elf PATH return 0 whenever the file can be opened and a minimal ELF
> > header can be read (
On Sat, Jul 20, 2019 at 12:23:08AM +0300, Dmitry V. Levin wrote:
> On Fri, Jul 19, 2019 at 11:00:49PM +0200, Florian Weimer wrote:
> > * Dmitry V. Levin:
> >
> > >> So, I don't think the code is wrong. We might want to tweak the comment
> > >> a bit though, to make it less definitive?
> > >
> > >
On Fri, Jul 19, 2019 at 02:47:09PM +0200, Mark Wielaard wrote:
> The individual commits can be found here:
> https://code.wildebeest.org/git/user/mjw/elfutils/log/?h=elfclassify
>
> Please let me know if any of this looks bad or unusual.
>
> I'll write some testcases.
And
On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote:
> On Fri, Jul 19, 2019 at 11:36:53PM +0200, Mark Wielaard wrote:
> > > If the ELF type is ET_DYN and the object is not marked as DF_1_PIE,
> > > could we come up with a more reliable heuristics than DT_SONAME
> Maybe you are looking for another goal/classification? For example I
> added --program which does classify those special files as programs
> (even though --shared also says they are shared libraries). Maybe you
> are looking for a different classification similar/dual to that. Say
> --library?
sion Print program version
Signed-off-by: Mark Wielaard
---
src/ChangeLog |9 +-
src/Makefile.am |4 +-
src/elfclassify.c | 1047 +
tests/ChangeLog |9 +
tests/Makefile.am |7
On Sat, Jul 27, 2019 at 02:04:48AM +0300, Dmitry V. Levin wrote:
> On Sat, Jul 20, 2019 at 11:51:16PM +0200, Mark Wielaard wrote:
> > On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote:
> [...]
> > > btw, I think it would be appropriate to move the has_dynamic c
On Mon, Jul 29, 2019 at 10:43:56AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > + if (elf == NULL)
> > +{
> > + /* This likely means it just isn't an ELF file, probably not a
> > +real issue, but warn if verbose reporting. */
> >
On Mon, Jul 29, 2019 at 11:16:31AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > +/* Called to process standard input if flag_stdin is not no_stdin. */
> > +static void
> > +process_stdin (int *status)
> > +{
> > + char delim;
> > + if (fla
On Mon, Jul 29, 2019 at 11:22:13AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > Signed-off-by: Mark Wielaard
>
> Does elfutils use DCO? Then yoy have my signoff as well:
>
> Signed-off-by: Florian Weimer
Thanks. Yes, elfutils uses a Developer Certificat
Hi Omar,
On Mon, 2019-08-05 at 03:40 -0700, Omar Sandoval wrote:
> From: Omar Sandoval
>
> dwfl_segment_report_module() (used only by dwfl_core_file_report())
> opens a file descriptor and/or an Elf handle, reports a module, and
> assigns mod->main.elf. However, it doesn't assign mod->main.fd, s
On Mon, 2019-07-29 at 16:24 +0200, Mark Wielaard wrote:
> On Mon, Jul 29, 2019 at 10:43:56AM +0200, Florian Weimer wrote:
> > * Mark Wielaard:
> >
> > > + if (elf == NULL)
> > > +{
> > > + /* This likely means it just isn't an ELF file,
On Mon, Aug 12, 2019 at 10:14:20AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > What do you think about this change to dwelf_elf_begin?
> > The change would make it possible to detect real errors in the
> > elfclassify code, whether elf_begin or dwelf_elf_begin w
On Mon, Jul 29, 2019 at 04:38:17PM +0200, Florian Weimer wrote:
> > On Mon, Jul 29, 2019 at 11:16:31AM +0200, Florian Weimer wrote:
> > So the test should be:
> >
> > diff --git a/src/elfclassify.c b/src/elfclassify.c
> > index ebd42c1d5..b17d14d45 100644
> > --- a/src/elfclassify.c
> > +++ b/src/e
ian Weimer
Signed-off-by: Mark Wielaard
---
src/ChangeLog |9 +-
src/Makefile.am |4 +-
src/elfclassify.c | 1046 +
tests/ChangeLog |9 +
tests/Makefile.am |7 +-
tests/run-elfclass
On Mon, Jul 15, 2019 at 12:17:36PM +0200, Mark Wielaard wrote:
> On Sat, 2019-07-13 at 00:36 +0200, Mark Wielaard wrote:
> > In another thread I said I would like to do a release end of this week
> > with the csky backend and the elfclassify tool integrated. But I didn't
>
file
an ELF handle of type ELF_K_NONE is returned.
backends: Add support for C-SKY.
* GIT SHORTLOG *
Florian Weimer (1):
elfclassify: New tool to analyze ELF objects.
Mao Han (2):
libelf: Sync elf.h from glibc
Add backend support for C-SKY
Mark Wielaard (42):
libelf: Handle
Hi Dmitry,
On Wed, Aug 14, 2019 at 11:45:56PM +0300, Dmitry V. Levin wrote:
> Package the new tool introduced by commit elfutils-0.177~1.
>
> Signed-off-by: Dmitry V. Levin
> ---
>
> I have no idea whether this file is actually used as a specfile.
> If not, let's add eu-elfclassify there for co
On Thu, Aug 15, 2019 at 08:28:25AM +, build...@builder.wildebeest.org wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
>
> Full details are available at:
> https://builder.wildebeest.org/buildbot/#builders/10/builds/349
>
> Buildbot URL
There are multiple sections that can contain ELF Notes. It is sometimes
nice to just list the notes from a specific section.
-n, --notes[=SECTION] Display the ELF notes
Signed-off-by: Mark Wielaard
---
src/ChangeLog | 7 +++
src/readelf.c | 13 -
2 files changed, 19
Hi Ben,
On Tue, 2019-08-20 at 12:18 -0700, Ben Coyote Woodard wrote:
> What do you guys think of accepting derived works based upon GNU Free
> Documentation Licensed content? https://www.gnu.org/licenses/fdl-1.3.en.html
>
> As far as I can tell, allowing a project like elfutils the freedom to
>
Hi Jonathon and Srđan,
On Fri, 2019-08-16 at 14:24 -0500, Jonathon Anderson wrote:
> For parallel applications that need the information in the DIEs, the
> Dwarf_Abbrev hash table et al. become a massive data race. This fixes
> that by:
>
> 1. Adding atomics & locks to the hash table to manage c
ble-valgrind-annotations
> + * configure.ac: Add new --with-valgrind (headers only)
> +
> 2019-08-13 Mark Wielaard
>
> * configure.ac: Set version to 0.177.
> diff --git a/configure.ac b/configure.ac
> index c443fa3b..c5406b44 100644
> --- a/configure.ac
> +++ b/configu
On Wed, 2019-08-21 at 23:50 +0200, Mark Wielaard wrote:
> On Fri, 2019-08-16 at 14:24 -0500, Jonathon Anderson wrote:
> > @@ -668,6 +697,7 @@ AC_MSG_NOTICE([
> >OTHER FEATURES
> > Deterministic archives by default :
> > ${default_ar_deterministic}
>
Hi Ben,
On Thu, 2019-08-22 at 07:47 -0700, Ben Woodard wrote:
> - Added doc/README
> - Updated doc/ChangeLog
> - Added a eu-readelf manpage based on the one from binutils.
> - Added a brand new manpage for eu-elfclassify the new utility added
> in 0.177
> - Add some new files in the doc directory
Hi,
On Wed, 2019-08-21 at 09:08 -0500, Jonathon Anderson wrote:
> On Wed, Aug 21, 2019 at 6:16 AM, Mark Wielaard
> wrote:On Fri, 2019-08-16 at 14:24 -0500, Jonathon Anderson wrote:
> > > For parallel applications that need the information in the DIEs, the
> > > Dwarf
On Wed, 2019-08-21 at 09:20 -0500, Jonathon Anderson wrote:
> First message failed to send, hopefully this one works...
Just for the record, the mailinglist did reject HTML
messages/attachments. It should have been changed now to simply strip
the HTML.
Cheers,
Mark
On Wed, 2019-08-21 at 17:21 -0500, Jonathon Anderson wrote:
> > P.S. It looks like something decided to add some line breaks in the
> > patch so that it doesn't easily apply. It isn't hard to fixup, but you
> > might want to consider submitting using git send-email or attaching
> > the result of g
Hi,
On Fri, Aug 16, 2019 at 02:24:28PM -0500, Jonathon Anderson wrote:
> 2. Adding a lock & array structure to the memory manager (pseudo-TLS)
> (libdwP.h, libdw_alloc.c)
Specifically concentrating on this part.
> diff --git a/libdw/ChangeLog b/libdw/ChangeLog
> index bf1f4857..87abf7a7 100644
Hi Jonathon,
On Sat, 2019-08-24 at 20:10 -0500, Jonathon Anderson wrote:
> On Sat, Aug 24, 2019 at 6:24 PM, Mark Wielaard wrote:
> > But what if realloc moves the block?
> > Then all dbg->mem_tails[thread_id] pointers become invalid.
> > And this function drops the
Hi,
On Wed, 2019-08-21 at 12:32 +0200, Mark Wielaard wrote:
> There are multiple sections that can contain ELF Notes. It is sometimes
> nice to just list the notes from a specific section.
>
> -n, --notes[=SECTION] Display the ELF notes
Pushed to master.
les changed, 5 insertions(+)
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index bf1f4857..1d3586f0 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-25 Jonathon Anderson
+
+ * dwarf_getcfi.c (dwarf_getcfi): Set default_same_value to false.
+
2019-08-12 Mark Wielaard
Hi Omar,
On Tue, 2019-07-09 at 12:25 -0700, Omar Sandoval wrote:
> On Tue, Jul 09, 2019 at 09:14:03PM +0200, Mark Wielaard wrote:
> > Then after the release, somewhere next week, we'll apply your patches
> > first and can then deal with any fallout and followups. I am thinkin
Hi Ben,
On Fri, 2019-08-23 at 13:42 -0700, Ben Woodard wrote:
> - Added doc/README
I like this one. If only because it says we would like to move to
sphinx :) I must admit I am not a fan of raw nroff. But of course it is
better than nothing.
> - Updated doc/ChangeLog
Thanks. You don't really ha
The readelf code did parse section numbers, but then failed to actually
dump the section found. Fixed by actually calling the dump function
(either the hex or string variant). Add testcase for readelf -x num.
Signed-off-by: Mark Wielaard
---
src/ChangeLog | 5 +
src/readelf.c
Now that we have manpages lets also package them.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 5 +
config/elfutils.spec.in | 2 ++
2 files changed, 7 insertions(+)
diff --git a/config/ChangeLog b/config/ChangeLog
index 12a141b2..f4d80224 100644
--- a/config/ChangeLog
+++ b
On Wed, 2019-08-28 at 00:34 +0200, Mark Wielaard wrote:
> Now that we have manpages lets also package them.
>
> +2019-08-28 Mark Wielaard
> +
> + * elfutils.spec.in (%files): Add man1/eu-*.1*.
> + (%files libelf-devel): Add man3/elf_*.3*.
That clearly isn't eno
On Mon, 2019-08-26 at 10:58 -0700, Omar Sandoval wrote:
> From: Omar Sandoval
>
> The tool was just added, but it's missing the ignore entry.
Thanks, applied to master.
On Mon, 2019-08-26 at 10:51 -0700, Omar Sandoval wrote:
> From: Omar Sandoval
>
> gen_SOURCES is assigned to libebl_a_SOURCES and never used again. Get
> rid of it.
Thanks for the cleanup. Applied to master.
On Mon, 2019-08-26 at 10:51 -0700, Omar Sandoval wrote:
> From: Omar Sandoval
>
> In preparation for combining the libebl backend modules,
> combine all of the libcpu backends into libcpu.a.
Another nice cleanup. Pushed to master.
Thanks,
Mark
On Mon, 2019-08-26 at 10:51 -0700, Omar Sandoval wrote:
> From: Omar Sandoval
>
> Currently, libcpu and libebl are always compiled as PIC. An upcoming
> change will add the objects from libcpu.a and libebl.a to libdw.a,
> which
> should not be PIC unless configured that way. So, make libcpu.a and
Cheers,
Mark
From ab415cea199547ee06c50aa82eebe9c58307576f Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Wed, 28 Aug 2019 23:55:24 +0200
Subject: [PATCH] libasm: Link against libebl_pic.a.
Signed-off-by: Mark Wielaard
---
libasm/ChangeLog | 4
libasm/Makefile.am | 2 +-
2 files changed, 5 insertions(+), 1
Hi Omar,
On Mon, 2019-08-26 at 10:51 -0700, Omar Sandoval wrote:
> Currently, architecture-specific code for libebl exists in separate
> libebl_$ARCH.so libraries which libebl loads with dlopen() at runtime.
> This makes it impossible to have standalone, statically-linked binaries
> which use libd
From: Jonathon Anderson
Uses the stdatomic.h provided by FreeBSD when GCC doesn't (ie. GCC < 4.9)
Signed-off-by: Jonathon Anderson
Signed-off-by: Srđan Milaković
---
configure.ac | 12 ++
lib/ChangeLog| 6 +
lib/Makefile.am | 3 +-
lib/atomics.h| 37
li
Hi Jonathan,
On Mon, 2019-08-26 at 22:52 -0500, Jonathon Anderson wrote:
> Just finished some modifications to the patch series, git request-
> pull output below. This rebases onto the latest master and does a
> little diff cleaning, the major change is that I swapped out the
> memory management t
From: Jonathon Anderson
Signed-off-by: Jonathon Anderson
---
libdw/ChangeLog | 8 ++
libdw/Makefile.am | 4 +--
libdw/dwarf_begin_elf.c | 12 -
libdw/dwarf_end.c | 7 ++---
libdw/libdwP.h | 59 ++---
libdw/libdw_all
From: Srđan Milaković
Signed-off-by: Srđan Milaković
---
lib/ChangeLog| 5 +
lib/Makefile.am | 4 +-
lib/dynamicsizehash_concurrent.c | 522 +++
lib/dynamicsizehash_concurrent.h | 118 +++
libdw/ChangeLog
of the self test files with smaller
executables/libraries as attached. Hopefully that will reduce the make
check runtime under valgrind so builder don't time out.
Cheers,
Mark
From bb106065dc6962fabf1c163f18c932650dac6580 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Thu, 29 Aug 2019
On Thu, Aug 29, 2019 at 04:23:24PM +0200, Mark Wielaard wrote:
> I am replacing some of the self test files with smaller
> executables/libraries as attached. Hopefully that will reduce the make
> check runtime under valgrind so builder don't time out.
That was interesting. It did
On Tue, Aug 27, 2019 at 04:12:35PM +0200, Mark Wielaard wrote:
> The readelf code did parse section numbers, but then failed to actually
> dump the section found. Fixed by actually calling the dump function
> (either the hex or string variant). Add testcase for readelf -x num.
Pushed to master.
On Wed, Aug 28, 2019 at 12:32:17PM +0200, Mark Wielaard wrote:
> On Wed, 2019-08-28 at 00:34 +0200, Mark Wielaard wrote:
> > Now that we have manpages lets also package them.
> >
> > +2019-08-28 Mark Wielaard
> > +
> > + * elfutils.spec.in (%files): Add man
All archive members from libebl.a are now in libdw.a. We don't generate
separate backend shared libraries anymore. So remove them from the
elfutils.spec file.
Signed-off-by: Mark Wielaard
---
config/ChangeLog| 7 +++
config/elfutils.spec.in | 10 ++
libebl/Chan
testcase to show --symbols=.dynsym and
--dyn-sym produce the same output.
Signed-off-by: Mark Wielaard
---
doc/ChangeLog | 5 +
doc/readelf.1 | 9 +++--
src/ChangeLog | 8
src/readelf.c | 14 +-
tests/ChangeLog| 4
On Tue, 2019-09-03 at 09:44 +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > It is already possible to select the symbol table to print by name,
> > using --symbols=SECTION. This allows printing the dynamic symbol table
> > with --symbols=.dynsym. binutils readelf
35303c Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sat, 7 Sep 2019 21:35:10 +0200
Subject: [PATCH] tests: Add new riscv64 test files to EXTRA_DIST
Signed-off-by: Mark Wielaard
---
tests/ChangeLog | 5 +
tests/Makefile.am | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff
Hi Ulrich,
On Sat, Sep 07, 2019 at 11:18:42AM +0200, Ulrich Drepper wrote:
> I'll check in the attached patch which implements a disassembler for
> RISC-V. It also fixes a problem in the x86 disassember, exposed through
> the additions needed for RISC-V.
This is awesome. Thanks.
> Since aside r
On Thu, 2019-08-29 at 23:43 +0200, Mark Wielaard wrote:
> All archive members from libebl.a are now in libdw.a. We don't generate
> separate backend shared libraries anymore. So remove them from the
> elfutils.spec file.
Pushed to master.
On Tue, 2019-09-03 at 00:10 +0200, Mark Wielaard wrote:
> It is already possible to select the symbol table to print by name,
> using --symbols=SECTION. This allows printing the dynamic symbol table
> with --symbols=.dynsym. binutils readelf allows printing just the
> dynamic symbol t
Hi Sasha,
On Wed, Sep 11, 2019 at 09:52:23PM +, Sasha Da Rocha Pinheiro wrote:
> how do we get the line info range end address for a given line and file?
I am not sure I understand your question competely. What are you
using to get at the line and file? In theory there is no "range end
addr
Hi Sasha,
Sorry for the late reply.
On Thu, 2019-09-12 at 15:22 +, Sasha Da Rocha Pinheiro wrote:
> For my knowledge about it, this information is not encoded in the
> dwarf_line state machine instructions. Right? Would you know how to
> get it?
>
> I know that the state machine will shift l
On Sun, Sep 15, 2019 at 09:14:01AM +0530, Mayuresh Kathe wrote:
> Since the elfutils project provides a Linux-only tuned edition of ELF binary
> management toolkit, why does it not also include an assembler and it's
> associated debugger?
>
> I understand that the AT&T mnemonics are something of a
On Mon, Sep 30, 2019 at 02:39:50PM +0300, Dmitry V. Levin wrote:
> When an input file cannot be opened, include its name
> into the error diagnostics.
Looks very sensible. Pushed to master.
Thanks,
Mark
Hi,
Finally back to this patch series.
On Thu, 2019-08-29 at 15:16 +0200, Mark Wielaard wrote:
> diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c
> index 29795c10..fc573cb3 100644
> --- a/libdw/dwarf_end.c
> +++ b/libdw/dwarf_end.c
> @@ -94,14 +94,15 @@ dwarf_end (Dwarf *dwarf)
Hi,
On Mon, 2019-10-21 at 11:28 -0500, Jonathon Anderson wrote:
> On Mon, Oct 21, 2019 at 18:13, Mark Wielaard wrote:
> > Does that look reasonable?
>
> It does, although I would prefer:
>
> diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c
> index 9ca17212..6da9e
On Thu, 2019-08-29 at 15:16 +0200, Mark Wielaard wrote:
> From: Jonathon Anderson
>
> Uses the stdatomic.h provided by FreeBSD when GCC doesn't (ie. GCC <
> 4.9)
>
> Signed-off-by: Jonathon Anderson
> Signed-off-by: Srđan Milaković
>
> diff --git a/li
Hi,
On Mon, 2019-10-21 at 20:00 +0200, Mark Wielaard wrote:
> I think we cannot use the atomic_load () function, but have to use
> atomic_load_explicit. So it would become:
>
> diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c
> index fc573cb3..a2e94436 100644
> --- a/libdw/d
Hi,
Sorry this took so long to review. But it is pretty complex code.
I think I got how it works mostly. It is hard to proof correct though.
How did you convince yourself that the code is correct?
For example I am not sure I can proof that in resize_worker() this
always holds: assert(GET_STATE(re
On Sat, 2019-10-26 at 12:54 +0200, Florian Weimer wrote:
> * Jonathon Anderson:
>
> > Just finished some modifications to the patch series, git request-pull
> > output below. This rebases onto the latest master and does a little
> > diff cleaning, the major change is that I swapped out the memor
On Sat, 2019-10-26 at 02:47 +, build...@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
> Full details are available at:
> https://builder.wildebeest.org/buildbot/#builders/10/builds/376
>
It looks like the s390
hen parsing all of the linux kernel debug data we are
talking about ~535000 allocations, a bit less than half (~233000) are
of the same small size, 24bytes.
> On Sat, Oct 26, 2019 at 18:14, Florian Weimer wrote:
> > * Mark Wielaard:
> >
> > > I'll see if I can cre
Hi,
On Sat, 2019-10-26 at 18:50 +0200, Florian Weimer wrote:
> * Jonathon Anderson:
>
> > > This assumes that memory allocation
> > > is actually a performance problem, otherwise you could let malloc
> > > handle the details.
> >
> > In our (Dyninst + HPCToolkit) work, we have found that malloc
On Fri, 2019-10-25 at 23:11 -0500, Jonathon Anderson wrote:
> On Sat, Oct 26, 2019 at 01:50, Mark Wielaard wrote:
> > For example I am not sure I can proof that in resize_worker() this
> > always holds: assert(GET_STATE(resize_state) != NO_RESIZING);
> > In genera
On Sat, 2019-10-26 at 19:56 -0500, Jonathon Anderson wrote:
> On Sun, Oct 27, 2019 at 00:50, Mark Wielaard wrote:
> >
> > I see that getconf PTHREAD_KEYS_MAX gives 1024 on my machine.
> > Is this tunable in any way?
>
> From what I can tell, no. A quick google sear
On Sun, 2019-10-27 at 12:49 -0500, Jonathon Anderson wrote:
> In theory (if the system isn't overloaded) the threads should finish
> their individual work at around the same time, so the amount of waiting
> any one thread would do (should be) very short. Also, this is only once
> per resize, whi
On Sun, 2019-10-27 at 17:13 +0100, Mark Wielaard wrote:
> On Fri, 2019-10-25 at 23:11 -0500, Jonathon Anderson wrote:
> > A quick grep -r shows that ITERATE and REVERSE are used for the
> > asm_symbol_tab. If iteration and insertion are not concurrent we can
> > eas
Hi Omar,
On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote:
> dwfl_thread_getframes always frees the state before returning, so
> dwfl_getthreads and getthread don't need to do it.
I am not sure I follow. dwfl_getthreads can be used independently from
its (indirect) usage from dwfl_thread_ge
On Tue, 2019-10-29 at 09:17 -0700, Omar Sandoval wrote:
> Unless I missed something, the only place we allocate the state is
> from dwfl_thread_getframes, and we always free it before returning from
> that function. So if you're not using dwfl_thread_getframes, dwfl_getthreads
> won't have anything
Hi Jonathon,
On Tue, Oct 29, 2019 at 01:55:25PM -0500, Jonathon Anderson wrote:
> This is (revived and rebased) version of the libdw memory manager that isn't
> affected by the PTHREAD_KEYS_MAX limit. There are some downsides, in
> particular if an application spawns many short-lived threads that
From: Jonathon Anderson
Pthread's thread-local variables are highly limited, which makes
it difficult to use many Dwarfs. This replaces that with a
less efficient (or elegant) but more robust method.
Signed-off-by: Jonathon Anderson
---
lib/atomics.h | 2 ++
libdw/ChangeLog
From: Jonathon Anderson
Signed-off-by: Jonathon Anderson
---
ChangeLog| 5 +
configure.ac | 30 ++
2 files changed, 35 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 911cf354..433a5f3c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-
Hi Omar,
On Mon, Oct 07, 2019 at 02:05:36AM -0700, Omar Sandoval wrote:
> thread->unwound is only used for set_initial_registers (via
> dwfl_thread_state_registers, dwfl_thread_state_register_pc, and a
> special case in core_set_initial_registers). At that point,
> thread->unwound is always the in
Hi Frank, Hi Aaron,
On Mon, 2019-10-28 at 15:04 -0400, Frank Ch. Eigler wrote:
> Aaron Merey and I would like to propose debuginfod for merge into
> elfutils mainline, after a couple of months of work. As a reminder,
> this is an http server (written in C++11) for debuginfo-related
> artifacts (e
Hi Omar,
On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote:
> libdwfl has implementations of attaching to/detaching from threads
> and
> unwinding stack traces. However, that functionality is only available
> through the dwfl_thread_getframes interface, which isn't very flexible.
> This adds
Hi Omar,
On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote:
> The next change will need to have the Dwarf_Frame readily available, so
> rather than finding it again every time, let's cache it for reuse. The
> CFI frame can also be useful to clients of libdwfl, so add
> dwfl_frame_dwarf_frame
Hi Omar,
On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote:
> libdwfl can evaluate DWARF expressions in order to unwind the stack,
> but this functionality isn't exposed to clients of the library. Now that
> the pieces are in place, add dwfl_frame_eval_expr to provide this feature.
I think t
Hi Frank,
On Wed, 2019-10-30 at 09:40 -0400, Frank Ch. Eigler wrote:
> OK, sure, IMO don't even bother with a guard. It's just a dlopen/dlsym,
> which is portable. Will update the first patch on the branch with that.
Thanks.
> > Also I think you should cache a negative result for
> > fp_debugi
Hi Frank,
On Wed, 2019-10-30 at 14:11 -0400, Frank Ch. Eigler wrote:
> Revised code to look like this (libdwfl/find-debuginfo.c):
>
> 00404 /* NB: this is slightly thread-unsafe */
> 00405 static __typeof__ (debuginfod_find_debuginfo)
> *fp_debuginfod_find_debuginfo;
> 00406
> 00407
1401 - 1500 of 2671 matches
Mail list logo
