On Wed, 2019-08-21 at 23:50 +0200, Mark Wielaard wrote:
> On Fri, 2019-08-16 at 14:24 -0500, Jonathon Anderson wrote:
> > @@ -668,6 +697,7 @@ AC_MSG_NOTICE([
> > OTHER FEATURES
> > Deterministic archives by default :
> > ${default_ar_deterministic}
> > Native language support : ${USE_NLS}
> > + Extra Valgrind annotations : ${use_vg_annotations}
> >
> > EXTRA TEST FEATURES (used with make check)
> > have bunzip2 installed (required) : ${HAVE_BUNZIP2}
>
> This part sets up things so we can include extra valgrind
> annotations,
> but then doesn't seem to be used. It sounds useful though, because
> valgrind/helgrind won't know about any of the atomics. Is this
> something you added, but then removed?
Ah, I should have read to the end, sorry. I see you then use them in
libdw/libdw_alloc.c as happens before/after annotations.
Cheers,
Mark