Re: elfutils code names

2023-02-23 Thread Martin Liška
On 2/21/23 16:12, Mark Wielaard wrote: > On Thu, 2023-02-16 at 13:37 +0100, Mark Wielaard wrote: >> Hi, >> >> On irc (#elfutils on libera.chat) we had a discussion about the >> elfutils code names. For some reason those are only in the irc channel >> topic. Which seems to mean not many people know

Re: elfutils code names

2023-02-23 Thread Mark Wielaard
Hi Martin, On Thu, 2023-02-23 at 09:35 +0100, Martin Liška wrote: > > So 0.169 is missing and I am not sure any version before 0.162 had a > > code name. But if you remember differently please update/correct this > > list. > > A nice archeological work Mark! Please set that in stone somewhere, id

Re: [PATCH 2/2] libdw: Use elf_rawdata when checking .debug section

2023-02-23 Thread Mark Wielaard
Hi, On Tue, 2023-02-21 at 12:24 +0100, Mark Wielaard wrote: > On Tue, 2023-02-21 at 05:28 +0300, Evgeny Vereshchagin wrote: > > On Mon, 20 Feb 2023 at 19:03, Aleksei Vetrov wrote: > > > On Mon, Feb 20, 2023 at 3:55 PM Mark Wielaard wrote: > > > > > > > > .debug sections are raw bytes and don't

Re: A scenario where Perf cannot unwind the user stack by dwarf with libdw.so

2023-02-23 Thread Mark Wielaard
Hi, On Thu, 2023-02-16 at 23:48 +0100, Mark Wielaard wrote: > On Mon, Feb 13, 2023 at 01:44:39AM +, liuxu (AJ) via Elfutils-devel wrote: > > I am failing to unwind the user stack with libdw on Ubuntu 18.04 > > arm64 environment, the toolchain used is clang 12.0.1. form the > > unwinding proce

Re: [PATCH v2 02/16] move platform depended include into system.h of libebl

2023-02-23 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:51 +0800, Yonggang Luo via Elfutils-devel wrote: > Because all source in libebl #include , so #include in > libeblP.h is enough, there is multiple memory-access.h file, so use relative > path to > include it properly, See the discussion around v1 of this patch: http

Re: [PATCH v2 03/16] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h

2023-02-23 Thread Mark Wielaard
Hi, See also the discussion on v1 of this patch: https://inbox.sourceware.org/elfutils-devel/f352dba78caee57afc17995f8e36d28ae98afbc0.ca...@klomp.org/#r I think we need to think about what the libelf API looks like without mmap. In particular I think we need to decide what to do with the Elf_Cmds

Re: [PATCH v2 04/16] Fixes usage of basename about prototype differences

2023-02-23 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > diff --git a/libdw/dwarf_getsrc_file.c b/libdw/dwarf_getsrc_file.c > index 5289c7da..884fea32 100644 > --- a/libdw/dwarf_getsrc_file.c > +++ b/libdw/dwarf_getsrc_file.c > @@ -98,7 +98,7 @@ dwarf_getsrc_file (Dwarf *dbg

☝ Buildbot (Sourceware): elfutils - retry lost connection test (retry) (master)

2023-02-23 Thread builder--- via Elfutils-devel
A retry build has been detected on builder elfutils-fedora-arm64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/180/builds/116 Build state: retry lost connection test (retry) Revision: 1807e14802d00a9320cd7a079b6c70c9cb7afca7 Worker:

Re: [PATCH v2 05/16] libcpu: Remove the need of NMNES by using enum

2023-02-23 Thread Mark Wielaard
Hi, On Wed, 2022-12-21 at 18:56 +0100, Mark Wielaard wrote: > On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > libcpu/Makefile.am | 2 +- > > libcpu/i386_disasm.c | 14 +- > > libcpu/i386_mne.h| 36

Re: [PATCH v2 07/16] libdw: Fixes compile of dwarf_whatattr.c and dwarf_whatform.c

2023-02-23 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > If __OPTIMIZE__ is defined, then compile dwarf_whatattr.c and > dwarf_whatform.c > will cause symbol conflict between > dwarf_whatattr.c and libdw.h, > dwarf_whatform.c and libdw.h, > > So always undefined __OPTIMIZ

Re: [PATCH v2 08/16] lib: Implement error properly even when not HAVE_ERR_H

2023-02-23 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > on win32, there is no err.h See also the discussion around v1 of this patch, I don't believe this is a correct implementation of error. In particular it seems to not print the errno string. https://inbox.sourceware.or

Re: [PATCH v2 10/16] libasm: stdio_ext.h are not present on win32

2023-02-23 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libasm/asm_begin.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libasm/asm_begin.c b/libasm/asm_begin.c > index 9e4dfe43..9b6d974e 100644 > --- a

Re: [PATCH 1/4] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register

2023-02-23 Thread Mark Wielaard
Hi German, On Mon, 2022-04-25 at 14:03 +, German Gomez via Elfutils-devel wrote: > This register will be used to indicate whether a return address is > mangled with a PAC or not, in accordance with the DWARF AARCH64 ABI [1]. > > [1] > https://github.com/ARM-software/abi-aa/blob/main/aadwarf6

Issue 56179 in oss-fuzz: elfutils:fuzz-libdwfl: Use-of-uninitialized-value in check_section

2023-02-23 Thread ClusterFuzz-External via monorail via Elfutils-devel
Updates: Labels: ClusterFuzz-Verified Status: Verified Comment #2 on issue 56179 by ClusterFuzz-External: elfutils:fuzz-libdwfl: Use-of-uninitialized-value in check_section https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56179#c2 ClusterFuzz testcase 6538272475316224 is ver

Re: [PATCH 2/4] libdw, aarch64: Implement DW_CFA_AARCH64_negate_ra_state CFI instruction

2023-02-23 Thread Mark Wielaard
Hi German, On Mon, 2022-04-25 at 14:03 +, German Gomez via Elfutils-devel wrote: > Implement DW_CFA_AARCH64_negate_ra_state in accordance with the DWARF > AARCH64 ABI [1]. > > Followup commits will use the value of this register to remove the PAC > from return addresses. > > [1] > https://g

Re: [PATCHv2] strip: keep .ctf section in stripped file

2023-02-23 Thread Guillermo E. Martinez via Elfutils-devel
On Thu, Feb 23, 2023 at 12:04:47AM +0100, Mark Wielaard wrote: > Hi, Hi Mark, > > On Wed, Feb 22, 2023 at 11:12:07AM -0600, Guillermo E. Martinez wrote: > > The conclusion was basically not use section flags to identify which > > section should be stripped out or not, so, it requires other mecha

[PATCH v3] strip: keep .ctf section in stripped file

2023-02-23 Thread Guillermo E. Martinez via Elfutils-devel
Hello, This is the third version of the patch to avoid remove the CTF section in stripped files. Changes from v2: - Rebased from master. Please let me know your thoughts. Kind regards, guillermo -- CTF debug format was designed to be present in stripped files, so this section should not be r

Re: [PATCH 0/4] Add AARCH64 pointer authentication support

2023-02-23 Thread Mark Wielaard
Hi German, On Thu, May 19, 2022 at 02:30:23PM +0100, German Gomez via Elfutils-devel wrote: > On 28/04/2022 20:56, Mark Wielaard wrote: > > I haven't been able to look at the actual patches yet. And I am on > > vacation this week. But I'll review next week after I am back. > > Thanks a lot for lo