Hi German,
On Mon, 2022-04-25 at 14:03 +0000, German Gomez via Elfutils-devel
wrote:
> This register will be used to indicate whether a return address is
> mangled with a PAC or not, in accordance with the DWARF AARCH64 ABI [1].
>
> [1]
> https://github.com/ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.rst#41dwarf-register-names
This looks good. With one nit:
> diff --git a/libdw/dwarf.h b/libdw/dwarf.h
> index 3ce7f236..f234c411 100644
> --- a/libdw/dwarf.h
> +++ b/libdw/dwarf.h
> @@ -1011,6 +1011,11 @@ enum
> DW_EH_PE_indirect = 0x80
> };
>
> +/* AARCH64 DWARF registers. */
> +enum
> + {
> + DW_AARCH64_RA_SIGN_STATE = 34
> + };
>
> /* DWARF XXX. */
> #define DW_ADDR_none 0
dwarf.h is a public header. I rather not define this DW constant here.
Especially since it doesn't seem to have common name (binutils-gdb
calls this AARCH64_DWARF_RA_SIGN_STATE, but only defines it in a
private header). Lets move this into cfi.c as private implementation
detail in the next patch.
Thanks,
Mark
