Re: [PATCH v2 1/7] libasm: Fix xdefault_pattern initialization

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > clang complains: > > asm_newscn.c:48:22: error: field 'pattern' with variable sized type > 'struct FillPattern' not at the end of a struct or class is a GNU extension > [-Werror,-Wgnu-variable-sized-type-not-at-end] >

[Bug general/30084] readelf.c:handle_bit_registers() sets parameter desc without using it.

2023-02-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30084 Mark Wielaard changed: What|Removed |Added Status|NEW |RESOLVED CC|

Re: [PATCH v2 3/7] readelf: Fix set but not used parameter

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > clang complains: > > readelf.c:12205:72: error: parameter 'desc' set but not used > [-Werror,-Wunused-but-set-parameter] > handle_bit_registers (const Ebl_Register_Location *regloc, const void > *desc, >

Re: [PATCH v2 5/7] configure: Use -fno-addrsig if possible

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > By default, clang produces .llvm_addrsig sections [1]. The GNU > toolchain does not know how to handle them yet [2], so just ask clang > not to generate them for the time being. > > [1] > https://llvm.org/docs/Extensions.html#

Re: [PATCH v2 6/7] configure: Add --disable-demangler

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > __cxa_demangle is normally implemented in the C++ runtime library, > instrumenting which for MSan is a hassle. Add a knob for disbling it. Thanks for the fixes. Pushed, Mark > Signed-off-by: Ilya Leoshkevich > --- > config

Re: [PATCH v2 4/7] x86_64_return_value_location: Support lvalue and rvalue references

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > On the low level, they are the same as pointers. Yes, I can see how that would work for return types. Do you happen to have a testcase for this? Right below this code is a check whether the type has a DW_AT_byte_size, and if n

Re: [PATCH RFC 03/11] printversion: Fix unused variable

2023-02-09 Thread Mark Wielaard
Hi Ilya, On Wed, 2023-02-08 at 13:22 +0100, Ilya Leoshkevich wrote: > If I build: > > const char *const apba__ __asm ("argp_program_bug_address") \ > __attribute__ ((used)) = "foobarbaz"; > > with C and C++, the difference is going to be: > > @@ -1,6 +1,5 @@ > .file "1.c" > .text

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-09 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-rawhide-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/140/builds/102 Build state: failed test (failure) Revision: 2e7fbb96f578454ea80cf604b636155779eb03bf Worker: bb1-2 Buil

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-09 Thread Mark Wielaard
Hi, On Thu, 2023-02-09 at 14:20 +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-rawhide-x86_64 while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/140/builds/102 > > Build state:

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-09 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-opensusetw-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/88/builds/111 Build state: failed test (failure) Revision: 0ffe2874e75d48cb88936e119e5284ff2bf664d9 Worker: bb3 Buil

Re: [PATCH RFC 03/11] printversion: Fix unused variable

2023-02-09 Thread Ilya Leoshkevich via Elfutils-devel
On Thu, 2023-02-09 at 15:04 +0100, Mark Wielaard wrote: > Hi Ilya, > > On Wed, 2023-02-08 at 13:22 +0100, Ilya Leoshkevich wrote: > > If I build: > > > > const char *const apba__ __asm ("argp_program_bug_address") \ > > __attribute__ ((used)) = "foobarbaz"; > > > > with C and C++, the difference

Re: [PATCH v2 4/7] x86_64_return_value_location: Support lvalue and rvalue references

2023-02-09 Thread Ilya Leoshkevich via Elfutils-devel
On Thu, 2023-02-09 at 14:45 +0100, Mark Wielaard wrote: > Hi Ilya, > > On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > > On the low level, they are the same as pointers. > > Yes, I can see how that would work for return types. > Do you happen to have a testcase for this? You can tri