Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

On Jul 17 2018, Mark Wielaard wrote: > On Mon, Jul 16, 2018 at 12:02:17PM +0200, Ulf Hermann wrote: >> strip does not produce debug files for riscv binaries. If this is a bug >> it needs to be fixed in strip, but for now, we disable the tests. > > The issue is that hello_riscv64.ko doesn't contai

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

On Tue, 2018-07-17 at 11:29 +0200, Andreas Schwab wrote: > On Jul 17 2018, Mark Wielaard wrote: > > The issue is that hello_riscv64.ko doesn't contain any debug > > sections. > > So strip doesn't produce a separate debug file. > > > > Andreas, could you provide an updated hello_riscv64.ko that is

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

On Jul 17 2018, Ulf Hermann wrote: > My first patch removes all temporary files at the beginning of runtest() > which exposes this. Thanks, I see the failure now. Here is the updated module: hello_riscv64.ko.bz2 Description: BZip2 compressed data Andreas. -- Andreas Schwab, SUSE Labs, sch

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

On Jul 17 2018, Mark Wielaard wrote: > If you could regenerate the file with -g so that it does contain .debug > sections that would help us fix the testcase. It would probably help to update the build instructions to force debug builds by adding CONFIG_DEBUG_INFO=y. Andreas. -- Andreas Schwa

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

On Tue, 2018-07-17 at 12:09 +0200, Andreas Schwab wrote: > It would probably help to update the build instructions to force > debug > builds by adding CONFIG_DEBUG_INFO=y. Yes, good idea, added that and updated the test file. Thanks, MarkFrom c1d7a08c990a13472b64281dbf79b13fb74f9e5a Mon Sep 17 0

Re: [PATCH 1/2] Remove previous test files before running the next round

On Mon, 2018-07-16 at 23:57 +0200, Mark Wielaard wrote: > On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote: > > strip explicitly creates the new files. This will not work on > > windows if > > the files already exist. > > > > Also, if strip fails to create the files for any reason, we w

[PATCH] backends: add core_note callback for RISC-V

Signed-off-by: Andreas Schwab --- backends/ChangeLog| 6 backends/Makefile.am | 2 +- backends/riscv_corenote.c | 60 +++ backends/riscv_init.c | 1 + 4 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 backends/riscv_c

Re: [PATCH] backends: add core_note callback for RISC-V

Looks good as far as I can tell. Pushed to master. But it would be really nice to have a testcase. Could you look at tests/run-readelf-mixed-corenote.sh and add something similar for RISC-V? Thanks, Mark

Re: [PATCH] Don't include sys/uio.h if we don't need it

On Tue, Jul 17, 2018 at 01:40:26PM +0200, Ulf Hermann wrote: > > The PID attaching only works on linux. > > Change-Id: I00428a711b64cb490429363ef28a867b1347956e Thanks applied to master. I did remove the Change-Id tag. And normally we do require a Signed-off-by line. Cheers, Mark