On Mon, 2018-07-16 at 23:57 +0200, Mark Wielaard wrote:
> On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote:
> > strip explicitly creates the new files. This will not work on
> > windows if
> > the files already exist.
> > 
> > Also, if strip fails to create the files for any reason, we would
> > check
> > the previous run's files and succeed. However, the test should fail
> > then.
> 
> This makes sense and does uncover a bug as your second patch shows.
> I want to fix that first and only then commit this fix. That way we
> don't have the testsuite failing between commits.

Pushed now that we have an updated hello_riscv64.ko test file.

Thanks,

Mark

Reply via email to