Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2022-08-08 Thread Mark Wielaard
Hi Noah, On Fri, Aug 05, 2022 at 03:21:48PM -0400, Noah Sanci wrote: > On Thu, Aug 4, 2022 at 9:12 AM Mark Wielaard wrote: > > > > Hi Noah, > > > > On Thu, 2022-07-14 at 11:32 -0400, Noah Sanci via Elfutils-devel wrote: > > > Please find the patch for pr28284 attached > > > > > > Debuginfod a

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2022-08-04 Thread Mark Wielaard
Hi Noah, On Thu, 2022-07-14 at 11:32 -0400, Noah Sanci via Elfutils-devel wrote: > Please find the patch for pr28284 attached > > Debuginfod and debuginfod clients are now equipped to send > and receive http headers prefixed with X-DEBUGINFOD and > print them in verbose mode for more

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2022-07-14 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch for pr28284 attached Debuginfod and debuginfod clients are now equipped to send and receive http headers prefixed with X-DEBUGINFOD and print them in verbose mode for more context Noah Sanci From 2d4902ca53b80b5cd5689a1ba77e4465c33fea64 Mon Sep 17 00:00:0

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-10-05 Thread Mark Wielaard
Hi Frank, On Wed, 2021-09-29 at 17:28 -0400, Frank Ch. Eigler wrote: > The problem with what we have now, with $DEBUGINFOD_VERBOSE, is that > the amount of output is huge. It is a debugging level trace. It's > not consumable by non-expert users OR by software. OK, but that seem two separate iss

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > And if I understand your comments above correctly, you would rather see > a function like const char* debuginfod_get_url (debuginfod_client > *client); but for any headers. Correct. > Would such a headers call be only be accessible during > debuginfod_progressfn_t callback or wou

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-29 Thread Mark Wielaard
Hi Frank, On Wed, 2021-09-22 at 16:33 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > > from providing an interface to query what needs to be done to get > > some file (is it in cache, can it be retieved from a remote server, > > how > > big is it?) I don't think providing raw http headers is

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-22 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > > > That in turn would require THREE new API functions or a > > > > stateful set_HEAD_mode_and_return_dev_null one and modifying > > > > the three main lookup functions. > > > Yes, it definitely is more work. > > > > So, is that your suggestion? We proceed with that sort of thing? > >

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-16 Thread Mark Wielaard
Hi Noah, On Mon, 2021-09-13 at 16:07 -0400, Noah Sanci via Elfutils-devel wrote: > On Sun, Sep 12, 2021 at 3:08 PM Mark Wielaard wrote: > > > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't > > > trip and fail as previously greping for a value that should yield zero > > > caus

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-13 Thread Noah Sanci via Elfutils-devel
Hello, On Sun, Sep 12, 2021 at 3:08 PM Mark Wielaard wrote: > > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't > > trip and fail as previously greping for a value that should yield zero > > caused an error. > > I think this part should be in this patch. Do you mean should or

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-12 Thread Mark Wielaard
Hi Noah, On Fri, Sep 10, 2021 at 02:22:00PM -0400, Noah Sanci via Elfutils-devel wrote: > From 979f19eb4fd7a35ace4ddafed103922559b93120 Mon Sep 17 00:00:00 2001 > From: Noah Sanci > Date: Wed, 28 Jul 2021 14:46:05 -0400 > Subject: [PATCH 2/2] debuginfod: PR27277 - Describe retrieved files when >

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-10 Thread Noah Sanci via Elfutils-devel
Hello, The updated patch is attached. On Wed, Sep 8, 2021 at 4:56 PM Mark Wielaard wrote: > On Fri, Aug 27, 2021 at 02:38:27PM -0400, Noah Sanci via Elfutils-devel wrote: > > From ed7638571f188e346dd466c195b9ebda028d1c65 Mon Sep 17 00:00:00 2001 > > From: Noah Sanci > > Date: Wed, 28 Jul 2021 1

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-08 Thread Mark Wielaard
Hi Noah, Looks like I reviewed a slightly older version earlier. Could you merge the reviewes/changes for both version in a new version of this patch? On Fri, Aug 27, 2021 at 02:38:27PM -0400, Noah Sanci via Elfutils-devel wrote: > From ed7638571f188e346dd466c195b9ebda028d1c65 Mon Sep 17 00:00:0

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-08 Thread Mark Wielaard
Hi Noah, On Wed, 2021-08-25 at 14:08 -0400, Noah Sanci via Elfutils-devel wrote: > There appear to exist use cases that intend to simply check for the > existence of content in a debuginfod server, without actually > downloading it. In HTTP land, the HEAD operation is the natural > expression of

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-27 Thread Noah Sanci via Elfutils-devel
Hello, Here is the patch which prints the http headers when verbose. -Noah Sanci On Tue, Aug 24, 2021 at 4:19 AM Mark Wielaard wrote: > > Hi Noah, > > On Mon, 2021-08-23 at 11:11 -0400, Noah Sanci wrote: > > I'm back to working on this patch, thanks for your patience and > > comments. > > > > O

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-24 Thread Mark Wielaard
Hi Noah, On Mon, 2021-08-23 at 11:11 -0400, Noah Sanci wrote: > I'm back to working on this patch, thanks for your patience and > comments. > > On Mon, Aug 9, 2021 at 5:27 AM Mark Wielaard wrote: > > Yes, separate the verbose printing of http headers (which I really do > > like) from providing a

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-23 Thread Noah Sanci via Elfutils-devel
Hello, I'm back to working on this patch, thanks for your patience and comments. On Mon, Aug 9, 2021 at 5:27 AM Mark Wielaard wrote: > Yes, separate the verbose printing of http headers (which I really do > like) from providing an interface to query what needs to be done to get > some file (is i

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-09 Thread Mark Wielaard
Hi Frank, On Fri, 2021-08-06 at 14:54 -0400, Frank Ch. Eigler wrote: > > Yes, since the actual download might take a bit, it is nice to see > > the > > headers at the moment we commit to a server/download. aka here in > > the > > source: > > > > if (vfd >= 0 && !verbose_reported && committed_to

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-06 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Yes, since the actual download might take a bit, it is nice to see the > headers at the moment we commit to a server/download. aka here in the > source: > > if (vfd >= 0 && !verbose_reported && committed_to >= 0) > { > bool pnl = (c->default_progressfn_printed_p && vfd == STDER

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-06 Thread Mark Wielaard
Hi, On Thu, 2021-08-05 at 12:54 -0400, Frank Ch. Eigler wrote: > > I like the verbose http header output, but wish it was done earlier > > instead of after the download. Maybe when we commit to an url, if > > the > > info is available then. > > What do you mean "done"? Printed? Yes, since the a

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-05 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I like the verbose http header output, but wish it was done earlier > instead of after the download. Maybe when we commit to an url, if the > info is available then. What do you mean "done"? Printed? > The new X-FILE and X-ARCHIVE headers also seem useful. > One question about X-FILE, if

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-05 Thread Mark Wielaard
Hi Noah, On Wed, 2021-08-04 at 14:54 -0400, Noah Sanci via Elfutils-devel wrote: > The attached patch dumps the http headers retrieved from the > debuginfod server which a file was downloaded from. Some custom > headers are now returned such as X-FILE, X-FILE-SIZE, and X-ARCHIVE > to give some con