Hi Noah,
On Mon, 2021-09-13 at 16:07 -0400, Noah Sanci via Elfutils-devel wrote:
> On Sun, Sep 12, 2021 at 3:08 PM Mark Wielaard <m...@klomp.org> wrote:
> > > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't
> > > trip and fail as previously greping for a value that should yield zero
> > > caused an error.
> >
> > I think this part should be in this patch.
>
> Do you mean should or shouldn't? Removed for now.
That should should have been shouldn't.
> > > +# Wait till both files are in the index and scan/index fully
> > > finished
> > > +wait_ready $PORT1 'thread_work_total{role="traverse"}' 2
> > > +wait_ready $PORT1 'thread_work_pending{role="scan"}' 0
> > > +wait_ready $PORT1 'thread_busy{role="scan"}' 0
> > > +# All rpms need to be in the index, except the dummy permission-
> > > 000 one
> > > +rpms=$(find R -name \*rpm | grep -v nothing | wc -l)
> > > +wait_ready $PORT1 'scanned_files_total{source=".rpm archive"}'
> > > $rpms
> > > +kill -USR1 $PID1 # two hits of SIGUSR1 may be needed to resolve
> > > .debug->dwz->srefs
> > > +# Wait till both files are in the index and scan/index fully
> > > finished
> > > +wait_ready $PORT1 'thread_work_total{role="traverse"}' 3
> > > +wait_ready $PORT1 'thread_work_pending{role="scan"}' 0
> > > +wait_ready $PORT1 'thread_busy{role="scan"}' 0
> >
> > Is it really necessary to add all this if this is just a test to
> > check
> > the new headers are sent?
>
> A lot of the setup is to check that both the archive and regular file
> headers are added. In the attached
> path I removed as much as I felt reasonable. Please get back to me on
> if it is enough.
Ah, yes, of course I had forgotten about the archive headers.
> Subject: [PATCH] debuginfod: PR27277 - Describe retrieved files when verbose
>
> Allow users, with enough verbosity, to print the HTTP response headers
> upon retrieving a file. These files may include several custome http
> response headers such as X-DEBUGINFOD-FILE, X-DEBUGINFOD-SIZE, and
> X-DEBUGINFOD-ARCHIVE. These headers are added from the daemon, in
> debuginfod.cxx.
> run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't
> trip and fail as previously greping for a value that should yield zero
> caused an error.
^ This paragraph doesn't document a change in the patch.
> E.g output:
>
> HTTP/1.1 200 OK
> Connection: Keep-Alive
> Content-Length: 4095072
> Cache-Control: public
> Last-Modified: Thu, 09 Sep 2021 19:06:40 GMT
> X-FILE: debuginfod
> X-FILE-SIZE: 4095072
> Content-Type: application/octet-stream
> Date: Fri, 10 Sep 2021 16:38:06 GMT
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=27277
But except for that one paragraph in the commit message that shouldn't
be there, this looks good. Please remove that paragraph from the commit
message (or replace it with one describing the new test added), rebase
it against the master branch and push it please.
Thanks,
Mark
