Re: [patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-08 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > Good point, we don't want an aborted new transfer to retain records > > from a previous run, will fix that. > > Not just a new transfer, but also when we hit the cache before doing a > new transfer. Currently when we hit the cache and don't do any transfer > the winning_headers will poin

Re: [patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-08 Thread Mark Wielaard
Hi Frank, On Tue, 2022-09-06 at 12:05 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > > This looks good, but I think c->winning_headers needs to be > > freed/cleared at the start of debuginfod_query_server. Otherwise if you > > reuse the debuginfod_client and you hit the cache, the user gets t

Re: [patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-06 Thread Ryan Goldberg via Elfutils-devel
Hi all, > Well, dunno, can't speak for we all. :-) For debugging purposes (which > is what DEBUGINFOD_VERBOSE is), we could print all headers that come > in, from any server we're connecting to. For API / human-friendly > use, limiting to x-debuginfod* ones from the winning server seems more > us

Re: [patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-06 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Thanks for giving it a look. > > I had a bit of time to tweak Noah Sanci's PR28284 work, and I believe > > it addresses Mark's last set of comments (from a while ago). This > > follow-up patch corrects things like case sensitivity, spacing, \r\n > > processing, and tweaks documentation. >

Re: [patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-06 Thread Mark Wielaard
Hi Frank, On Fri, 2022-09-02 at 20:13 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > I had a bit of time to tweak Noah Sanci's PR28284 work, and I believe > it addresses Mark's last set of comments (from a while ago). This > follow-up patch corrects things like case sensitivity, spacing, \r\

[patch git] PR28284 - debuginfod x-debuginfod* header processing

2022-09-02 Thread Frank Ch. Eigler via Elfutils-devel
Hi - I had a bit of time to tweak Noah Sanci's PR28284 work, and I believe it addresses Mark's last set of comments (from a while ago). This follow-up patch corrects things like case sensitivity, spacing, \r\n processing, and tweaks documentation. The gist of it is to add a new client api functi