Hi Frank, On Fri, 2022-09-02 at 20:13 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > I had a bit of time to tweak Noah Sanci's PR28284 work, and I believe > it addresses Mark's last set of comments (from a while ago). This > follow-up patch corrects things like case sensitivity, spacing, \r\n > processing, and tweaks documentation.
I hadn't thought about the \r\n at the end of the HTTP headers. Thanks. I assume \r\n at the end of HTTP headers required, since you are expecting in the code now, or could it also be \n on its own? > The gist of it is to add a new client api function > debuginfod_get_headers(), documented to return x-debuginfod* headers > from current or previous fetch requests. This looks good, but I think c->winning_headers needs to be freed/cleared at the start of debuginfod_query_server. Otherwise if you reuse the debuginfod_client and you hit the cache, the user gets the headers from the last use of debuginfod_client that did fetch something from a server. Which imho is confusing (the headers won't match the cached result returned). > debuginfod-find prints those > in -v verbose mode, and debuginfod relays them in federation. This is the only thing I am not 100% happy about. It means you can only see the headers using debuginfod-find but no longer with any other client when DEBUGINFOD_VERBOSE is set. Is this really what we want? > This stuff is an enabler for rgoldber's subsequent > signature-passing/checking code, to which I plan to turn my attention > next. > > Please see users/fche/try-pr28284d for this draft of the code. I'd > like to keep it as two separate commits to preserve Noah's id in the > git history, even though that makes it a bit harder to give a final > review. Thanks. I like this version except for those two nitpicks above. What do you think? Cheers, Mark
