Re: Hitting g dwfl->lookup_elts limit in report_r_debug, so not all modules show up and backtracing fails

2023-05-02 Thread Florian Weimer via Elfutils-devel
* Luke Diamand via Elfutils-devel: > I've got a few cores where report_r_debug() in link_map.c fails to > find all of the modules - for example I had libc.so missing. This > obviously meant that elfutils could not backtrace my core. > > It seems to be related to this code: > > /* There can't be

[PATCH] testsuite: Avoid C99 compatibility issues in run-native-test.sh

2023-04-22 Thread Florian Weimer via Elfutils-devel
Include for the pause function, and add the return type of main. Avoids an implicit function declaration and implicit int. Signed-off-by: Florian Weimer --- Related to:

Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't

2023-02-16 Thread Florian Weimer via Elfutils-devel
* Mark Wielaard: > Hi Florian, > > On Thu, 2023-02-16 at 11:48 +0100, Florian Weimer via Elfutils-devel > wrote: >> * Mark Wielaard: >> >> > + [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use >> > --disable-demangler to disable demangle

Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't

2023-02-16 Thread Florian Weimer via Elfutils-devel
* Mark Wielaard: > + [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use > --disable-demangler to disable demangler support.])]), Missing punctuation after libstdc++? Thanks, Florian

Re: Using libcurl in another library, when/if to call curl_global_init?

2022-04-05 Thread Florian Weimer via Elfutils-devel
* Mark Wielaard: > Hi, > > On Thu, Mar 31, 2022 at 04:00:16PM +0300, Catalin Raceanu via curl-library > wrote: >> On 31-Mar-22 15:04, Mark Wielaard wrote: >> > whether there is a thread-safe way to call >> > curl_global_init at a later time (to get rid of the library constructor >> > init functio

Re: [PATCH] libelf: Use offsetof to get field of unaligned

2021-12-15 Thread Florian Weimer via Elfutils-devel
* Mark Wielaard: > This seems a wrong warning since we aren't accessing the field member > of the struct, but are taking the address of it. But we can do the > same by adding the field offsetof to the base address. Which doesn't > trigger a runtime error. I think the warning is correct. I believ

Re: [PATCH] build: allow turning off --no-undefined and -z,defs

2021-12-04 Thread Florian Weimer via Elfutils-devel
* Evgeny Vereshchagin: > ASan, UBSan and MSan provided by clang aren't compatible with --no-undefined > and -z,defs: > https://clang.llvm.org/docs/AddressSanitizer.html#usage > https://github.com/google/sanitizers/issues/380 > so to build elfutils with clang with the sanitizers it should be possi

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-12-02 Thread Florian Weimer via Elfutils-devel
* Frank Ch. Eigler: >> > Yes, and yet we have had the bidi situation recently where UTF-8 raw >> > codes could visually confuse a human reader whereas escaped \u >> > wouldn't. If we forbid \u unilaterally, we literally become >> > incompatible with JSON (RFC8259 7. String. "Any character

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Florian Weimer via Elfutils-devel
* Frank Ch. Eigler via Elfutils-devel: > Hi - > > On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: >> [...] >> The spec does explain the requirements for JSON numbers, but doesn't >> mention any for JSON strings or JSON objects. It would be good to also >> explain how to make the str

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-19 Thread Florian Weimer via Elfutils-devel
* Dmitry V. Levin: > Let's make clear what's going on here. First of all, dwfl-proc-attach.c > does not use dlopen so it doesn't pull it in and doesn't need -ldl. > In regular builds, dwfl-proc-attach.o is linked with ../libdw/libdw.so > which in turn uses dlopen and is already linked with -ldl.

Re: Golang binary dwarf

2021-02-07 Thread Florian Weimer via Elfutils-devel
* Mark Wielaard: > Hi Manoj, > > On Sat, 2021-02-06 at 07:03 +, Manoj Kumar via Elfutils-devel > wrote: >> Hi,Using dyninst, I am trying to access local variables and arguments >> of a function which is part of a go binary.To get local variables, >> dyninst uses libdw to find all the modules.

Re: [musl] Re: [QUESTION] Which fnmatch() functionality does elfutils depend on?

2020-10-27 Thread Florian Weimer via Elfutils-devel
* Rich Felker: > As I stated in my other reply, I'm opposed to that because it does not > admit implementation with the same (very desirable) big-O properties, > and the "extmatch" syntax is not widely known or widely used. The syntax comes from ksh and is used in shell scripts. (bash requires t

Re: [PATCH] Allow elf header to be used when __BEGIN_DECLS and __END_DECLS aren't defined.

2020-10-27 Thread Florian Weimer via Elfutils-devel
* Érico Nogueira via Libc-alpha: > This is mostly an initial PoC, and an additional comment for why this > is needed could be added to the file. > > I accidentally sent the wrong patch a while ago, sorry! extern "C++" does not have any effect for this header because it does not declare anything t