[PATCH] Minor: include for uintptr_t

We have a clang-tidy complaining that uintptr_t is not provided by any directly included header (it's only provided by a transitively included one). * libelf/elf_begin.c: Include Signed-off-by: Paul Pluzhnikov --- libelf/elf_begin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/l

☺ Buildbot (Sourceware): elfutils - build successful (main)

A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/240 Build state: build successful Revision: f84f1cd7e296bf223cb45b5469978d4bea82cec0 Worker: debian-armhf Bui

Re: [PATCH] Fix computations with (potentially) NULL pointer

Hi Paul, On Tue, Nov 14, 2023 at 10:56:50AM -0800, Paul Pluzhnikov wrote: > On Tue, Nov 14, 2023 at 9:55 AM Mark Wielaard wrote: > > > Unfortunately our 32bit buildbots were also very quick to point out an > > issue: https://builder.sourceware.org/buildbot/#/changes/35202 > > Sorry about the br

[patch] debuginfod.8

commit 06e0aacb4b288403bd02a0820dd0f87c7f017a2b (HEAD -> master) Author: Frank Ch. Eigler Date: Tue Nov 14 14:09:40 2023 -0500 doc/debuginfod.8: clarify source file handling Added text about the archive common-prefix heuristic, mentioned the new eu-srcfiles tool, and gave som

Re: [PATCH] Fix computations with (potentially) NULL pointer

On Tue, Nov 14, 2023 at 9:55 AM Mark Wielaard wrote: > Unfortunately our 32bit buildbots were also very quick to point out an > issue: https://builder.sourceware.org/buildbot/#/changes/35202 Sorry about the break. I just tried "./configure "CC=gcc -m32" "CXX=g++ -m32" and that didn't reproduce

Re: [PATCH] libdwfl: Correctly handle corefile non-contiguous segments

Hi Mark, On Tue, Nov 14, 2023 at 9:03 AM Mark Wielaard wrote: > > > A couple caveats should be mentioned. First, start and end addresses > > of reported modules cannot be assumed to contain segments from only > > that module. This has always been the case however. > > There is dwfl_addrmodule/d

Re: [PATCH] elfutils: PR 30991 srcfiles tarball feature

Hi Housam, On Mon, Nov 13, 2023 at 8:49 PM Aaron Merey wrote: > > On Wed, Nov 8, 2023 at 11:49 AM Housam Alamour wrote: > > +/* Read the file contents and write it to the zip file */ > > +fd = open(file_path.c_str(), O_RDONLY); > > +if (!fd) > > +{ > > + cerr << "Error: Fail

Re: [PATCH] Fix computations with (potentially) NULL pointer

Hi Paul, On Tue, 2023-11-14 at 09:04 -0800, Paul Pluzhnikov wrote: > On Tue, Nov 14, 2023 at 8:57 AM Mark Wielaard wrote: > > Looks good. Applied. > > Thanks! > > Appreciate the speedy reviews. Unfortunately our 32bit buildbots were also very quick to point out an issue: https://builder.source

☠ Buildbot (Sourceware): elfutils - failed compile (failure) (main)

A new failure has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/239 Build state: failed compile (failure) Revision: f1a381fb050650a9c15e15d0102967df3f0a6a03 Worker: debian-armh

Re: [PATCH] Fix computations with (potentially) NULL pointer

Mark, On Tue, Nov 14, 2023 at 8:57 AM Mark Wielaard wrote: > I am slightly surprised our testsuite didn't catch this. We do have -- > enable-sanitize-undefined which does build everything with -- > sanitize=undefined. Which should enable -fsanitize=pointer-overflow. > But I just tried (with gcc)

Re: [PATCH] Fix computations with (potentially) NULL pointer

Hi Paul, On Tue, 2023-11-14 at 08:12 -0800, Paul Pluzhnikov wrote: > On Tue, Nov 14, 2023 at 4:57 AM Mark Wielaard wrote: > > > Urgh, I had no idea NULL + ... was technically undefined behavior. > > ISO/IEC 9899:201x > 6.5.6p8 > > When an expression that has integer type is added to or subtrac

Re: [PATCH] PR28204, debuginfod IMA

Hi - > >\fIima:optimistic\fP Every downloaded file with a known-invalid > >signature is rejected, protecting against some types of corruption. > > I like this wording more. But maybe it would be helpful to split the > patch into one that implements ima:enforcing and another that adds the

Re: [PATCH] Fix computations with (potentially) NULL pointer

Mark, On Tue, Nov 14, 2023 at 4:57 AM Mark Wielaard wrote: > Urgh, I had no idea NULL + ... was technically undefined behavior. ISO/IEC 9899:201x 6.5.6p8 When an expression that has integer type is added to or subtracted from a pointer, the result has the type of the pointer operand. If the po

Re: [PATCH] libelf: Fix possible memory leak in elf_getdata_rawchunk

Hi, On Wed, 2023-11-08 at 13:59 +0100, Mark Wielaard wrote: > If the rawchunk is not properly aligned we'll create a new buffer > that is correctly aligned and put the data in that new buffer with > memcpy or the conversion function. In such cases the rawchunk leaks > because the new buffer is put

Re: [PATCH] libdwfl: Correctly handle corefile non-contiguous segments

Hi Aaron, On Sun, 2023-11-12 at 15:16 -0500, Aaron Merey wrote: > It is possible for segments of different shared libaries to be interleaved > in memory such that the segments of one library are located in between > non-contiguous segments of another library. > > For example, this can be seen wit

Re: [PATCH] Fix computations with (potentially) NULL pointer

Hi Paul, Hi Nafi, On Mon, 2023-11-13 at 22:58 +, Paul Pluzhnikov wrote: > When map_address is NULL, computing map_address+offset is technically > undefined behavior, and triggers Clang/LLVM warning when using > -fsanitize=pointer-overflow. Urgh, I had no idea NULL + ... was technically undefi

[Bug general/29176] run-backtrace-native-biarch.sh seems to fail on Ubuntu Jammy

https://sourceware.org/bugzilla/show_bug.cgi?id=29176 Bill Scherr changed: What|Removed |Added CC||bschnzl at cotse dot net --- Comment #1