Re: [PATCH] Add a --{enable,disable}-progs configure option

2020-10-02 Thread Mark Wielaard
Hi Frank, On Fri, Oct 02, 2020 at 06:25:05PM -0400, Frank Ch. Eigler wrote: > > I understand why you might want this and it seems to do as described. > > > But I am slightly reluctant to apply this because it totally breaks > > make check. How do you check the build is really correct? Would it be

Re: [patch] PR25461 default DEBUGINFOD_URLS

2020-10-02 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > There should be %files entries for the debuginfod-client subpackage. Yeah, added %config for them too. > > +install-data-local: > > + $(INSTALL_DATA) profile.sh -D $(sysconfdir)/profile.d/elfutils.sh > > + $(INSTALL_DATA) profile.csh -D $(sysconfdir)/profile.d/elfutils.csh > > It wou

Re: [patch] PR25461 default DEBUGINFOD_URLS

2020-10-02 Thread Mark Wielaard
Hi Frank, On Thu, Oct 01, 2020 at 05:03:52PM -0400, Frank Ch. Eigler via Elfutils-devel wrote: > To give distros a simple knob to let their userbase enjoy debuginfod > services, we add a --enable-debuginfod-urls[=URLS] to the configury. > This propagates to $DEBUGINFOD_URLS environment variable s

Re: [PATCH] Add a --{enable,disable}-progs configure option

2020-10-02 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I understand why you might want this and it seems to do as described. > But I am slightly reluctant to apply this because it totally breaks > make check. How do you check the build is really correct? Would it be > possible to use a small subset of the testsuite with --disable-progs? Inter

Re: [PATCH] Add a --{enable,disable}-progs configure option

2020-10-02 Thread Mark Wielaard
Hi, On Thu, Oct 01, 2020 at 08:34:47PM +0200, Fabrice Fontaine via Elfutils-devel wrote: > From: Thomas Petazzoni > > Add a --{enable,disable}-progs configuration option to elfutils. This > allows to selectively disable the compilation of the elfutils programs > (in which case only the librarie

Re: [PATCH] readelf: Support showing view pairs in loclists as GNU extension.

2020-10-02 Thread Mark Wielaard
On Mon, Sep 28, 2020 at 09:43:44AM +0200, Mark Wielaard wrote: > View pairs are encoded in .debug_loclists as they are encoded in > .debug_locs sections by the GCC compiler. Scan for DW_AT_GNU_locviews > attributes that point to the view pairs just in front of the actual > location lists. Pushed.