Hi Frank,
On Thu, Oct 01, 2020 at 05:03:52PM -0400, Frank Ch. Eigler via Elfutils-devel
wrote:
> To give distros a simple knob to let their userbase enjoy debuginfod
> services, we add a --enable-debuginfod-urls[=URLS] to the configury.
> This propagates to $DEBUGINFOD_URLS environment variable settings
> in /etc/profile.d/elfutils.{sh,csh} files.
>
> The default is nothing. If simply enabled, the current prototype
> public server is used. If enabled with parameters, the builder/distro
> can specify a default URL search path of their own.
I like this. Some small nitpicks below.
> diff --git a/config/elfutils.spec.in b/config/elfutils.spec.in
> index 37af1b076095..946e27498b2e 100644
> --- a/config/elfutils.spec.in
> +++ b/config/elfutils.spec.in
> @@ -181,7 +181,7 @@ such servers to download those files on demand.
> %setup -q
>
> %build
> -%configure --program-prefix=%{_programprefix} --enable-debuginfod
> +%configure --program-prefix=%{_programprefix} --enable-debuginfod
> +--enable-debuginfod-urls
> make -s %{?_smp_mflags}
There should be %files entries for the debuginfod-client subpackage.
> +install-data-local:
> + $(INSTALL_DATA) profile.sh -D $(sysconfdir)/profile.d/elfutils.sh
> + $(INSTALL_DATA) profile.csh -D $(sysconfdir)/profile.d/elfutils.csh
It would be more clear to name them debuginfod.{sh,csh} or
debuginfod_urls.{sh,csh}.
Cheers,
Mark
