Re: [PATCH v5 08/12] drm/panfrost: Make re-enabling job interrupts at device reset optional

2025-10-13 Thread Steven Price
the interrupts and another one which unmasks them conditionally. > > Reviewed-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 9 ++--- > drivers/gpu/drm/panfrost/panfrost_device.h |

Re: [PATCH v5 11/12] drm/panfrost: Rename panfrost_job functions to reflect real role

2025-10-13 Thread Steven Price
ot_jm_* instead. > > Reviewed-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 14 +++ > drivers/gpu/drm/panfrost/panfrost_drv.c| 4 +- > drivers/gpu/drm/panfrost/panfrost_job.c|

Re: [PATCH v2 08/13] drm/panthor: Bump the driver version to 1.6

2025-10-10 Thread Steven Price
Signed-off-by: Boris Brezillon Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c > b/drivers/gpu/drm/panthor/panthor_drv.c > index af

Re: [PATCH v2 06/13] drm/panthor: Add an ioctl to query BO flags

2025-10-10 Thread Steven Price
nel-based syncs > instead of userland cache flushes). > > v2: > - New commit > > Signed-off-by: Boris Brezillon Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 24 +++ > include/uapi/drm/panthor_drm.h| 57 +++

Re: [PATCH v5 10/12] drm/panfrost: Remove unused device property

2025-10-09 Thread Steven Price
On 07/10/2025 16:01, Adrián Larumbe wrote: > The as_in_use_mask device state variable is no longer in use. > > Reviewed-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_device.h | 1 - > dri

Re: [PATCH] drm/panthor: Ensure MCU is disabled on suspend

2025-10-09 Thread Steven Price
On 09/10/2025 12:45, Boris Brezillon wrote: > On Thu, 9 Oct 2025 11:29:14 +0100 > Steven Price wrote: > >> On 08/10/2025 11:51, Ketil Johnsen wrote: >>> Currently the Panthor driver needs the GPU to be powered down >>> between suspend and resume. If this is n

Re: [PATCH] drm/panfrost: Name scheduler queues after their job slots

2025-10-08 Thread Steven Price
ts. > > Signed-off-by: Adrián Larumbe Two minor things below, but with those fixed: Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 6 -- > drivers/gpu/drm/panfrost/panfrost_job.c | 6 +- > drivers/gpu/drm/panfrost/panfrost_job.h | 2 +

Re: [PATCH 00/10] drm/panthor: minor AS_CONTROL clean up

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > This series performs minor AS_CONTROL clean up. > > Patch 1 to 5 rename and document AS_CONTROL config functions. There is > no functional change. All functions are now prefixed by mmu_hw_ for > consistency. All of them also expect locking. I choose not to s

Re: [PATCH 07/10] drm/panthor: remove unnecessary mmu_hw_wait_ready calls

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > No need to call mmu_hw_wait_ready after panthor_gpu_flush_caches or > before returning from mmu_hw_flush_caches. Why is there no need? If we attempt to send a command when the hardware is busy then the command will be dropped (so the cache flush won't happen

Re: [PATCH 02/10] drm/panthor: rename and document lock_region

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > Rename lock_region to mmu_hw_cmd_lock. > > Signed-off-by: Chia-I Wu > --- > drivers/gpu/drm/panthor/panthor_mmu.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c > b/drivers/

Re: [PATCH 04/10] drm/panthor: add mmu_hw_cmd_update

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > Add a simple helper for the UPDATE command. Why? There's only two call sites, so we're not saving much (indeed the diffstat shows we've got over twice as many lines)... > > Signed-off-by: Chia-I Wu > --- > drivers/gpu/drm/panthor/panthor_mmu.c | 33 +

Re: [PATCH 05/10] drm/panthor: rename and document mmu_hw_do_operation_locked

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > Rename mmu_hw_do_operation_locked to mmu_hw_flush_caches. This is confusing, you've renamed the _locked variant and left the wrapper mmu_hw_do_operation() with the old name. I agree "do operation" isn't a great name, although "flush caches" sounds to me lik

Re: [PATCH 06/10] drm/panthor: remove write_cmd

2025-10-02 Thread Steven Price
On 16/09/2025 22:08, Chia-I Wu wrote: > Call mmu_hw_wait_ready explicitly instead. You're missing the why here again. I can see the intention from the following patch is to remove some "wait ready" calls that you think are unnecessary. But you need to put that in the description of this patch. Ot

Re: [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop

2025-10-02 Thread Steven Price
On 28/09/2025 10:03, Rain Yang wrote: > From: Rain Yang > > The regulator is optional, skip the setup instead of returning an > error if it is not present > > Signed-off-by: Rain Yang Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_devfreq.c | 3

Re: [PATCH] drm/panthor: Defer scheduler entitiy destruction to queue release

2025-09-25 Thread Steven Price
On 19/09/2025 17:43, Adrián Larumbe wrote: > Commit de8548813824 ("drm/panthor: Add the scheduler logical block") > handled destruction of a group's queues' drm scheduler entities early > into the group destruction procedure. > > However, that races with the group submit ioctl, because by the time

Re: [PATCH] drm/panthor: Defer scheduler entitiy destruction to queue release

2025-09-24 Thread Steven Price
cheduler core as a situation that should never occur. > > Fix by deferring drm scheduler entity destruction to queue release time. > > Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") > Signed-off-by: Adrián Larumbe Looks good - I can't figure out why

Re: [PATCH v2 3/4] drm/panfrost: Expose JM context IOCTLs to UM

2025-09-20 Thread Steven Price
On 04/09/2025 01:08, Adrián Larumbe wrote: > From: Boris Brezillon > > Minor revision of the driver must be bumped because this expands the > uAPI. On top of that, let user know the available priorities so that > they can create contexts with legal priority values. > > Signed-off-by: Boris Brezi

Re: [PATCH] drm/panfrost: Bump the minor version number

2025-09-19 Thread Steven Price
On 19/09/2025 09:07, Steven Price wrote: > Commit a017f7b86051 ("drm/panfrost: Expose JM context IOCTLs to UM") > added new ioctls to the driver and was meant to bump the version number. > However it actually only added a comment and didn't change the exposed > version

Re: [PATCH v2 2/4] drm/panfrost: Introduce JM contexts for manging job resources

2025-09-19 Thread Steven Price
On 04/09/2025 01:08, Adrián Larumbe wrote: > From: Boris Brezillon > > A JM context describes GPU HW resourdce allocation for the jobs bound to > it. At the time of writing this, it only holds the JS and queue > scheduler priorities. > > When a context is created, all the scheduler entities crea

[PATCH] drm/panfrost: Bump the minor version number

2025-09-19 Thread Steven Price
comment. Fixes: a017f7b86051 ("drm/panfrost: Expose JM context IOCTLs to UM") Reviewed-by: Boris Brezillon Signed-off-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b

Re: [PATCH v2] drm/panthor: always set fence errors on CS_FAULT

2025-09-18 Thread Steven Price
On 28/08/2025 21:04, Chia-I Wu wrote: > It is unclear why fence errors were set only for CS_INHERIT_FAULT. > Downstream driver also does not treat CS_INHERIT_FAULT specially. > Remove the check. > > Signed-off-by: Chia-I Wu > Reviewed-by: Boris Brezillon Reviewed-by: Steven

Re: [PATCH v4 0/4] Introduce Panfrost JM contexts

2025-09-18 Thread Steven Price
On 17/09/2025 20:18, Adrián Larumbe wrote: > This patch series brings the notion of JM contexts into Panfrost. > UM will be able to create contexts, get a handle for them and attach > it to a job submission. Contexts describe basic HW resource assignment > to jobs, but at the moment that includes p

Re: [PATCH v4 2/4] drm/panfrost: Introduce JM contexts for manging job resources

2025-09-18 Thread Steven Price
> Until context creation and destruction are exposed to UM, all issued > jobs shall be bound to the default Panfrost file context, which has > medium priority. > > Signed-off-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- >

Re: [PATCH v3 3/4] drm/panfrost: Expose JM context IOCTLs to UM

2025-09-17 Thread Steven Price
Signed-off-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 36 ++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfr

Re: [PATCH v3 4/4] drm/panfrost: Display list of device JM contexts over debugfs

2025-09-17 Thread Steven Price
> > For every context, show the DRM scheduler priority value of all of its > scheduling entities. > > Signed-off-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 96 +++

Re: [PATCH v3 2/4] drm/panfrost: Introduce JM contexts for manging job resources

2025-09-17 Thread Steven Price
On 12/09/2025 14:19, Adrián Larumbe wrote: > From: Boris Brezillon > > A JM context describes user-requested priorities for the JM queues. > > Context creation leads to the initialization of scheduling entities of > the same priority for all the device's job slots. > > Until context creation an

Re: [PATCH i-g-t v2 0/3] Add initial Panthor tests

2025-09-15 Thread Steven Price
he driver in the cover letter and patch 1. > - Improved the commit message for patch 1. > Link to v1: > https://lore.kernel.org/dri-devel/20250828130402.2549948-1-daniel.alme...@collabora.com/ Looks good to me, and all the tests now pass (using Panthor) on my Rock5B. Tested-by: Steven Pr

Re: [PATCH v3] drm/panthor: assign unique names to queues

2025-09-12 Thread Steven Price
On 02/09/2025 21:06, Chia-I Wu wrote: > Userspace relies on the ring field of gpu_scheduler tracepoints to > identify a drm_gpu_scheduler. The value of the ring field is taken from > sched->name. > > Because we typically have multiple schedulers running in parallel in > each process, assign uniqu

Re: [PATCH RFC 08/10] drm/panthor: devfreq: expose get_dev_status and make it more generic

2025-09-11 Thread Steven Price
On 05/09/2025 11:23, Nicolas Frattaroli wrote: > The only device-specific part of panthor's get_dev_status devfreq > callback is getting the clock frequency. All the other logic surrounding > what it does may be useful for other devfreq implementations however. > > Expose it in the panthor_devfreq

Re: [PATCH v2 2/4] drm/panfrost: Introduce JM contexts for manging job resources

2025-09-11 Thread Steven Price
On 10/09/2025 17:50, Boris Brezillon wrote: > On Wed, 10 Sep 2025 16:56:43 +0100 > Steven Price wrote: > >> On 10/09/2025 16:52, Boris Brezillon wrote: >>> On Wed, 10 Sep 2025 16:42:32 +0100 >>> Steven Price wrote: >>> >>>&

Re: [PATCH v2 2/4] drm/panfrost: Introduce JM contexts for manging job resources

2025-09-10 Thread Steven Price
On 10/09/2025 16:52, Boris Brezillon wrote: > On Wed, 10 Sep 2025 16:42:32 +0100 > Steven Price wrote: > >>> +int panfrost_jm_ctx_create(struct drm_file *file, >>> + struct drm_panfrost_jm_ctx_create *args) >>> +{ >>> + struct

Re: [PATCH v2 4/4] drm/panfrost: Display list of device JM contexts over debugfs

2025-09-10 Thread Steven Price
On 04/09/2025 01:08, Adrián Larumbe wrote: > From: Boris Brezillon > > For DebugFS builds, create a filesystem knob that, for every single open > file of the Panfrost DRM device, shows its command name information and > PID (when applicable), and all of its existing JM contexts. > > For every co

Re: [PATCH v2 1/4] drm/panfrost: Introduce uAPI for JM context creation

2025-09-10 Thread Steven Price
d > destruction ioctls. > > Signed-off-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > include/uapi/drm/panfrost_drm.h | 50 + > 1 file changed, 50 insertions(+) > > diff --git a/include/

Re: [PATCH RFC 06/10] drm/panthor: call into devfreq for current frequency

2025-09-10 Thread Steven Price
t_cur_freq operation, and expose it through a > helper function to the rest of panthor. > > Signed-off-by: Nicolas Frattaroli Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_devfreq.c | 33 > +++ > drivers/gpu/drm/panthor/pantho

Re: [PATCH RFC 09/10] drm/panthor: devfreq: add pluggable devfreq providers

2025-09-10 Thread Steven Price
On 05/09/2025 11:23, Nicolas Frattaroli wrote: > On some devices, devfreq is not controlled directly by DT OPPs and the > common clock framework, but through an external devfreq driver. To > permit this type of usage, add the concept of devfreq providers. > > Devfreq providers for panthor register

Re: [PATCH RFC 07/10] drm/panthor: move panthor_devfreq struct to header

2025-09-10 Thread Steven Price
coming MediaTek > MFG devfreq can use it as well. > > Signed-off-by: Nicolas Frattaroli Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_devfreq.c | 32 --- > drivers/gpu/drm/panthor/panthor_devfreq.h | 36 > ++

Re: [PATCH v2] drm/panthor: validate group queue count

2025-09-04 Thread Steven Price
On 03/09/2025 20:21, Chia-I Wu wrote: > A panthor group can have at most MAX_CS_PER_CSG panthor queues. > > Fixes: 4bdca11507928 ("drm/panthor: Add the driver frontend block") > Signed-off-by: Chia-I Wu > Reviewed-by: Boris Brezillon # v1 > Reviewed-by: Steven Pric

Re: [PATCH v3] drm/panthor: assign unique names to queues

2025-09-03 Thread Steven Price
each process, assign unique names to schedulers such that userspace can > distinguish them. > > Signed-off-by: Chia-I Wu Reviewed-by: Steven Price > > --- > > v2: > - include drm_client_id in the name to be truly unique > - remove unnecessary NULL in drm_sched_init_a

Re: [PATCH] drm/panthor: validate group queue count

2025-09-03 Thread Steven Price
up_args->queues.count > MAX_CS_PER_CSG) > + return -EINVAL; > + I think this check would be better moved up to panthor_ioctl_group_create() (where we already have a zero check). But either way: Reviewed-by: Steven Price Thanks, Steve > group = kzalloc(sizeof(*group), GFP_KERNEL); > if (!group) > return -ENOMEM;

Re: [PATCH] drm/panthor: check bo offset alignment in vm bind

2025-09-03 Thread Steven Price
On 28/08/2025 21:01, Chia-I Wu wrote: > Fail early from panthor_vm_bind_prepare_op_ctx instead of late from > ops->map_pages. > > Signed-off-by: Chia-I Wu > Reviewed-by: Boris Brezillon Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve &

Re: [PATCH 2/5] drm/panfrost: Introduce uAPI for JM context creation

2025-09-01 Thread Steven Price
Hi Boris, On 01/09/2025 13:14, Boris Brezillon wrote: > Hi Steve, > > On Mon, 1 Sep 2025 11:52:02 +0100 > Steven Price wrote: > >> On 28/08/2025 03:34, Adrián Larumbe wrote: >>> From: Boris Brezillon >>> >>> The new uAPI lets user space query

Re: [PATCH 2/5] drm/panfrost: Introduce uAPI for JM context creation

2025-09-01 Thread Steven Price
On 01/09/2025 13:08, Adrián Larumbe wrote: > Hi Steven, > > On 01.09.2025 11:52, Steven Price wrote: >> >> On 28/08/2025 03:34, Adrián Larumbe wrote: >>> From: Boris Brezillon >>> >>> The new uAPI lets user space query the KM driver for the avail

Re: [PATCH 2/5] drm/panfrost: Introduce uAPI for JM context creation

2025-09-01 Thread Steven Price
On 28/08/2025 03:34, Adrián Larumbe wrote: > From: Boris Brezillon > > The new uAPI lets user space query the KM driver for the available > priorities a job can be given at submit time. These are managed through > the notion of a context, which besides a priority, codifies the list > of L2 caches

Re: [PATCH 0/2] drm/panthor: add custom ASN hash support

2025-08-29 Thread Steven Price
On 28/08/2025 21:18, Chia-I Wu wrote: > Some socs such as mt8196 require custom ASN hash. I don't know the full details of this, but I'm puzzled by the "require" here. AIUI the "custom ASN hash support" (or L2C_SLICE_HASH as it was renamed) affects the efficiency of the L2 caches in the GPU. It b

Re: [PATCH 2/2] drm/panthor: add asn-hash support

2025-08-29 Thread Steven Price
On 28/08/2025 21:18, Chia-I Wu wrote: > Parse asn-hash and enable custom ASN hash when the property exists. > This is required on some socs such as mt8196. > > Signed-off-by: Chia-I Wu This mostly looks fine, although there is a question of naming. This was renamed in a later version of the arch

Re: [PATCH] drm/panthor: assign unique names to queues

2025-08-29 Thread Steven Price
each process, assign unique names to schedulers such that userspace can > distinguish them. > > Signed-off-by: Chia-I Wu One nit below, but otherwise: Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 32 ++--- > 1 file changed, 23

Re: [PATCH i-g-t 4/4] tests/panthor: add panthor tests

2025-08-28 Thread Steven Price
Hi Daniel, A couple of errors that I hit when I tested this are below. On 28/08/2025 14:04, Daniel Almeida wrote: > Add an initial test suit covering query device properties, allocating > memory, binding and unbinding VA ranges through VM_BIND and submitting a > simple piece of work through GROUP

Re: [PATCH i-g-t 1/4] lib: add support for opening Panthor devices

2025-08-28 Thread Steven Price
On 28/08/2025 14:03, Daniel Almeida wrote: > We will be adding tests for Panthor in a subsequent patch, so first add > the ability to open the device. > > Signed-off-by: Daniel Almeida There's also chipset_to_str() which should be updated to return the correct name. Although I think that only ma

Re: [PATCH v2] drm/panthor: Simplify mmu_hw_do_operation_locked

2025-08-28 Thread Steven Price
On 15/08/2025 14:42, Steven Price wrote: > The only callers to mmu_hw_do_operation_locked() pass an 'op' of either > AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This means the code paths > after that are dead. Removing those paths means the > mmu_hw_do_flush_on_gpu_ctrl() f

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-08-21 Thread Steven Price
On 21/08/2025 12:51, Boris Brezillon wrote: > On Wed, 16 Jul 2025 16:43:24 +0100 > Steven Price wrote: [...] >> Although in general I'm a bit wary of relying on the whole lock region >> feature - previous GPUs have an errata. But maybe I'm being over >> cautious

Re: [PATCH 19/80] drm/panfrost: Remove redundant pm_runtime_mark_last_busy() calls

2025-08-15 Thread Steven Price
On 04/07/2025 10:18, Steven Price wrote: > On 04/07/2025 08:54, Sakari Ailus wrote: >> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), >> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call >> to pm_runtime_mark_last_busy(). Remove the n

Re: [PATCH v2] drm/panthor: Simplify mmu_hw_do_operation_locked

2025-08-15 Thread Steven Price
On 15/08/2025 15:01, Karunika Choo wrote: > On 15/08/2025 14:42, Steven Price wrote: >> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either >> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This means the code paths >> after that are dead.

[PATCH v2] drm/panthor: Simplify mmu_hw_do_operation_locked

2025-08-15 Thread Steven Price
y having a switch statement for the type of 'op' (warning if we get an unexpected value) and removing the dead cases. Suggested-by: Daniel Stone Signed-off-by: Steven Price --- Changes from v1: * As well as removing dead code, inline mmu_hw_do_flush_on_gpu_ctrl drivers/gpu/drm/pantho

Re: [PATCH] drm/panthor: Remove dead code in mmu_hw_do_operation_locked

2025-08-15 Thread Steven Price
On 15/08/2025 12:17, Daniel Stone wrote: > Hi Steven, > > On Fri, 15 Aug 2025 at 11:25, Steven Price wrote: >> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either >> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. So remove the code paths >> t

[PATCH] drm/panthor: Remove dead code in mmu_hw_do_operation_locked

2025-08-15 Thread Steven Price
ned-off-by: Steven Price --- drivers/gpu/drm/panthor/panthor_mmu.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c index 367c89aca558..b16f44aec725 100644 --- a/drivers/gpu/drm/panthor/pan

Re: [PATCH v9 6/7] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-08-15 Thread Steven Price
On 14/08/2025 23:58, Liviu Dudau wrote: > On Fri, Aug 08, 2025 at 11:50:27AM +0100, Daniel Stone wrote: >> Hi Karunika, >> >> >> On Thu, 7 Aug 2025 at 17:27, Karunika Choo wrote: >>> @@ -585,6 +615,9 @@ static int mmu_hw_do_operation_locked(struct >>> panthor_device *ptdev, int as_nr, >>>

Re: [PATCH v9 5/7] drm/panthor: Serialize GPU cache flush operations

2025-08-15 Thread Steven Price
flushes are completed instead of dropped. > > Reviewed-by: Liviu Dudau > Co-developed-by: Dennis Tsiang > Signed-off-by: Dennis Tsiang > Signed-off-by: Karunika Choo Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_gpu.c | 7 +++ > 1 file change

Re: [PATCH v1] drm/panthor: Serialize GPU cache flush operations

2025-07-31 Thread Steven Price
On 31/07/2025 13:48, Karunika Choo wrote: > On 31/07/2025 11:57, Steven Price wrote: >> On 30/07/2025 18:43, Karunika Choo wrote: >>> In certain scenarios, it is possible for multiple cache flushes to be >>> requested before the previous one completes

Re: [PATCH v1] drm/panthor: Serialize GPU cache flush operations

2025-07-31 Thread Steven Price
On 30/07/2025 18:43, Karunika Choo wrote: > In certain scenarios, it is possible for multiple cache flushes to be > requested before the previous one completes. This patch introduces the > cache_flush_lock mutex to serialize these operations and ensure that > any requested cache flushes are complet

Re: [PATCH v2 01/19] gpu: nova-core: register: minor grammar and spelling fixes

2025-07-30 Thread Steven Price
On 29/07/2025 14:47, Alexandre Courbot wrote: > On Mon Jul 28, 2025 at 10:25 PM JST, Steven Price wrote: >> On 28/07/2025 12:43, Alexandre Courbot wrote: >>> On Mon Jul 28, 2025 at 4:51 PM JST, Steven Price wrote: >>>> On 28/07/2025 05:59, Alexandre Courbot wrote: &

Re: [PATCH v2 01/19] gpu: nova-core: register: minor grammar and spelling fixes

2025-07-28 Thread Steven Price
On 28/07/2025 12:43, Alexandre Courbot wrote: > On Mon Jul 28, 2025 at 4:51 PM JST, Steven Price wrote: >> On 28/07/2025 05:59, Alexandre Courbot wrote: >>> Hi Daniel, thanks for the review! >>> >>> On Sat Jul 26, 2025 at 1:14 AM JST, Daniel Almeida wrote:

Re: [PATCH 1/9] drm/panthor: add devcoredump support

2025-07-28 Thread Steven Price
On 20/07/2025 01:01, Chia-I Wu wrote: > Create a devcoredump on any faulty or fatal event. The coredump data is > in YAML format for readability and flexibility. > > Only panthor_group state is captured for now. > > Signed-off-by: Chia-I Wu > --- > drivers/gpu/drm/panthor/Makefile |

Re: [PATCH v2 01/19] gpu: nova-core: register: minor grammar and spelling fixes

2025-07-28 Thread Steven Price
this module provides an intuitive and >>> readable syntax for defining a >>> +//! dedicated type for each register. Each such type comes with its own >>> field accessors that can >>> +//! return an error if a field's value is invalid. >>> >&

Re: [PATCH v3 0/3] panthor: print task pid and comm on gpu errors

2025-07-24 Thread Steven Price
On 18/07/2025 07:38, Chia-I Wu wrote: > This series saves task pid and comm in panthor_group and prints task pid and > comm on gpu errors. > > v3: fix new kerneldoc warnings > v2: save the task info in panthor_group on panthor_group_create, rather than > in panthor_file on panthor_open, becaus

Re: [PATCH v8 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-24 Thread Steven Price
On 24/07/2025 13:42, Karunika Choo wrote: > This patch adds firmware binary and GPU model naming support for > Mali-Gx20 and Mali-Gx25 GPUs. > > Signed-off-by: Karunika Choo Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ > drivers/gpu/drm

Re: [PATCH v7 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-24 Thread Steven Price
On 24/07/2025 10:26, Karunika Choo wrote: > This patch adds firmware binary and GPU model naming support for > Mali-Gx20 and Mali-Gx25 GPUs. > > The GPU_COHERENCY_FEATURES macros are slightly reworked as the > assumption that FEATURE = BIT(PROTOCOL) no longer holds with the > introduction of the S

Re: [PATCH v7 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-24 Thread Steven Price
s. > > Mali-Gx10 and Mali-Gx15 GPUs also has support for the FLUSH_CACHES > command and will also use this by default going forward. > > Reviewed-by: Chia-I Wu > Reviewed-by: Liviu Dudau > Signed-off-by: Karunika Choo Reviewed-by: Steven Price > --- > dri

Re: [PATCH v7 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-24 Thread Steven Price
ewed-by: Liviu Dudau > Signed-off-by: Karunika Choo Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_fw.c | 1 + > drivers/gpu/drm/panthor/panthor_hw.c | 15 +++ > drivers/gpu/drm/panthor/panthor_regs.h | 3 +++ > include/uapi/drm/panthor_drm.h

Re: [PATCH v7 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-24 Thread Steven Price
ng of the function to > accommodate naming differences based on supported GPU features. > > Reviewed-by: Chia-I Wu > Reviewed-by: Liviu Dudau > Signed-off-by: Karunika Choo Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_hw.c | 61 --

Re: [PATCH v7 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-24 Thread Steven Price
; case GPU_PROD_ID_MAKE(10, 7): > return "Mali-G610"; > + case GPU_PROD_ID_MAKE(10, 3): > + return "Mali-G510"; > + case GPU_PROD_ID_MAKE(10, 4): > + return "Mali-G310"; Chia-I Wu pointed out these don't appear to have any logical ordering. I'd suggest ordering by arch major/product major. With that fixed: Reviewed-by: Steven Price > } > > return "(Unknown Mali GPU)";

Re: [PATCH v7 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-24 Thread Steven Price
-I Wu > Reviewed-by: Liviu Dudau > Signed-off-by: Karunika Choo One minor nit (see below), but otherwise: Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/Makefile | 1 + > drivers/gpu/drm/panthor/panthor_device.c | 5 + > drivers/gpu/drm/panthor/pantho

Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2025-07-18 Thread Steven Price
On 13/11/2024 21:03, Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error cases jump forward t

Re: [PATCH v2 3/3] panthor: dump task pid and comm on gpu errors

2025-07-17 Thread Steven Price
On 13/07/2025 04:08, Chia-I Wu wrote: > It is useful to know which tasks cause gpu errors. > > Signed-off-by: Chia-I Wu Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 24 +++- > 1 file changed, 19 insertions(+), 5 deletions(

Re: [PATCH v2 2/3] panthor: save task pid and comm in panthor_group

2025-07-17 Thread Steven Price
f-by: Chia-I Wu One nit below, but with that fixed: Reviewed-by: Steven Price > > --- > v2: save to panthor_group on panthor_group_create rather than to > panthor_file on panthor_open > --- > drivers/gpu/drm/panthor/panthor_sched.c | 19 +++ > 1 file c

Re: [PATCH] drm/panfrost: Fix leak when free gem object

2025-07-17 Thread Steven Price
On 10/07/2025 04:05, lihongtao wrote: > obj->mappings.lock should be destroyed when free > panfrost gem object in panfrost_gem_free_object. mutex_destroy() doesn't actually release any resources. It is purely a debugging feature (if CONFIG_DEBUG_MUTEXES is disabled then it is compiled away complet

Re: [PATCH v4 7/7] drm/panthor: Add support for repeated mappings

2025-07-16 Thread Steven Price
On 15/07/2025 16:17, Caterina Shablia wrote: > El viernes, 11 de julio de 2025 16:03:26 (hora de verano de Europa central), > Steven Price escribió: >> On 07/07/2025 18:04, Caterina Shablia wrote: >>> From: Boris Brezillon >>> >>> This allows us to

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-07-16 Thread Steven Price
On 15/07/2025 17:09, Caterina Shablia wrote: > El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central), > Caterina Shablia escribió: >> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central), >> Steven Price escribió: >>> On

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-07-16 Thread Steven Price
On 15/07/2025 16:33, Caterina Shablia wrote: > El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central), > Caterina Shablia escribió: >> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central), >> Steven Price escribió: >>> On

Re: [PATCH] drm/panthor: Remove dead VM flushing code

2025-07-14 Thread Steven Price
On 11/07/2025 16:45, Adrián Larumbe wrote: > Commit ec62d37d2c0d("drm/panthor: Fix the fast-reset logic") did away > with the only reference to panthor_vm_flush_all(), so let's get rid > of the orphaned definition. > > Signed-off-by: Adrián Larumbe Reviewed-by: St

Re: [PATCH v4 7/7] drm/panthor: Add support for repeated mappings

2025-07-11 Thread Steven Price
On 07/07/2025 18:04, Caterina Shablia wrote: > From: Boris Brezillon > > This allows us to optimize mapping of a relatively small > portion of a BO over and over in a large VA range, which > is useful to support Vulkan sparse bindings in an efficient > way. > > Signed-off-by: Boris Brezillon >

Re: [PATCH v4 2/7] drm/gpuvm: Kill drm_gpuva_init()

2025-07-11 Thread Steven Price
On 07/07/2025 18:04, Caterina Shablia wrote: > From: Boris Brezillon > > drm_gpuva_init() only has one internal user, and given we are about to > add new optional fields, it only add maintenance burden for no real > benefit, so let's kill the thing now. Commit 111fdd2198e6 ("drm/msm: drm_gpuvm c

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-07-11 Thread Steven Price
On 07/07/2025 18:04, Caterina Shablia wrote: > From: Boris Brezillon > > Move the lock/flush_mem operations around the gpuvm_sm_map() calls so > we can implement true atomic page updates, where any access in the > locked range done by the GPU has to wait for the page table updates > to land befor

Re: [PATCH] drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code

2025-07-10 Thread Steven Price
On 10/07/2025 09:53, Simona Vetter wrote: > On Wed, Jul 09, 2025 at 04:48:21PM +0100, Steven Price wrote: >> On 09/07/2025 14:52, Simona Vetter wrote: >>> The object is potentially already gone after the drm_gem_object_put(). >>> In general the object should be fully

Re: [PATCH] drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code

2025-07-09 Thread Steven Price
of DRM GEM objects > over DebugFS") > Cc: Adrián Larumbe > Cc: Boris Brezillon > Cc: Steven Price > Cc: Liviu Dudau > Reviewed-by: Liviu Dudau > Signed-off-by: Simona Vetter > Signed-off-by: Simona Vetter Reviewed-by: Steven Price Although a nit on the email

Re: [PATCH] drm/panfrost: Fix scheduler workqueue bug

2025-07-09 Thread Steven Price
hed_init() params") > Reported-by: Tvrtko Ursulin > Closes: > https://lore.kernel.org/dri-devel/b5d0921c-7cbf-4d55-aa47-c35cd7861...@igalia.com/ > Signed-off-by: Philipp Stanner Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > 1 file chang

Re: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls

2025-07-04 Thread Steven Price
el-simple.c | 2 -- > drivers/gpu/drm/panthor/panthor_sched.c| 2 -- Panthor changes are: Reviewed-by: Steven Price Thanks, Steve > drivers/gpu/drm/tegra/submit.c | 1 - > drivers/gpu/drm/tidss/tidss_drv.c | 2 -- > driv

Re: [PATCH 19/80] drm/panfrost: Remove redundant pm_runtime_mark_last_busy() calls

2025-07-04 Thread Steven Price
rk_last_busy(). > > Signed-off-by: Sakari Ailus Reviewed-by: Steven Price But this can't be merged via drm-misc until the PM changes have hit Linus' tree and been backmerged to drm-misc-next. Thanks, Steve > --- > The cover letter of the set can be found here > https://lore.kerne

Re: [PATCH] drm/panthor: Wait for _READY register when powering on

2025-06-30 Thread Steven Price
On 30/06/2025 15:07, Steven Price wrote: > panthor_gpu_block_power_on() takes a register offset (rdy_reg) for the > purpose of waiting for the power transition to complete. However, a > copy/paste error converting to use the new 64 register functions > switched it to using the

Re: [PATCH] Introduce Tyr

2025-06-30 Thread Steven Price
Hi Daniel, On 30/06/2025 15:56, Daniel Almeida wrote: > Hi Steven, > >> On 30 Jun 2025, at 07:11, Steven Price wrote: >> >> Hi Daniel, >> >> My Rust is still quite weak, so I'll just review the GPU-specific parts. >> Please CC me on future posts.

[PATCH] drm/panthor: Wait for _READY register when powering on

2025-06-30 Thread Steven Price
register. Fixes: 4d230aa209ed ("drm/panthor: Add 64-bit and poll register accessors") Signed-off-by: Steven Price --- drivers/gpu/drm/panthor/panthor_gpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/d

Re: [PATCH] Introduce Tyr

2025-06-30 Thread Steven Price
Hi Daniel, My Rust is still quite weak, so I'll just review the GPU-specific parts. Please CC me on future posts. On 27/06/2025 23:34, Daniel Almeida wrote: > Add a Rust driver for ARM Mali CSF-based GPUs. It is a port of Panthor > and therefore exposes Panthor's uAPI and name to userspace, and t

Re: [PATCH v4 0/7] Add GPU specific initialization framework to support new Mali GPUs

2025-06-23 Thread Steven Price
Hi Karunika, On 02/06/2025 15:32, Karunika Choo wrote: > This patch series introduces a GPU HW abstraction to Panthor, to enable > support for new Mali GPUs. > > Key changes: > - Addition of GPU-specific initialization framework to standardize and > streamline support new GPUs. > - Support for

Re: [PATCH v4 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-06-23 Thread Steven Price
On 02/06/2025 15:32, Karunika Choo wrote: > As the FLUSH_MEM and FLUSH_PT commands are deprecated in GPUs from > Mali-Gx20 onwards, this patch adds support for performing cache > maintenance via the FLUSH_CACHES command in GPU_CONTROL, in place of NIT: s/GPU_CONTROL/GPU_COMMAND/ (also in the subje

Re: [PATCH 1/4] panthor: set owner field for driver fops

2025-06-23 Thread Steven Price
On 21/06/2025 00:50, Chia-I Wu wrote: > It allows us to get rid of manual try_module_get / module_put. > > Signed-off-by: Chia-I Wu Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(

Re: [PATCH v4 4/7] drm/panthor: Introduce sampling sessions to handle userspace clients

2025-06-20 Thread Steven Price
Hi Lukas, I was going to try testing this out, but it doesn't look functional. See below. On 16/05/2025 16:49, Lukas Zapolskas wrote: [...] > diff --git a/drivers/gpu/drm/panthor/panthor_perf.c > b/drivers/gpu/drm/panthor/panthor_perf.c > index 9365ce9fed04..15fa533731f3 100644 > --- a/drivers/g

Re: [PATCH v6 0/5] Add Mali GPU support for Mediatek MT8370 SoC

2025-06-20 Thread Steven Price
All 5 patches push to drm-misc-next. Thanks, Steve On 09/05/2025 11:12, Louis-Alexis Eyraud wrote: > This patchset adds the support of the ARM Mali G57 MC2 GPU (Valhall-JM, > dual core), integrated in the Mediatek MT8370 SoC, to the panfrost > driver and to the mt8370.dtsi include file. > > Sinc

Re: [PATCH v5 2/2] drm/panthor: Make the timeout per-queue instead of per-job

2025-06-12 Thread Steven Price
thor: Add the scheduler logical block") > --- > Signed-off-by: Ashley Smith Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 233 +--- > 1 file changed, 167 insertions(+), 66 deletions(-) > > diff --git a/drivers/gpu/drm/pa

Re: [PATCH v5 1/2] drm/panthor: Reset queue slots if termination fails

2025-06-12 Thread Steven Price
t terminated correctly. > > Signed-off-by: Ashley Smith > Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) &

Re: [PATCH v3 1/5] drm/panfrost: Add BO labelling to Panfrost

2025-06-02 Thread Steven Price
ugh a new ioctl(). > > Signed-off-by: Adrián Larumbe > Reviewed-by: Steven Price All 5 patches pushed to drm-misc. Thanks, Steve

Re: [PATCH v3 5/5] drm/panfrost: Fix panfrost device variable name in devfreq

2025-05-21 Thread Steven Price
conventions. > > Signed-off-by: Adrián Larumbe > Fixes: 64111a0e22a9 ("drm/panfrost: Fix incorrect updating of current device > frequency") Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 4 ++-- > 1 file changed, 2 inserti

  1   2   3   4   5   6   7   8   9   10   >