Fellow Report - July 23, 2016

2016-07-25 Thread Tim Graham
I enjoyed meeting many people from the community at DjangoCon US last week. We had about 20-30 people sprinting on Django on Thursday and Friday. Only a couple had contributed to Django before. Triaged --- https://code.djangoproject.com/ticket/26899 - Document why RawSQL requires parame

Re: Proposal: Use HTML5 boolean attribute for checked on checkbox/radio inputs

2016-07-25 Thread Tim Graham
I was wondering if it causes any HTML validation problems for other doctypes? If so, we might document that Django's default HTML rendering targets the HTML5 doctype. On Saturday, July 23, 2016 at 4:21:22 AM UTC-4, Florian Apolloner wrote: > > This should be perfectly fine -- I guess just nobody

Re: GitHub PR status within Trac

2016-07-25 Thread Tim Graham
If the goal is to provide a list of issues suitable for new contributors, I think a curated list of tickets is likely more useful than trying to automate something. Looking over the list of "Has patch" + "Needs improvement" tickets, it seems to me that most of those PRs fizzled out for non-triv

Re: status of 1.10 release blockers

2016-07-30 Thread Tim Graham
/Markus > > On Thu, Jul 14, 2016 at 06:41:51AM -0700, Tim Graham wrote: > >I'm planning for the release candidate on Monday. > > > >The one blocker is #26888 <https://code.djangoproject.com/ticket/26888> > - > >RegexURLResolver doesn't work in t

Fellow Report - July 30, 2016

2016-07-30 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/26941 - Remove quotes from uwsgi "env = LANG=…" configuration (fixed) https://code.djangoproject.com/ticket/26935 - DB connections stuck in closed state when using Django ORM in daemon (duplicate) https://code.djangoproject.com/ticket/13

[ANNOUNCE] Django 1.10 and 1.9.9 released

2016-08-01 Thread Tim Graham
Django 1.10 and a bug fix release for the 1.9 series (1.9.9) are now available: https://www.djangoproject.com/weblog/2016/aug/01/django-110-released/ With the release of Django 1.10, Django 1.9 has reach end of mainstream support. It will continue to receive security and data loss fixes for an

Need help with MySQL 5.7 crashing on Django's Jenkins

2016-08-01 Thread Tim Graham
Sometimes the MySQL 5.7.13 builds on Ubuntu 16.04 are failing with "Lost connection to MySQL server during query" because the MySQL server restarts during the tests. I wonder if anyone has an idea about how to solve this. Looking through the MySQL error log, I think this is the root cause: 2016

Re: Need help with MySQL 5.7 crashing on Django's Jenkins

2016-08-02 Thread Tim Graham
27;, otherwise they'll be ignored. # !includedir /etc/mysql/conf.d/ On Monday, August 1, 2016 at 11:52:07 PM UTC-4, gilberto dos santos alves wrote: > > hi. please post your /etc/my.ini (or your equiv. mysql ini config file). > > 2016-08-01 21:05 GMT-03:00 Tim Graham >: >

Re: UTF-8 name of a staticfiles test is breaking Django installation

2016-08-02 Thread Tim Graham
A similar report was https://code.djangoproject.com/ticket/24761. I'm not sure if this is a bug in those install tools or if it's something we should try to fix in Django. You can use `git blame tests/staticfiles_tests/apps/test/static/test/⊗.txt` to find the commit where the file was introduce

Re: Need help with MySQL 5.7 crashing on Django's Jenkins

2016-08-02 Thread Tim Graham
Value| > +--+--+ > | character_set_connection | cp850| > | collation_connection | cp850_general_ci | > | connect_timeout | 10 | > | init_connect | | > | max_connect_errors | 10 |

Re: Need help with MySQL 5.7 crashing on Django's Jenkins

2016-08-05 Thread Tim Graham
nks. i will continue search for more precise aswers and > solutions. regards. > > 2016-08-02 17:27 GMT-03:00 Tim Graham >: > >> I'm not sure exceeding max_connections is the issue. We have up to 8 >> executors on each machine and the tests aren't running in paral

Re: Trac spam attack / spam filter reactivated

2016-08-06 Thread Tim Graham
igate this problem and let me know > if there is something I could help with. > > Thanks > > On Thursday, 7 July 2016 08:03:54 UTC+5:30, Tim Graham wrote: >> >> In the past couple hours, code.djangoproject.com experienced a spam >> attack of new tickets and wiki p

Fellow Report - August 6, 2016

2016-08-06 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/26977 - Instantiating an abstract model with a string ForeignKey fails with TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types (accepted) https://code.djangoproject.com/ticket/26989 - Provide a way of speci

should blank POST data fallback to use model field defaults?

2016-08-12 Thread Tim Graham
A change in Django 1.10 inadvertently caused the following behavior change: class M(models.Model): f = models.CharField(max_length=255, default='default_value') class MF(forms.ModelForm): f = forms.CharField(required=False) class Meta: model = M fields = ['f'] >>

Re: should blank POST data fallback to use model field defaults?

2016-08-13 Thread Tim Graham
No, Tom's understanding is correct. Django 1.10 removed "fields missing from POST are set to model defaults." On Saturday, August 13, 2016 at 9:50:40 AM UTC-4, Yo-Yo Ma wrote: > > @Tom > > > I'd be surprised if they didn't end up with the model default. > Personally I'd treat that as a regressio

Fellow Report - August 13, 2016

2016-08-13 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27041 - Note that middleware included with Django is compatible with both MIDDLEWARE and MIDDLEWARE_CLASSES (fixed) https://code.djangoproject.com/ticket/25931 - ContentTypes population doesn't work with backwards migrations (fixed) htt

Re: should blank POST data fallback to use model field defaults?

2016-08-15 Thread Tim Graham
case (what custom form field or widget should be used)? On Monday, August 15, 2016 at 11:29:26 AM UTC-4, Tobias McNulty wrote: > > On Fri, Aug 12, 2016 at 9:58 AM, Tim Graham > wrote: > >> A change in Django 1.10 inadvertently caused the following behavior >> change: >

Re: should blank POST data fallback to use model field defaults?

2016-08-17 Thread Tim Graham
I think there's a misunderstanding. As the documentation says, forms.BooleanField(required=False) is the common case because required=True means the checkbox must be checked. It's only confusing in the context of a non-browser request where empty POST data might have a different meaning. https:

Re: django.core.mail.outbox and __all__

2016-08-17 Thread Tim Graham
I believe that would break things: >>> from django.core.mail import * AttributeError: module 'django.core.mail' has no attribute 'mailbox' On Wednesday, August 17, 2016 at 7:30:11 AM UTC-4, IL Ka wrote: > > Hello, > > ``django.core.mail`` package contains ``__all__`` with list of public > symbol

Re: PEP 484 type hinting in Django

2016-08-17 Thread Tim Graham
The JetBrains announcement that they want to fund the project isn't a guarantee that it'll be implemented. The feature needs to go through the normal feature acceptance process, which as Markus said, might involve a DEP. Assuming the idea is accepted, my sense on timing would be to wait until

Re: should blank POST data fallback to use model field defaults?

2016-08-17 Thread Tim Graham
I completed the pull request to restore the fallback for empty data, except for CheckboxInput. If you have any input, please speak up. https://github.com/django/django/pull/7068 On Wednesday, August 17, 2016 at 7:40:56 AM UTC-4, Tim Graham wrote: > > I think there's a misunderstand

Re: Take index type into account in inspectdb command

2016-08-19 Thread Tim Graham
I think if we do a similar thing like we do for field introspection (outputting a comment like "# This field type is a guess" next to unknown fields) it would be okay. The comment might say the backend doesn't support index type introspection. Let's put out a call for help to try to get index i

Re: Add an optional parameter to values() that returns a nested dictionary for foreign keys

2016-08-19 Thread Tim Graham
We now have support for expressions in values()/values_list() -- thanks Ian! With the new commit [0], aliases can be created like this: .values(alias=F('field')) Ian has offered an additional commit in the pull request [1] to allow .values(alias='field') (without the F() expression) to automati

Fellow Report - August 20, 2016

2016-08-20 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27075 - URLconf does not properly import underscore-containing module identifiers (worksforme) https://code.djangoproject.com/ticket/27071 - Raise a friendly exception when a string is returned from a view function (wontfix) https://code

Re: New Bug Report

2016-08-22 Thread Tim Graham
Thanks, but you don't need to announce that to this mailing list. We have a separate mailing list that monitors activity on Trac: https://groups.google.com/forum/#!forum/django-updates and GitHub has its own way to subscribe to notifications for activity there. This list mostly discusses larger

Re: Simulating timeouts on client with django.test.client.Client

2016-08-23 Thread Tim Graham
Have you tried writing your own subclass of the test client (or writing a patch for Django's own test client) so we can see what it looks like? (I suggested writing to the mailing list to get other feedback because I'm not sure if this is a good idea or even feasible.) On Tuesday, August 23, 20

Re: Simulating timeouts on client with django.test.client.Client

2016-08-24 Thread Tim Graham
multithreading support has been proposed a couple times but it hasn't passed the discussion stage yet. https://code.djangoproject.com/ticket/20238 https://code.djangoproject.com/ticket/25970 On Wednesday, August 24, 2016 at 2:21:07 PM UTC-4, roboslone wrote: > > So I've tried LiveServerTestCase

Re: Does the javascript test runner need attention?

2016-08-25 Thread Tim Graham
Trey Hunner said [0], "Blanket and qunit are the only real requirements here. We may be able to switch away from Grunt and use those together in a more manual fashion so requirements can be upgraded easily." [0] https://github.com/django/django/pull/4889#issuecomment-219921988 On Thursday, Augu

Fellow Report - August 27, 2016

2016-08-27 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27105 - Misleading error in ContentTypes get_for_model (fixed) https://code.djangoproject.com/ticket/27104 - The Django test client statement 'response.content' in "Writing your first Django app, part 5" unlikely to return "No polls are

Re: Django Box - A vagrant virtual machine for testing Django

2016-08-29 Thread Tim Graham
I don't think a formal approval/proposal is needed to keep django box under the Django org. For example, tools to help with Django development don't require things like fixing security issues (I hope). As long as it's working as semi-maintained, we can add a link to it from the contributing doc

Re: Django default PK type setting

2016-08-30 Thread Tim Graham
Sounds quite complicated. In particular, how could we reasonably test that contrib apps work with arbitrary PKs? On Tuesday, August 30, 2016 at 2:32:18 PM UTC-4, Emett Speer wrote: > > Hello Everyone, > > I would like to propose the exploration of adding a default PK setting do > Django. This co

Re: Sonar for the Django rpoject

2016-08-30 Thread Tim Graham
Perhaps you could tell us about some of the critical issues so we could get a sense for that. On Tuesday, August 30, 2016 at 4:26:42 PM UTC-4, Ivan Sevastoyanov wrote: > > >

Re: Add past/present/future validations for Date and DateTime types

2016-08-30 Thread Tim Graham
Thanks for the proposal. MaxValueValidator and MaxValueValidator are included because they're needed for IntegerField validation. I don't think the proposed validators meet the criteria of "needed in 80% of Django projects" or "can't easily be implemented as a third-party app". On Tuesday, Augu

Re: Sonar for the Django rpoject

2016-08-31 Thread Tim Graham
Regards, > Ivan > > On Wednesday, August 31, 2016 at 12:55:35 AM UTC+3, Tim Graham wrote: >> >> Perhaps you could tell us about some of the critical issues so we could >> get a sense for that. >> >> On Tuesday, August 30, 2016 at 4:26:42 PM UTC-4, I

[ANNOUNCE] Django bugfix release issued: 1.10.1

2016-09-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2016/sep/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions

Fellow Report - September 3, 2016

2016-09-03 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27147 - Add support for defining bounds in postgres range fields (accepted) https://code.djangoproject.com/ticket/27148 - Invalid input for UUIDField with ModelMultipleChoiceField throws ValueError, not ValidationError (accepted) https:

Re: status of 1.10 release blockers

2016-09-05 Thread Tim Graham
f we can't come to a consensus. In particular, none of the ticket reporters have commented about whether or not the fix solves their issue. PR: https://github.com/django/django/pull/7194 On Saturday, July 30, 2016 at 9:20:46 PM UTC-4, Tim Graham wrote: > > The final release is on schedu

Re: status of 1.10 release blockers

2016-09-05 Thread Tim Graham
ssue until next month if there isn't a consensus. In particular, there's been no feedback from the ticket reporters on whether or not the PR works for them. PR: https://github.com/django/django/pull/7194 On Saturday, July 30, 2016 at 9:20:46 PM UTC-4, Tim Graham wrote: > > The fi

Re: Logging config tries too hard

2016-09-06 Thread Tim Graham
Just to be sure, which version of Django are you using? There were some simplifications in Django 1.9 that attempted to make writing custom logging configurations easier and further changes in Django 1.10. https://github.com/django/django/commit/8efea1b8d5b5fb0cfef1a3244c339cebf8af36c5 https://g

Re: Logging config tries too hard

2016-09-06 Thread Tim Graham
Carl, I think this is the thread with your past comments: https://groups.google.com/d/topic/django-developers/no2IhnRty68/discussion To avoid a new setting, we could add some custom key/value to LOGGING for the new behavior and pop it before the dict is passed to dictConfig. On Tuesday, Septemb

Re: How to split values where is a comma ?

2016-09-07 Thread Tim Graham
This list is for discussing the development of Django itself, please ask usage questions on django-users. On Wednesday, September 7, 2016 at 12:44:57 PM UTC-4, Asad ur Rehman wrote: > > Here is my view.py > > import os.path > import commands > > def call_report(request): > > a = commands.g

Re: Why doesn't BinaryField use BINARY type?

2016-09-08 Thread Tim Graham
Maybe the fields from django-mysql help? http://django-mysql.readthedocs.io/en/latest/model_fields/resizable_text_binary_fields.html On Thursday, September 8, 2016 at 10:56:15 AM UTC-4, Chris Foresman wrote: > > I had a need to store an encrypted bytestring, and CharField doesn't work. > But Bina

Re: Migration Questioner and String-Type Fields

2016-09-09 Thread Tim Graham
If blank=False, then a new column with a non-blank value means that all existing objects won't pass form validation. Therefore, I don't see why a prompt for a value isn't helpful. On Friday, September 9, 2016 at 6:42:02 AM UTC-4, Jarek Glowacki wrote: > > I made a rant/ticket regarding the hidde

Re: Channels is now an official Django project!

2016-09-09 Thread Tim Graham
Could you please share the information that you submitted to the technical board as per the DEP: "The Shepherd will submit the project, the list of people signed up for the Maintenance Team, and the collated arguments to the Technical Board for decision." In hindsight, I expected that informati

Re: Channels is now an official Django project!

2016-09-09 Thread Tim Graham
straight away but still having it under the official Django > umbrella. > > If you have any questions or clarifications, please say and I'm happy to > discuss. > > --- > > Andrew > > On Fri, Sep 9, 2016 at 4:08 PM, Tim Graham > wrote: > >> Could you please sh

Re: Channels is now an official Django project!

2016-09-09 Thread Tim Graham
Channels and its > merits and downsides constantly. > > I tried to build on the problems people had with my merge approach and do > this slowly, define a process, and get people involved - I'm not sure what > else I could have done? Waited another two months? > > Andrew

Re: Migration Questioner and String-Type Fields

2016-09-09 Thread Tim Graham
ngo > form. > > On Friday, September 9, 2016 at 11:58:38 PM UTC+10, Tim Graham wrote: >> >> If blank=False, then a new column with a non-blank value means that all >> existing objects won't pass form validation. Therefore, I don't see why a >> prompt f

Fellow Report - September 10, 2016

2016-09-10 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27173 - Permit import statements to be longer than 80 characters (wontfix) https://code.djangoproject.com/ticket/27186 - Cannot change DateTimeField with default via Admin since Django 1.10.1 (accepted) https://code.djangoproject.com/tic

Re: Challenge teaching Django to beginners: urls.py

2016-09-13 Thread Tim Graham
I would like to see if this could be done as a third-party project (allow "pluggable URLs" which could use any syntax). If not, then let's accept a patch to Django to support it. Over time, if there's some strong consensus about a particular third-party package, then we could bring it in to core

Re: Trac spam attack / spam filter reactivated

2016-09-14 Thread Tim Graham
The difficulty is tuning the spam weights. We had spammers completing capchas and getting their posts through. On Wednesday, September 14, 2016 at 6:29:40 PM UTC-4, Zach wrote: > > I'm also trying to cc myself on tickets only to get "Submission rejected > as potential spam". Can we incorporate t

Re: Implicit ForeignKey index and unique_together

2016-09-16 Thread Tim Graham
Did you try to find anything related in Trac? Maybe https://code.djangoproject.com/ticket/24082? I use this query in Google: postgresql unique index site:code.djangoproject.com On Friday, September 16, 2016 at 9:51:13 AM UTC-4, Dilyan Palauzov wrote: > > Hello, > > according to the documentati

Fellow Report - September 17, 2016

2016-09-17 Thread Tim Graham
Following the release of Python 3.6 beta this week, I've spent some time fixing test failures and warnings in Django. All work is tracked in https://code.djangoproject.com/ticket/27025. Triaged --- https://code.djangoproject.com/ticket/27210 - smtp EmailBackend doesn't honor fail_silen

Re: Autocomplete in Django 1.11: Widget in Forms Library?

2016-09-20 Thread Tim Graham
I haven't seen that proposal. This type of widget would be new territory for django.forms as none of the existing widgets require JavaScript. I lean toward keeping things that way, but I'm open to hearing counterarguments. Historically, Django avoided "blessing" any particular JavaScript librari

Re: Access to Wiki at code.djangoproject.com/wiki

2016-09-20 Thread Tim Graham
I propose deleting that wiki page as well as similar pages like DjangoJobs and DjangoResources. These days there are much better resources for those types of things and for me those pages are just causing extra work as far as monitoring for spam. If anyone thinks they should stay, please speak u

Starting maintenance on code.djangoproject.com

2016-09-20 Thread Tim Graham
https://code.djangoproject.com/ is going down shortly for an upgrade. I'll send an update if it takes more than an hour. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and s

Re: Starting maintenance on code.djangoproject.com

2016-09-20 Thread Tim Graham
The maintenance is complete. If you find any issues creating or updating tickets, let me know. Thanks! On Tuesday, September 20, 2016 at 1:17:11 PM UTC-4, Tim Graham wrote: > > https://code.djangoproject.com/ is going down shortly for an upgrade. > I'll send an update if it take

Re: request to reopen issue #23332 (using the dotted test name in test output)

2016-09-20 Thread Tim Graham
I updated the Python issue to ask whether or not there's consensus to make the change there. Even if that issue proceeds, I guess it would be a nice convenience for current versions of Python that won't receive the change. http://bugs.python.org/issue22431 On Tuesday, September 20, 2016 at 8:16:

Re: Add an argument to ModelChoiceField for callable function to set label for instance.

2016-09-20 Thread Tim Graham
The approach you suggested was suggested in the thread of ticket you mentioned: https://groups.google.com/d/topic/django-developers/7DDEX73zVrI/discussion Brian Rosner: "I am a +1 on a configuration parameter since the alternative by subclassing is a bit too involved for something fairly trivia

Re: How to catch django auto complete lights value and render future fields?

2016-09-21 Thread Tim Graham
This list is for discussing the development of Django itself, please ask usage questions on django-users. On Wednesday, September 21, 2016 at 12:43:06 PM UTC-4, Patlola Praveen wrote: > > class GroupPropertiesForm(forms.ModelForm): > fields['equipment_grade']: forms.ChoiceField( >

Re: Adding aggregates to ModelAdmin.list_display

2016-09-21 Thread Tim Graham
How do you envision it interacting with ticket #14336 (annotations in list_display)? Would we also need list_annotate? I'm a little sad every time we add another customization point to the admin as I fear no end to the complexity, but maybe I should just get over it. https://code.djangoproject.

Re: Should the Django session-id be hashed?

2016-09-22 Thread Tim Graham
The idea of adding an option to store the session ID hash rather than the ID itself was discussed a few years ago on the core team mailing list (see the "Authentication best practices" thread and "Don't store session IDs in the clear" in the security issue tracker). Maybe we can reproduce some o

Re: Should the Django session-id be hashed?

2016-09-22 Thread Tim Graham
a proposal. > > Rigel. > > On Thu, Sep 22, 2016 at 2:23 PM, Tim Graham > wrote: > > The idea of adding an option to store the session ID hash rather than > the ID > > itself was discussed a few years ago on the core team mailing list (see > the > > "Au

Fellow Report - September 24, 2016

2016-09-24 Thread Tim Graham
I spent a few hours this week trying to develop a better understanding of the ORM by investigating some issues [0]. Along the way, I reviewed the coverage report for the relevant areas and submitted a few PRs to remove unused code. I hope I’ll have time to continue this effort. A nice outcome

[ANNOUNCE] Django security releases issued: 1.9.10 and 1.8.15

2016-09-26 Thread Tim Graham
Today the Django team issued 1.9.10 and 1.8.15 as part of our security process. These releases address a security issue, and we encourage all users to upgrade as soon as possible. Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2016/sep/26/security-relea

Re: Form.Media: render inline css/js

2016-09-29 Thread Tim Graham
I'm not exactly sure what your proposal entails. Could you give some psuedo-code to demonstrate what you have in mind? By the way, there is some discussion that it might be best to replace the Media class, although it's not entirely clear how to do that: https://code.djangoproject.com/ticket/22

Re: is_valid as property

2016-09-29 Thread Tim Graham
I don't think the same argument applies because no one (I hope) is calling form.is_valid() in templates. On Thursday, September 29, 2016 at 9:38:07 AM UTC-4, Sven R. Kunze wrote: > > Good afternoon, > > I would like to follow up on > https://groups.google.com/forum/#!searchin/django-developers/i

Re: has_changed as property

2016-09-29 Thread Tim Graham
Unless there are different arguments for has_changed vs. is_valid, I suggest we discuss both attributes on the nearly identical "is_valid as property" thread. On Thursday, September 29, 2016 at 9:40:38 AM UTC-4, Sven R. Kunze wrote: > > Good afternoon, > > I would like to follow up on > https:/

Re: is_valid as property

2016-09-29 Thread Tim Graham
eptember 29, 2016 at 11:52:55 AM UTC-4, Sven R. Kunze wrote: > > Am Donnerstag, 29. September 2016 15:52:00 UTC+2 schrieb Tim Graham: >> >> I don't think the same argument applies because no one (I hope) is >> calling form.is_valid() in templates. >> > >

Re: Autocomplete in Django 1.11: Widget in Forms Library?

2016-09-30 Thread Tim Graham
ks, > Collin > > > On Wed, Sep 21, 2016 at 6:28 AM, guettli > > wrote: > >> >> >> Am Dienstag, 20. September 2016 13:30:33 UTC+2 schrieb Tim Graham: >>> >>> I haven't seen that proposal. This type of widget would be new territory >>

[ANNOUNCE] Django bugfix release issued: 1.10.2

2016-10-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2016/oct/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Fellow Report - October 1, 2016

2016-10-01 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27275 - Use verbose names for fields in construct_change_message (duplicate) https://code.djangoproject.com/ticket/27274 - KeyError when using RenameModel in migrations that refer to an unmanaged model in another app. (invalid) https://

does anyone use models with underscores in the name?

2016-10-03 Thread Tim Graham
Ticket #27295 notes that the ORM doesn't work well with models that start with an underscore (e.g. _UsersGroup). I didn't check if the same problem exists with an underscore anywhere in the name, but I wanted to ask if anyone has seen model names that use underscores? If not, my proposal is to

Re: Contributing to ORM module

2016-10-03 Thread Tim Graham
You can filter tickets by "Component". You'll want to look at the "Database layer (models, ORM)" component. There are plenty of non-trivial issues to tackle, although it requires a lot of time just to understand the basics. I'd recommend trying to tackle some small issues first. That'll give yo

Re: Feature suggestion: Option to suppress system checks in commands

2016-10-03 Thread Tim Graham
I'm interested to know which checks you want to suppress only in some cases? On Friday, September 30, 2016 at 7:33:02 AM UTC-4, Bogdan Bursuc wrote: > > Hi, > > You could add the setting through and env variable and obtain that > variable inside the settings file with > SILENCED_SYSTEM_CHECKS = b

Re: does anyone use models with underscores in the name?

2016-10-04 Thread Tim Graham
n one of my project. > I found it very helpful for audit like fields: _cr_date and _cr_user > > Regards, > Constantine C. > > On Oct 3, 2016, at 19:30, Tim Graham > > wrote: > > Ticket #27295 notes that the ORM doesn't work well with models that start > with an

Re: delegating our static file serving

2016-10-04 Thread Tim Graham
mments in this discussion and Django > documentation > > https://docs.djangoproject.com/en/1.10/howto/static-files/ > andhttps://docs.djangoproject.com/en/1.10/howto/static-files/deployment/. > > > Am Freitag, 28. November 2014 15:15:03 UTC+1 schrieb Tim Graham: >> >

Re: DEP pre-proposal for a simpler URLs syntax.

2016-10-06 Thread Tim Graham
Hi Tom, I'm not sure how the timing will work out, but an option could be to target this for inclusion in Django 2.0 but make the necessary fixes in Django 1.11 to allow this to exist as a third-party app in the meantime. That would allow it some time to get some real world usage and undergo mo

undeclared variable appearing in django/db/models/__init__.py

2016-10-06 Thread Tim Graham
I'm seeing an issue while running the Django test suite that I can't explain. If you add print(functions) before from django.db.models.manager import Manager in https://github.com/django/django/blob/master/django/db/models/__init__.py#L15, it gives name 'functions' is not defined as I would ex

disclosing security release dates on django-announce

2016-10-07 Thread Tim Graham
The Django team proposes [0] to add the following to the security policy: Approximately one week before public disclosure, ... we notify django-announce [1] of the date and approximate time of the upcoming security release. No information about the issues is given. This is to aid organizations t

Re: undeclared variable appearing in django/db/models/__init__.py

2016-10-07 Thread Tim Graham
ge django.db.models, which Python does by adding it to the > __init__ module's locals(), which makes `functions` available as a label > in the remainder of the code. > > Note that I can't actually find the chapter and verse for how this works > in the Python docs, but I

Re: Should we require pytz for timezone support in Django?

2016-10-08 Thread Tim Graham
I created a ticket and PR to add pytz to install_requires. I think it's a nice simplification and will result in a better user experience. https://code.djangoproject.com/ticket/27327 https://github.com/django/django/pull/7361 On Monday, June 6, 2016 at 5:28:11 AM UTC-4, Aymeric Augustin wrote: >

Fellow Report - October 8, 2016

2016-10-08 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27304 - Django 1.10 onwards broke previous behaviour for models.DateTimeField() in Admin (invalid) https://code.djangoproject.com/ticket/27258 - Raise an exception if RequestContext is used with template.backends.django.Template.render()

Re: Should we require pytz for timezone support in Django?

2016-10-10 Thread Tim Graham
I forgot to mention (and document) that (if I'm following the code correctly) this change removes support for setting TIME_ZONE=None. According to the docs, TIME_ZONE=None "causes cause Django to fall back to using the system timezone. However, this is discouraged when USE_TZ = True

Re: disclosing security release dates on django-announce

2016-10-10 Thread Tim Graham
Markus Holtermann wrote: > > On Friday, October 7, 2016 at 4:58:00 PM UTC+2, Tim Graham wrote: > > > The Django team proposes [0] to add the following to the security > policy: > > > > > > Approximately one week before public disclosure, ... > > > we not

Re: Should we require pytz for timezone support in Django?

2016-10-10 Thread Tim Graham
Here's the ticket that added support for TIME_ZONE=None: https://code.djangoproject.com/ticket/1480 On Monday, October 10, 2016 at 3:50:51 PM UTC-4, Aymeric Augustin wrote: > > On 10 Oct 2016, at 21:31, Tim Graham > > wrote: > > I forgot to mention (and document) that (if

Re: disclosing security release dates on django-announce

2016-10-10 Thread Tim Graham
Thanks, I added that to the PR. On Monday, October 10, 2016 at 3:43:09 PM UTC-4, Alex_Gaynor wrote: > > We already have one :-), our bounty indicates several severity levels: > https://hackerone.com/django > > Alex > > On Mon, Oct 10, 2016 at 3:40 PM, Tim Graham >

Re: is_valid as property

2016-10-11 Thread Tim Graham
I don't think requiring every Django project to rewrite their views from: if form.is_valid(): to form.validate() if form.is_valid: is practical. About changing form.errors not to validate the form, I'm not sure there's much benefit there either. When writing tests, I often write: self.asser

Re: Should we require pytz for timezone support in Django?

2016-10-12 Thread Tim Graham
According to the docs for settings.TIMEZONE: "Django cannot reliably use alternate time zones in a Windows environment. If you’re running Django on Windows, TIME_ZONE must be set to match the system time zone." If we keep supporting setti

Re: Should we require pytz for timezone support in Django?

2016-10-12 Thread Tim Graham
(except on Windows). I don't really understand the use case where doing that may have been a problem [0]. [0] https://code.djangoproject.com/ticket/1480 On Wednesday, October 12, 2016 at 12:58:19 PM UTC-4, Aymeric Augustin wrote: > > > On 12 Oct 2016, at 18:22, Tim Graham > >

Re: (contrib.admin) Improving object deletion

2016-10-14 Thread Tim Graham
Here is a ticket about the memory issue: https://code.djangoproject.com/ticket/10919 It's hard for me to evaluate the other idea without looking at the code. If you want to open a ticket and provide a patch, go ahead. On Friday, October 14, 2016 at 9:08:16 AM UTC-4, Marcin Nowak wrote: > > Hi a

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-15 Thread Tim Graham
At the time of the implementation [0], no one raised that use case. Probably we can reopen the ticket and add it back. [0] https://groups.google.com/d/topic/django-developers/_TD8IkSLgqE/discussion On Saturday, October 15, 2016 at 9:32:54 AM UTC-4, Andrew Wall wrote: > > Very much appreciate th

Fellow Report - October 15, 2016

2016-10-15 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27330 - Generic CreateView/UpdateView doesn't send the kwargs to get_context_data (duplicate) https://code.djangoproject.com/ticket/27334 - File uploads could rename temporary files rather than copying them (duplicate) https://code.djang

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-17 Thread Tim Graham
Good points -- given the existing subclassing needed to get LiverServerTestCase to support that use case, it might be reasonable not to worry about backwards-compatibility here. I'd be interested to hear Harry's (the author) thoughts about it. On Sunday, October 16, 2016 at 1:44:02 PM UTC-4, Al

Re: can_introspect_default feature

2016-10-18 Thread Tim Graham
Hi Maxi, Did you take a look at the relevant commit that introduced the flag? https://github.com/django/django/commit/75303b01a9cc900eebf1f27ba0bc6508334242fc On Tuesday, October 18, 2016 at 9:51:46 AM UTC-4, Maximiliano Robaina wrote: > > Hi, > > How supposed to can_introspect_default must work?

Re: can_introspect_default feature

2016-10-20 Thread Tim Graham
column doesn't have a default. On Thursday, October 20, 2016 at 8:29:29 AM UTC-4, Maximiliano Robaina wrote: > > Hi Tim, > > Thanks for response. > > El martes, 18 de octubre de 2016, 12:07:34 (UTC-3), Tim Graham escribió: >> >> Hi Maxi, >> >>

Fellow Report - October 22, 2016

2016-10-22 Thread Tim Graham
Not too much to report as I took some time off this week. Triaged --- https://code.djangoproject.com/ticket/27355 - Add PostgreSQL Extension operation example to reference page (accepted) https://code.djangoproject.com/ticket/27356 - admin lookup_allowed incorrectly returns False for a ne

Re: Contributing to DJANGO

2016-10-24 Thread Tim Graham
Certainly. Take a look at https://docs.djangoproject.com/en/dev/internals/contributing/. On Monday, October 24, 2016 at 12:34:36 PM UTC-4, Ravi Sharma wrote: > > Hello all, > Im Ravi Sharma, currently a 3rd year undergraduate student at IIT Bombay , > India > Im quite interested in working with

Re: Should we require pytz for timezone support in Django?

2016-10-24 Thread Tim Graham
er 12, 2016 at 3:12:44 PM UTC-4, Tim Graham wrote: > > Would you be comfortable recommending that package for anyone who needs > the autodetection? This seems to work: > > from tzlocal import get_localzone > TIME_ZONE = get_localzone().zone > > What would change compared to t

Re: can_introspect_default feature

2016-10-25 Thread Tim Graham
s which have to touch the database and > only the API server is written in Django.) > > > On Thursday, October 20, 2016 at 7:53:23 AM UTC-5, Tim Graham wrote: >> >> The 'default' model field option is used in Python rather than in the >> database. Schema

Re: Should we move filesizeformat to django.contrib.humanize?

2016-10-29 Thread Tim Graham
Adding a helper function that does the formatting make sense in the spirit of #27106. Putting that helper in humanize makes logical sense, however, it would be slightly unclean to have a built-in template tag depend on a contrib app and I'm not sure that deprecating in the built-in filter in fa

<    9   10   11   12   13   14   15   16   17   >