Re: RFC #12823

2011-01-11 Thread Philippe Raoult
Just wanted to bump on this issue. The join is indeed a bit weird to the human eye (extra related__pk__isnull = False added) but that's just eye candy. This is true of many queries generated by django anyway, all that matters for the time being is correctness. I would mark ready for checkin but I

Re: RFC #12823

2010-12-16 Thread Harro
Made some comments about the bug and the patch. The patch gives the right result, but the JOIN there is a bit weird. On Dec 15, 7:54 pm, Philippe Raoult wrote: > I have produced a patch for this [1] long-standing SQL bug. > > The SQL produced with the patch is correct AFAIK, but my understanding

RFC #12823

2010-12-15 Thread Philippe Raoult
I have produced a patch for this [1] long-standing SQL bug. The SQL produced with the patch is correct AFAIK, but my understanding of the sql code is rather poor so I'm hoping that someone who knows better will give it a look. There might be a more correct/elegant way to fix this. [1] http://code