Just wanted to bump on this issue. The join is indeed a bit weird to the human eye (extra related__pk__isnull = False added) but that's just eye candy. This is true of many queries generated by django anyway, all that matters for the time being is correctness.
I would mark ready for checkin but I understand that'd be bad manners since I wrote the patch. Philippe On 16 December 2010 09:37, Harro <hvdkl...@gmail.com> wrote: > Made some comments about the bug and the patch. > The patch gives the right result, but the JOIN there is a bit weird. > > On Dec 15, 7:54 pm, Philippe Raoult <phili...@chandra-conseil.fr> > wrote: >> I have produced a patch for this [1] long-standing SQL bug. >> >> The SQL produced with the patch is correct AFAIK, but my understanding >> of the sql code is rather poor so I'm hoping that someone who knows >> better will give it a look. There might be a more correct/elegant way >> to fix this. >> >> [1]http://code.djangoproject.com/ticket/12823 >> >> Best regards, >> Philippe > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-develop...@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
