Re: On adding comments to database schema

Thank you Tom. I'll go ahead and do that. I may seek some advice in django-core-mentorship since this is my first time working on a patch. KimSoungRyoul I hope you don't mind that I proceed with reassignment. If you remain interested, please let me know and I'd love to collaborate with you on it

Re: On adding comments to database schema

It's funny that you bring this up, I was actually looking at this today and thinking about picking it up next week. Jared, the PR was closed without any comment from the author and is seemingly abandoned. I think it's safe for you to assign the ticket to yourself and continue the work in a new PR

Re: On adding comments to database schema

KimSoungRyoul would you like help with writing the docs and tests for this? I'd like to contribute to Django in some way and this is a feature my company would greatly value (we have Data Scientists and DBAs interacting with db tables managed by Django, so having comment documentation at the DB

Re: On adding comments to database schema

KimSoungRyoul it looks like there is feedback on the PR you created (PR #12605 ) and Marius also pointed out that docs and tests are missing. Would you like help with the docs and tests? We've recently added some data scientists and dbas to our team

Re: On adding comments to database schema

I'm sorry if I sounded like I was pushing you. even missing checklist 2020년 5월 3일 일요일 오전 1시 42분 2초 UTC+9, Mariusz Felisiak 님의 말: > > Asking for a review on multiple channels doesn't help. You need to be > patient, we have many PRs in review queue. Please check "Patch review > checklist" [1].

Re: On adding comments to database schema

Asking for a review on multiple channels doesn't help. You need to be patient, we have many PRs in review queue. Please check "Patch review checklist" [1]. At first glance, docs are missing. [1] https://docs.djangoproject.com/en/3.0/internals/contributing/writing-code/submitting-patches/#patch-

Re: On adding comments to database schema

Hi felixxm I want this feature to be reflected in Django.3.1 I know this feature that many people won't use. but some people who communicate with DBA would be helpful this feature sometimes ORM take control from DBA *like these situation...* DBAs: we want to know comment(help_text) not to

Re: On adding comments to database schema

add parameter "db_column_comment" to Field() and. db_table_comment class AModel(models.Model): aaa = model.CharField(help_text="i am help_text", db_column_comment="i am db_comment",~~~) class Meta: db_table = "a_model_example_name" db_table_comment ="this

Re: On adding comments to database schema

i assign it to me https://code.djangoproject.com/ticket/18468 i will close this pullRequest caused by imperfection ​https://github.com/django/django/pull/12605 I will bring a new PullRequest as soon as possible. in at least a week -- You received this message because you are subscribed to

Re: On adding comments to database schema

Mauricio, the ticket tracker doesn't tend to get out of sync, so you can see the ticket is still open and waiting for an implementation: https://code.djangoproject.com/ticket/18468 If you want to help, you can start with the "writing your first patch for django" tutorial: https://docs.djangoprojec

Re: On adding comments to database schema

I've made it as a separate django libm but only for PostgresSQL: https://github.com/vanadium23/django-db-comments среда, 5 июня 2019 г., 0:29:21 UTC+3 пользователь Mauricio Cordero написал: > > Hello all, just wondering if this feature was ever implemented. > -- You received this message becaus

Re: On adding comments to database schema

Hello all, just wondering if this feature was ever implemented. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-de

Re: On adding comments to database schema

Hello, My gut feeling is that I'd rather implement this in the migrations engine (your option 1) than bolt it on (the option 2). Disclaimer — I don't know the migrations engine all that well. Best regards, -- Aymeric. > On 18 Mar 2018, at 07:12, vanadium23 wrote: > > Hi, community. > >

Re: On adding comments to database schema

Hi, community. I've been stuck at realization, because Postgres and oracle have a syntax like comment on {table}.{column} for storing comments, so this needs to be done after table/column creation. So there are two ways: 1. Add it to post migrate signal, as for content types. But I can implemen

Re: On adding comments to database schema

That's good. I'll prepare the patch for review. суббота, 10 марта 2018 г., 10:27:30 UTC+3 пользователь Aymeric Augustin написал: > > I think we could implement that feature. > > (Yes I changed my mind from six years ago when I wontfix'd the ticket.) > > -- > Aymeric. > > > > On 8 Mar 2018, at 11

Re: On adding comments to database schema

I think we could implement that feature. (Yes I changed my mind from six years ago when I wontfix'd the ticket.) -- Aymeric. > On 8 Mar 2018, at 11:00, Jani Tiainen wrote: > > Oracle supports comments as well. > > 7.3.2018 2.52 ip. "vanadium23" > kirjoitti:

Re: On adding comments to database schema

Oracle supports comments as well. 7.3.2018 2.52 ip. "vanadium23" kirjoitti: > Hello, fellows. > > There was once a proposal about ability to add comments to table/columns > in postgres: https://code.djangoproject.com/ticket/18468 > I re-read discussion in ticket, and it has ended with another pr

On adding comments to database schema

Hello, fellows. There was once a proposal about ability to add comments to table/columns in postgres: https://code.djangoproject.com/ticket/18468 I re-read discussion in ticket, and it has ended with another proposal, that now migrations is within Django, so we can add this feature. I want to m