Thank you Tom. I'll go ahead and do that. I may seek some advice in django-core-mentorship since this is my first time working on a patch. KimSoungRyoul I hope you don't mind that I proceed with reassignment. If you remain interested, please let me know and I'd love to collaborate with you on it together. Otherwise I'll give it my best shot.
On Thursday, May 6, 2021 at 6:39:45 AM UTC-7 t...@carrick.eu wrote: > It's funny that you bring this up, I was actually looking at this today > and thinking about picking it up next week. > > Jared, the PR was closed without any comment from the author and is > seemingly abandoned. I think it's safe for you to assign the ticket to > yourself and continue the work in a new PR at this point - that was going > to be my plan, anyway. > > Tom > > On Thu, 6 May 2021 at 15:16, Jared Chung <jared...@gmail.com> wrote: > >> KimSoungRyoul would you like help with writing the docs and tests for >> this? I'd like to contribute to Django in some way and this is a feature my >> company would greatly value (we have Data Scientists and DBAs interacting >> with db tables managed by Django, so having comment documentation at the DB >> level would have a huge positive impact). It looks like you received >> feedback on your PR <https://github.com/django/django/pull/12605> and >> Mariusz pointed out that docs and tests are needed. I'd be happy to help >> out with the docs and tests if I can. You're marked as ticket owner right >> now on ticket 18468 <https://code.djangoproject.com/ticket/18468>. >> Please let me know! >> *(Disclosure: I'm new to contributing to Django, and hopeful that this >> can be a good ticket for me to start with. I've been using Django now for a >> decade and am excited to start giving back!)* >> >> On Saturday, May 2, 2020 at 10:24:46 PM UTC-7 kimsou...@gmail.com wrote: >> >>> I'm sorry if I sounded like I was pushing you. >>> >>> even missing checklist >>> >>> >>> 2020년 5월 3일 일요일 오전 1시 42분 2초 UTC+9, Mariusz Felisiak 님의 말: >>> >>>> Asking for a review on multiple channels doesn't help. You need to be >>>> patient, we have many PRs in review queue. Please check "Patch review >>>> checklist" [1]. At first glance, docs are missing. >>>> >>>> [1] >>>> https://docs.djangoproject.com/en/3.0/internals/contributing/writing-code/submitting-patches/#patch-review-checklist >>>> >>> -- >> > You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/62705a74-f16d-42c3-b440-4e3e7628351cn%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/62705a74-f16d-42c3-b440-4e3e7628351cn%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/6a477cf1-7cfa-4fd3-97f2-b2a9d62b2e1fn%40googlegroups.com.
