Re: Removal of USE_L10N setting

2021-06-16 Thread René Fleschenberg
Hi Claude, > I understand this concern. I wonder if that could be solved separately, > for example by: >  - returning int subclasses from AutoField's to_python (a bit like > str/SafeString for handling escaping) >  - not localizing those integers, unless use_l10n is forced (True) > Does this look

Re: Removal of USE_L10N setting

2021-06-12 Thread René Fleschenberg
Hi, On 6/11/21 6:50 PM, Claude Paroz wrote: > Is there a possible deprecation path? Maybe add a system check that warns if the setting is still present? -- René -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)"

Re: Removal of USE_L10N setting

2021-06-12 Thread René Fleschenberg
Hi, On 6/11/21 6:50 PM, Claude Paroz wrote: > As usual, the main drawback is backwards compatibility. The possibly > affected projects are those having USE_L10N = False, along with multiple > LANGUAGES. > > Is this a good idea? > I would also like to get opinions here about the compatibility issu

Re: Do people actually squash migrations?

2021-05-17 Thread René Fleschenberg
Hi, I agree that it would be good to extend the docs and to describe how to reset a project's migrations. Some prior art on this: https://geekchick77.dreamwidth.org/5560.html https://simpleisbetterthancomplex.com/tutorial/2016/07/26/how-to-reset-migrations.html Regards, René -- You received

Re: Replace the default django test runner to a more robust testing framework (like pytest)

2020-12-15 Thread René Fleschenberg
Hi, On 15.12.20 15:48, Tobias Bengfort wrote: My issue is mostly that pytest uses a lot of magic that is hard to debug, e.g. the overwritten assert statement or implicit injection of fixtures. Most pro arguments seem to depend on personal taste. It should be noted that you can use pytest / py

Re: Should django-admin allow specifying hidden directories for --template?

2020-10-01 Thread René Fleschenberg
Hi, On 01.10.20 15:56, laym...@gmail.com wrote: Thanks for the feedback! From my observations, Django does not ignore hidden /files/, it only ignores hidden /directories/. So, the files that you listed should work fine. Ah, my bad, sorry. As for the built-in exclusion list, I'm not sure if w

Re: Should django-admin allow specifying hidden directories for --template?

2020-10-01 Thread René Fleschenberg
Hi, I can see several use-cases for hidden files / directories in a project template. Here are some examples from one of my current projects: .coveragerc .editorconfig .flake8 .gitignore .gitlab-ci.yml .isort.cfg Instead of introducing a command line option to explicitly include things, can

Re: Django default input validation accepts special caracters

2020-08-19 Thread René Fleschenberg
Hi, But when you are making a governmental website for example: you need actual identity. Django makes it possible (I'd even say easy) to setup your forms / models to enforce stricter requirements if you have to. We don't have to treat these cases as the default. Backwards compatibility is t

Re: Cache framework

2020-08-18 Thread René Fleschenberg
uld the built-in cache backend just not expose those APIs? -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, s

Re: queryset.values() / GROUP BY

2020-07-21 Thread René Fleschenberg
ance. I was wondering if I can get rid of the additional Color.objects.filter() query. But I guess this is not such a common use-case and belongs on django-users anyway. Thanks for the clarification! Regards, René On 21.07.20 20:52, Shai Berger wrote: Hi René, On Tue, 21 Jul 2020

queryset.values() / GROUP BY

2020-07-21 Thread René Fleschenberg
Hi, on IRC, someone hinted me at https://github.com/kako-nawao/django-group-by today. Is there a deeper reason why this functionality is not available in Django core, or is it just that nobody got around to implementing it yet? To me, it seems like something that would be nice to have withou

Re: Should the docs suggest namespace packages?

2020-07-19 Thread René Fleschenberg
why this is not purely academical. Maybe it's debatable whether Python should behave differently, but that's not something that Django can fix. I am in favour of failing early and loudly here. IMHO Django should ignore migration packages without an __init__.py file, maybe with a warning,

Re: Making startproject's settings more 12-factor-y

2020-06-26 Thread René Fleschenberg
Hi, On 6/26/20 12:11 PM, René Fleschenberg wrote: > geared towards development (random default value for SECRET_KEY, DEBUG = > False). I meant DEBUG = True here, of course :) -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django

Re: Making startproject's settings more 12-factor-y

2020-06-26 Thread René Fleschenberg
s > to Django is very high since it can (at least for things like > django-environ) easily live outside of Django with no realy downside. +1 -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Dj

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-16 Thread René Fleschenberg
Hi, During makemigrations, on the other hand, I don't see anything wrong with formatted text or +/-, but I might go a step further. This sounds like a good idea to me. It would break cases where makemigrations is run non-interactively, which might be a good thing. It's a common mistake to r

Re: The blacklist / master issue

2020-06-15 Thread René Fleschenberg
. To me, allow_list / deny_list is at least as clear as white_list / black_list. When Django directly references externally defined technical terms (e.g. underlying APIs), I think more consideration is needed. For RFC 5782, I think that is not the case. Regards, René -- René Fleschenberg -- You receive

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-12 Thread René Fleschenberg
has to detect if it's being run interactively, or we would have to add a command line switch or environment variable. In that case there would be the question what the default should be here. Defaulting to the prompt would be backwards-incompatible. -- René Fleschenberg -- You received this mess

Re: ./manage.py settings

2020-06-12 Thread René Fleschenberg
@googlegroups.com > <mailto:django-developers+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/X2HkH0yasxu2XVxBuVkbTfdSHctL7y3pW9seQ8CHFcVOpmsiyN80JlDYH2g5F6IfPvEdN4zyG6vuxj2HEMJaXUSErMUM5IT70iLvkxsrc7U%3D%40protonmail.com > <https://groups.google.com/d/msgi

Re: Should the docs suggest namespace packages?

2020-05-20 Thread René Fleschenberg
more directly as an example for user code. -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an e

Should the docs suggest namespace packages?

2020-05-20 Thread René Fleschenberg
Hi, https://github.com/django/django/pull/12939 My opinion on this is not particularly strong, but it seems odd to me that we tell users to create namespace packages, without any explanation. What do you think? -- René Fleschenberg -- You received this message because you are subscribed to

Re: Deadlock bug in logging? Reproducible case

2020-04-24 Thread René Fleschenberg
Hi, On 4/23/20 12:20 PM, Adam Johnson wrote: > What version of Python René? I tested with 3.6.7. I can test with other versions, if that helps. Regards, René -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django de

Re: Deadlock bug in logging? Reproducible case

2020-04-23 Thread René Fleschenberg
Hi, On 4/23/20 9:40 AM, Adam Johnson wrote: > Brian - You didn't describe the exact symptoms you're seeing. "Deadlock" > has a particular technical meaning around multiple processes requesting > locks mutually off each other, and normally ends in one process being > terminated. But I presume you'r

Re: Deprecating logout via GET

2020-03-05 Thread René Fleschenberg
Hi, On 04.03.20 12:13, Sam Willis wrote: Why not have the logout link take the user to a page asking them to confirm the logout, and have it as a POSTed form button from there? That adds a helpful confirmation page, removes the difficulties of styling a button as a link constantly (or changin

Re: Deprecating logout via GET

2020-03-02 Thread René Fleschenberg
on-like design would actually be a better UI here? -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: Deprecating logout via GET

2020-02-29 Thread René Fleschenberg
fundamental functionality like this. I found the same example and based https://github.com/django/django/pull/12505 on it :) If anyone has some time to review / test it, that would be great. -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "

Re: Deprecating logout via GET

2020-02-28 Thread René Fleschenberg
a particularly painful adjustment to make on a major version upgrade. Maybe we can provide a specific example in the release notes. IMO, in the end it is better to make users go through this at some point in time than to maintain the undesired behavior forever. -- René Fleschenberg -- You rec

Re: Deprecating logout via GET

2020-02-27 Thread René Fleschenberg
19. Mailing list dicussions are at https://groups.google.com/forum/#!topic/django-developers/MmFzCq8oB5I/discussion and https://groups.google.com/forum/#!topic/django-developers/ax95u_f82D4/discussion. -- René Fleschenberg -- You received this message because you are subscribed to the Google Gro

Deprecating logout via GET

2020-02-27 Thread René Fleschenberg
for this: https://github.com/django/django/pull/12504 -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an em

Re: Allowing model field choices to receive a list of strings instead of a list of string tuples

2019-04-19 Thread René Fleschenberg
= CharField( choices=to_choices([ 'potato', 'carrot', 'turnip', ]) ) A list of strings might be less cognitive load for those developers who never need to change (or translate!) the display names, but for all others, it will be more confusing.

Re: Why does ModelForm do validation and not Model

2019-04-19 Thread René Fleschenberg
ject.com/en/2.2/ref/models/constraints/. -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: Proposal to format Django using black

2019-04-15 Thread René Fleschenberg
Hi Ned. > Try the latest black.  A multi-line lists with comments on each line is > not converted to a one-line list.  The lined-up indentation of the > comments is lost :(, but it's still multi-line. Hmmm, I tried commit cea13f4 (current master at the time of this writing). It turned l = [

Re: Proposal to format Django using black

2019-04-15 Thread René Fleschenberg
Hi > HMS = "%H:%M:%S"  # 14:30:59 > HMSF = ".."  > HM = ".." > TIME_INPUT_FORMATS  = [HMS, HMSF, HM] Just my two cents: This particular rule is the main reason why I personally have not adopted black yet. I really find the one-item-per-line style *much* more readable in many cases. In natural-la

Re: 2020 Authentication Initiativ

2019-04-12 Thread René Fleschenberg
s, and it requires a database extension that in turn requires superuser access to the database to be installed. Do you think it would be realistically possible to have a CITextField that uses Postgres citext when available and falls back to Python in other cases? -- René Fleschenberg -- You rece

Re: Django 2.1 default of samesite=Lax for Session and CSRF cookies cause issues on Safari 12

2019-03-18 Thread René Fleschenberg
Hi. On 3/18/19 12:26 PM, Mat Gadd wrote: > Weirdly, it appears that Gmail isn't inserting click tracking for the > plain password reset link, but when I use my own URL shortener, I can > also see the google.com  redirect in play. It may > just be dev tools behaving strangely, or

Re: Password reset emails in combination with click tracking do not work with Intelligent Tracking Prevention on Safari for iOS 12 and macOS Mojave

2019-01-16 Thread René Fleschenberg
Hey, I ran into this today. I am reusing the password reset views for user signup, so it affects me quite heavily :) No idea if it is going to be of any use, but I sent a report on https://www.apple.com/feedback/safari.html with links to your ticket and this discussion. I will try to get my hand

Can we make HTTP 308 the default for CommonMiddleware / APPEND_SLASH?

2019-01-11 Thread René Fleschenberg
API testing tool (https://www.getpostman.com/) seems to be affected by this. I can subclass ``CommonMiddleware`` and set ``response_redirect_class``, no problem. However, maybe Django should just send HTTP 308 by default? Is there any reason not to? -- René Fleschenberg -- You received this

Re: Default upload permissions

2018-12-07 Thread René Fleschenberg
te the setting, either as 0o644 or as 0o600. -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an e

Re: NEW Feature: Collect static order of directories searched. Possible upgrade inside FileSystemFinder.

2017-03-10 Thread René Fleschenberg
RS = ( os.path.abspath(os.path.join(SITE_ROOT, 'static')), ) # settings_site2.py # site2 uses files from ``static_new``, and falls back to ``static`` SITE_ID = 2 STATIC_ROOT = '/var/static/site2' STATICFILES_DIRS = ( os.path.abspath(os.path.join(SITE_ROOT, 'static_

Re: Extend support for long surnames in Django Auth

2016-08-02 Thread René Fleschenberg
ue that allows us to move this forward without making a core developer feel bad about the change, let's go with 60. I'm +1 on any limit 60+ and -1 on keeping the current limit. -- René Fleschenberg -- You received this message because you are subscribed to the Google Gr

Re: UTF-8 name of a staticfiles test is breaking Django installation

2016-08-02 Thread René Fleschenberg
sitive side-effect on the larger Python ecosystem. The prevalence of old setuptools versions can be rather annoying. For example: https://hynek.me/articles/conditional-python-dependencies/ -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "D

Re: Vendoring multipledispatch

2016-04-09 Thread René Fleschenberg
Hi, > Anyway as long as Django is installed in a virtualenv this shouldn't be > too much of an issue, but I think we should expect some issues from the > users and these should be documented otherwise people might get > frustrated. It can still be an issue for things that share the same virtualen

Re: slow migrations

2016-01-10 Thread René Fleschenberg
uld actually be an official recommendation. -- René Fleschenberg -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an

startproject values for STATICFILES_DIRS and TEMPLATES

2015-11-07 Thread René Fleschenberg
iles should be treated differently in this regard? The docs currently suggest such a configuration for static files, but not for templates. I'd argue that it's more important for templates, but it cannot harm to do it for both. -- René Fleschenberg -- You received this message be