Providing inline "force_login" if "user" keyword argument provided to TestClient. calls (or TestClient.generic)

2020-04-22 Thread Pavel Savchenko
Hi all, As a long time Django user, I often found the requirement to use login or force_login somewhat cumbersome. In comparison, pylons' WebTest has a user keyword argument e.g in their get method, which does that authentication inline. I am suggesting we make a call to login or force_login

Re: Discuss ticket 20264: URLValidator should allow underscores in local hostname

2020-04-16 Thread Pavel Savchenko
Thank you Adam, This is more or less what I ended up doing, sans the replace call, very neat! And thanks a lot for the expert advice, everyone! For the time being at least, it seems we have an agreement on not allowing non-strict validation into Django and I have to agree it just makes sense

Re: Discuss ticket 20264: URLValidator should allow underscores in local hostname

2020-03-24 Thread Pavel Savchenko
4, 2020 at 2:36:33 PM UTC+1, Adam Johnson wrote: > > Hi Pavel > > The ticket ( https://code.djangoproject.com/ticket/20264 ) doesn't > mention any specific use cases, and nor have you. What has this behaviour > blocked for you? > > Thanks, > > Adam > > O

Discuss ticket 20264: URLValidator should allow underscores in local hostname

2020-03-24 Thread Pavel Savchenko
Hi Folks, I've just encountered this issue, and it seems Django's URLValidator regex for host is trying to abide to RFC 1034 recommendation , when there are many sites in the wild that use underscore in their domain name. Can we please discuss

Re: Question about PR for #27391 -- Implement SimpleTestCase.debug method

2019-10-17 Thread Pavel Savchenko
Thanks will do! -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view th

Question about PR for #27391 -- Implement SimpleTestCase.debug method

2019-10-16 Thread Pavel Savchenko
Hello, Is there anything left to-do or discuss to finish this? https://github.com/django/django/pull/7436 Regards, Pavel -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group an