Re: [Development] Use make before you push and stage

2012-01-30 Thread Rohan McGovern
Giuseppe D'Angelo said: > On 30 January 2012 03:51, Rohan McGovern wrote: > > I don't think it is a good idea. > > Having errors with incremental builds which go away when you do a clean > > build is one thing, but there are also some issues which _should_ > > cause the build to fail, but don't if

Re: [Development] Use make before you push and stage

2012-01-29 Thread Giuseppe D'Angelo
On 30 January 2012 04:18, Giuseppe D'Angelo wrote: > > Does anyone have (or knows how to extract from gerrit) stats about how > many stages are requested on average during the week? Sorry, I meant: on avarage _per hour_ during a week. -- Giuseppe D'Angelo ___

Re: [Development] Use make before you push and stage

2012-01-29 Thread Giuseppe D'Angelo
On 30 January 2012 03:51, Rohan McGovern wrote: > I don't think it is a good idea. > Having errors with incremental builds which go away when you do a clean > build is one thing, but there are also some issues which _should_ > cause the build to fail, but don't if you only do incremental builds.

Re: [Development] Use make before you push and stage

2012-01-29 Thread Rohan McGovern
Stephen Kelly said: > I wonder if it's possible for the CI system to maintain and clone > a working master build which patches could be applied to and build > incrementally? (an un-clean build) > Andreas said: > How about investigating incremental builds? Could reduce compile time > to just a f

Re: [Development] Use make before you push and stage

2012-01-29 Thread Rohan McGovern
Jedrzej Nowacki said: > > You are assuming that we need to test every patchest which would be nice, > but it is not necessary. A bot-tester would be sufficient, it might be added > as > a reviewer by human reviewer only if it makes sense. > I like this idea and had been thinking along the

Re: [Development] Use make before you push and stage

2012-01-27 Thread Andreas Aardal Hanssen
> While that it would be awesome to have a system which could compile test each > uploaded patch set, and preferably have the results available before > developers would review them, I think it something that will not scale; at > least not without a system which can guarantee proper incremental

Re: [Development] Use make before you push and stage

2012-01-26 Thread Stephen Kelly
On Thursday, January 26, 2012 09:41:45 Jedrzej Nowacki wrote: > > > > Lets take a look at the current numbers: Can you post numbers for QtBase only instead? That's the most active, the most strictly reviewed (more iterations), and the repo where breakage has the most impact. > > Could we get t

Re: [Development] Use make before you push and stage

2012-01-26 Thread Jedrzej Nowacki
On Wednesday 25. January 2012 20.14.41 ext marius.storm-ol...@nokia.com wrote: > On 1/25/12 11:32 AM, "ext > morten.sor...@nokia.com" > mailto:morten.sor...@nokia.com>> wrote: On Jan > 25, 2012, at 10:47 AM, ext > jiang.ji...@nokia.com w

Re: [Development] Use make before you push and stage

2012-01-25 Thread marius.storm-olsen
On 1/25/12 11:32 AM, "ext morten.sor...@nokia.com" mailto:morten.sor...@nokia.com>> wrote: On Jan 25, 2012, at 10:47 AM, ext jiang.ji...@nokia.com wrote: For somewhat big changes and refactor changes, it usually took many iterations

Re: [Development] Use make before you push and stage

2012-01-25 Thread kai.koehne
o); development@qt-project.org > Subject: Re: [Development] Use make before you push and stage > > [...] > Another hint: configure with -no-pch if you can afford it, otherwise you might > end up with missing includes causing breakage in the CI system. And if you do > larger refac

Re: [Development] Use make before you push and stage

2012-01-25 Thread morten.sorvig
On Jan 25, 2012, at 10:47 AM, ext jiang.ji...@nokia.com wrote: For somewhat big changes and refactor changes, it usually took many iterations of compile/testing until they finally went in, because it's not always possible for the developers to try all the different

Re: [Development] Use make before you push and stage

2012-01-25 Thread Jedrzej Nowacki
On Wednesday 25. January 2012 09.32.38 ext bradley.hug...@nokia.com wrote: > Yesterday was a bit of a frustrating day. I had to stage a simple .pro-file > change of mine 8, eight, times before it finally went in. All of the > breakages throughout the day where build breakages. Many of them were in

Re: [Development] Use make before you push and stage

2012-01-25 Thread jiang.jiang
Hi, On Jan 25, 2012, at 9:55 AM, ext lars.kn...@nokia.com wrote: >> Yesterday was a bit of a frustrating day. I had to stage a simple >> .pro-file change of mine 8, eight, times before it finally went in. All >> of the breakages throughout the day where build breakages. Many of them >> were in the

Re: [Development] Use make before you push and stage

2012-01-25 Thread Laszlo Papp
> Another hint: configure with -no-pch if you can afford it, otherwise you > might end up with missing includes causing breakage in the CI system. And > if you do larger refactorings or touch headers in a bigger way also try to > compile with -qtnamespace Foo (yes, I'm guilty of not doing this as w

Re: [Development] Use make before you push and stage

2012-01-25 Thread lars.knoll
On 1/25/12 9:32 AM, "ext bradley.hug...@nokia.com" wrote: >Yesterday was a bit of a frustrating day. I had to stage a simple >.pro-file change of mine 8, eight, times before it finally went in. All >of the breakages throughout the day where build breakages. Many of them >were in the autotests, bu

[Development] Use make before you push and stage

2012-01-25 Thread bradley.hughes
Yesterday was a bit of a frustrating day. I had to stage a simple .pro-file change of mine 8, eight, times before it finally went in. All of the breakages throughout the day where build breakages. Many of them were in the autotests, but some where in the libraries themselves. My request is simp