r/045820.html
[1]:
https://codereview.qt-project.org/c/qt/qtbase/+/599356/comment/4a6f8bc6_308fad4f/
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jou
> error: "qtmochelpers.h not found or too old.”
Should be fixed by https://codereview.qt-project.org/c/qt/qtscxml/+/604244
--
Ivan
From: Development on behalf of Volker
Hilsheimer via Development
Sent: Thursday, November 14
nt on behalf of Nicolas
Fella via Development
Sent: Thursday, 24 October 2024 19:36
To: development@qt-project.org
Subject: Re: [Development] Deprecated vs deprecated-to-be-removed APIs in Qt
Am 24.10.24 um 16:32 schrieb Ivan Solovev via Development:
Hi,
following up on the Deprecation vs Compa
> Here's another one: formatting of floating point types.
>
> That's a hard pass on the Standard Library implementations. We already carry
> code for this in the form of libdoubleconversion, so unless we can ditch that
> in favour of the Standard Library content, we shouldn't use both, which would
t-like tr()
On Thursday 24 October 2024 03:22:55 Pacific Daylight Time Ivan Solovev via
Development wrote:
> > Unfortunately, I think we'll need the entire parsing and constructing done
> > from scratch.
>
> IMO, we could benefit from the new syntax, if we could build our
> imp
Also, the functions that got deprecated in early Qt 6 versions
(Qt 6.0 - 6.2) might be good candidates for removal.
But that's only my opinion.
Best regards,
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
iva
uggested to use 'n' instead of the argument id.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz der Gesell
runtime instead of compile time, doesn't it?
But we'll anyway have to do that if we allow to change the format specifiers
while doing the translations.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germa
they replace a "{1:%X}" time representation with
> "{1:%H}:{1:02%M}" ?
With std::format you can use the same argument index multiple times, so
it makes sense to allow it.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str.
efully all new Qt APIs will either use `enum class`,
or explicitly define an underlying type.
Best regards,
Ivan
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika P
the personal conversation because I
suspected that
minGW acts differently and uses the system charset. However, I did some more
testing, and it seems that I was wrong.
So, I also think that no further action is required at this point.
Best regards,
Ivan
--
Ivan Solovev
Sen
Ivan
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht
Charlottenburg, HRB 144
ink that QASV(char) providing a broken UTF-8 sequence makes sense.
We also have
QString s('\xe4'); // calls QString(QChar) c-tor, using an implicit
QChar(char) c-tor
producing "ä", not an invalid UTF-8 sequence.
--
Ivan Solovev
Senior Software Eng
th std::formatter.
IIUC, the problem of extra allocations is covered by the transcoding
iterators and views in the paper that was linked by Giuseppe.
Best regards,
Ivan
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.
ed
> char16_t to be enabled on the generic formatters, for one thing.
I must admit that I have no idea how this process works. How to reach out
to them and ask if they have any plans about char16_t support?
Maybe even asking if they have any plans for wchar_t -> char formatters
would be help
ar more opinions on how to proceed here, so please
share your ideas!
Best regards,
Ivan
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, J
+1
Best regards,
Ivan
From: Development on behalf of Alexey
Edelev via Development
Sent: Thursday, May 30, 2024 8:46 AM
To: development@qt-project.org
Subject: [Development] Nominating Dennis Oberst for approver rights
Hi all,
I would like to nominate Denni
> The ABI functions can return one of these other types:
> bool (for equality comparisons)
> int (for non-partial ordering)
> QPartialOrdering (for partial ordering)
IIUC, returning QPartialOrdering is exactly what we want to avoid, due to the
std::partial_ordering -> QPartialOrdering (and re
@ Qt)
On 13.11.23 17:15, Thiago Macieira wrote:
> On Monday, 13 November 2023 01:34:08 PST Ivan Solovev via Development wrote:
>> Thiago wrote:
>>> The problem is that QPartialOrdering::Unordered has been in our ABI since
>>> 6.1 and we can't change that any more.
>
Thiago wrote:
> The problem is that QPartialOrdering::Unordered has been in our ABI since 6.1
> and we can't change that any more.
Well, Marc already suggested a solution for this problem.
Let's just introduce Qt::{strong,weak,partial}_ordering and deprecate
QPartialOrdering
in favor of the new t
Marc wrote:
> Why do you say it only applies to partial ordering? Do we already match
> the values, other than that of std::partial_ordering::unordered?
Yes, we do.
Thiago wrote:
> We can also just be evil and use bit_cast
Why is that evil? Reading about std::bit_cast, this can be an option, if
> I think it's acceptable for us to change the return type of a function so long
> as it's getting a new mangling.
Well, it would be easily achievable for the template methods, but not for the
inline hidden friend helper methods.
As immediate solution that comes to my mind is to add a third argume
+1
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht
continuing with the patches, I'd like to hear more opinions.
Thanks,
Ivan
____
From: Ivan Solovev
Sent: Wednesday, October 4, 2023 11:15 AM
To: development@qt-project.org
Subject: Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)
So, let me give anot
have a draft of a QUIP which describes how to apply the new macros
to the Qt classes: https://codereview.qt-project.org/c/meta/quips/+/490932
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht
Charlottenburg, HRB
(1), I do not see any problems in
implementing `qCompareThreeWay` as (4).
Later we can also add `qComparesEqual` for consistency and even provide
3-arg overloads for string-like types, like Marc suggests.
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Eri
fully.
So, you can use https://codereview.qt-project.org/c/qt/qtbase/+/479395 to
test the approach.
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha V
wap in Qt 6.5,
but here's the link to 6.2:
https://doc.qt.io/qt-6.2/qtalgorithms-obsolete.html#qSwap
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
td::swap;
swap(lhs, rhs);
instead. So why should we act differently for comparison?
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius
ordering.
We already have `QTest::qCompare()`, so `Qt::qCompare` would not be
a much worse naming.
Anyway, it would be great to come to some kind of consensus about the
naming of the APIs, and move on to the actual implementation.
Best regards,
Ivan
------
Ivan Solove
this.
Then, simply running this script to find and fix all deprecations in Qt MAJ.MIN
before creating the MAJ.MIN.0 branch should help.
I'm not sure how feasible it would be in practice, though.
Best regards,
Ivan
------
Ivan Solovev
Senior Software Engineer
The Qt Co
ormatting, which then leads to a bunch of review comments about
code-style.
I think that it's better to give no hints, rather than misleading hints.
Best regards,
Ivan
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
1248
+1
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht
ch is not supported by the macros,
then the users will still need to implement all six (or 12 in case of
mixed-type comparison) relational operators instead of just calling one macro
and implementing two helper functions.
--
Ivan Solovev
Senior Software Engineer
The Qt Comp
cted, but I'll update the Jira ticket to keep them
in mind.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Sitz
ons, and Qt::equals() and Qt::compare() as public API for the users.
But then, if we use qt_*() functions, their names will not clash with any
of the existing APIs, and we can just let the end-users use these
functions directly.
[0]: https://codereview.qt-project.org/c/qt/qtbase/+/478199
ld consider using it in my
patches. Specially if it allows us to "unblock" compare() as a name for the
helper function.
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io
www.qt.io
Geschä
;rhs) noexcept
{ return compare(lhs, rhs) > 0; }
HOWEVER, that will work ONLY for C++17.
For C++20 we want the Q_DECLARE_STRONGLY_ORDERED marco to simply expand into
operator<=>():
friend auto operator<=>(const MyType &lhs, const MyType &rhs) noexcept
{ re
ic equals)
https://godbolt.org/z/nv9jK4eqv (one-arg public equals)
This is not an ideal solution, because, as you can see in the output, the
operator==() explicitly calls the private static method instead of the hidden
friend. However, the generic code also works (this time calling hidden
s caused by exactly this issue.
And I must admit that it was rather difficult to detect it.
So, I think that this macro is useful.
Best regards,
------
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan
in my tests I only had issues with INTEGRITY, GCC 9.3.1 on OpenSuse 15.4,
and QCC 8.3.0 on QNX.
For these platforms the macro currently does nothing.
Best regards,
Ivan
--
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, G
regards,
Ivan
----
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io<mailto:ivan.solo...@qt.io>
www.qt.io<https://www.qt.io>
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lint
em.
I totally agree that we shouldn't merge something that is not 100% ready.
Best regards,
Ivan
----
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Germany
ivan.solo...@qt.io<mailto:ivan.solo...@qt.io>
81410
Apart from the naming discussion, I consider the task to be almost done. At
least most of the other comments are addressed at this point.
Best regards,
Ivan
----
Ivan Solovev
Senior Software Engineer
The Qt Company GmbH
Erich-Thilo-Str. 10
12489 Berlin, Ge
Hi!
+1 to all suggestions
Best regards,
Ivan
From: Development on behalf of Marc Mutz
via Development
Sent: Tuesday, May 9, 2023 8:51 AM
To: qt-dev
Subject: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style
Hi,
I'd like to propose the fo
Hi,
+1 to the approach suggested by Kai.
Having comments would be very helpful, but I do not think that we need a
separate comment field for each entry.
Best regards,
Ivan
From: Development on behalf of Kai Köhne
via Development
Sent: Tuesday, February 14,
Hi,
Should the example updates be picked to 6.5, or is it only a 6.6 thing?
Is there any general guideline from the Release Team?
Best regards,
Ivan
From: Development on behalf of Kimmo
Leppälä via Development
Sent: Wednesday, January 18, 2023 10:51 AM
To: deve
Hi Jani,
I'm not sure that I understand your proposal.
Currently we have FF on the 9th of December, and the release in March. So, it's
roughly 3 months between FF and release.
Now you propose to shift FF to January (I assume, also around 10th ), and the
release to April. That gives the same 3 m
Hi Thiago,
> Now at https://codereview.qt-project.org/c/qt/qtbase/+/444222
Thanks for sharing it!
> In fact, I came up with a better solution yesterday after sending this email:
move the support to QUuid. This allows us to have the new (mostly) source-
compatible API in place and simply move the
Hi Thiago,
> I was working on extended integers and added qint128 and quint128 to qglobal.h
(qtypes.h)
Can you provide a link to your WIP patch? I tried to search but couldn't find
it in gerrit.
> it's used in the API, with a constructor and a toUInt128(), but that's
all. It's also not document
> 1. It doesn't, obviously. If you emit signals, any signal argument must
>be owning, or QueuedConnection cannot be used. Given that C++20
>requires us to mark up views and non-owning ranges (enable_view,
>enable_borrowed_range), I'm confident that we could detect attempts
>to creat
Hi Marc,
>> I would like to know how that is supposed to work in practice. We have a
>> lot of public API dealing with Qt containers all over. What are you
>> going to do to, for example, to
>>
>> void addActions(const QList &actions);
>>
>> in qwidget.h? What should it look like when we're d
Hi
> Also the machinery of QT_DEPRECATED_METHOD(method, major, minor, reason)
> expanding to nothing for some settings, and possibly different things
> for other settings, of QT_DEPRECATED_WARNINGS_SINCE and
> QT_DISABLE_DEPRECATED_BEFORE entails (thanks to the limitations of the C
> preprocessor)
> If it can be done with little effort, including cherry-picking fixes
> backwards,
> even to 5.15, then it might be something to be investigated.
Well, at least with qt positioning we need to handle all the cherry-picks to
5.15 manually,
because the cherry-pick bot obviously does not detect tha
+1
Best regards,
Ivan
From: Development on behalf of Jaroslaw
Kobus
Sent: Wednesday, April 6, 2022 2:22 PM
To: Edward Welbourne ; Alex Blasche
Cc: development@qt-project.org
Subject: Re: [Development] Nominating Ievgenii Meshcheriakov for approver
+1
Discl
Hi Timur,
could you also update https://wiki.qt.io/Maintainers accordingly?
Best regards,
Ivan
From: Development on behalf of Timur
Pocheptsov
Sent: Monday, November 8, 2021 3:55 PM
To: qt-dev
Subject: [Development] Change in the maintainership of QtNetwork
Created https://bugreports.qt.io/browse/QTQAINFRA-4624
Thanks for pointing that out.
Best regards,
Ivan Solovev
Senior Software Engineer
The Qt Company
Erich-Thilo-Str. 10 12489
Berlin, Germany
www.qt.io<http://www.qt.io>
Geschäftsführer: Mika Pälsi,
Juha Varelius, Jouni Lintunen
Si
://codereview.qt-project.org/qt/qtpositioning
The init-repository script in the dev branch can also be used to set up the
repo properly.
Please target all QtPositioning-related patches to the new repository.
Best regards,
Ivan Solovev
Senior Software Engineer
The Qt Company
Erich-Thilo-Str. 10 12489
Hi,
I'd like to request a new repository on codereview.qt-project.org.
Name: qt/qtpositioning
Description: Qt Positioning module
Responsible persons: Alex Blasche (alexander.blas...@qt.io) and Ivan Solovev
(ivan.solo...@qt.io)
This is needed to ensure that QtLocation module development c
60 matches
Mail list logo
