Hi Thiago, > Now at https://codereview.qt-project.org/c/qt/qtbase/+/444222
Thanks for sharing it! > In fact, I came up with a better solution yesterday after sending this email: move the support to QUuid. This allows us to have the new (mostly) source- compatible API in place and simply move the existing QBluetoothUuid content to removed_api.cpp. This sounds like a good approach, but unfortunately it does not cover all usecases for quint128 in QtBluetooth. See, for example, struct SigningData in qlowenergycontroller_bluez_p.h (https://code.qt.io/cgit/qt/qtconnectivity.git/tree/src/bluetooth/qlowenergycontroller_bluez_p.h#n152) or class LeCmacCalculator (https://code.qt.io/cgit/qt/qtconnectivity.git/tree/src/bluetooth/lecmaccalculator_p.h#n23) I'm not very familiar with the code but, AFAICT, these examples have nothing to do with QUuid. However, they all are private, so we might just want to introduce a new private struct which will behave similarly to the current "struct quint128", and that should fix the issues with private APIs. > I'll wait for 6.6. Good to know, thanks. > https://codereview.qt-project.org/c/qt/qtbase/+/444237 https://codereview.qt-project.org/c/qt/qtbase/+/444238 https://codereview.qt-project.org/c/qt/qtbase/+/444239 I can only access the first patch. The other two links show "Not found". Best regards, Ivan ________________________________ From: Development <development-boun...@qt-project.org> on behalf of Thiago Macieira <thiago.macie...@intel.com> Sent: Friday, November 18, 2022 10:07 PM To: development@qt-project.org <development@qt-project.org> Subject: Re: [Development] Renaming quint128 On Friday, 18 November 2022 09:05:51 PST Thiago Macieira wrote: > In fact, I came up with a better solution yesterday after sending this > email: move the support to QUuid. This allows us to have the new (mostly) > source- compatible API in place and simply move the existing QBluetoothUuid > content to removed_api.cpp. https://codereview.qt-project.org/c/qt/qtbase/+/444237 https://codereview.qt-project.org/c/qt/qtbase/+/444238 https://codereview.qt-project.org/c/qt/qtbase/+/444239 -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering _______________________________________________ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
_______________________________________________ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
