Re: [PATCH] Addded test for timer_create with clock_monotonic

> + remaining = (uint32_t)result->tv_nsec + result->tv_sec; What does "remaining" mean here? What do you get if you add a (truncated) nanoseconds value to a seconds value? (Hint: the units aren't the same, so the arithmetic is meaningless.) I thought I could convert it back into the uint32_t

Re: [PATCH V2] closes #3889 new defect Test needed for timer_create with CLOCK_MONOTONIC

The code i wrote is not based on my previous patch. I ran the same commands in the guide as well as my first patch: git add git commit git send-email --to=devel@rtems.org -1 is there a way to only submit the second patch? I tried to delete the patch file before sending the first patch Also, I

Re: [PATCH] closes #3889

> - remaining = 0; > + result->tv_nsec=0; > + result->tv_sec=0; This isn't correct. result is an uninitialized pointer. So then how do I set the timespec's value to 0? I have changed the timespec variables i have declared from pointers to regular variables. in the original code the

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

bump On Thu, 29 Jul 2021 at 00:28, Zacchaeus Leung wrote: > the timer_create() method can use CLOCK_MONOTONIC but there was no test > for this > > Closes #3888 > --- > cpukit/include/rtems/posix/timer.h| 1 + > cpukit/posix/src/psxtimercreate.c | 3 +- > cpukit/posix/src/time

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

Here you could add an assert that ptimer->clock_type == CLOCK_MONOTONIC || ptimer->clock_type == CLOCK_REALTIME. Would I need to assert that the timer is not a valid timer type? Also In psxtimer create I check if the timer is invalid. I can do a similar if statement as I did in psxtimercreate i

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

How do i report the findings of the psx and tests? Thanks Zack On Thu, 5 Aug 2021 at 19:23, Gedare Bloom wrote: > On Thu, Aug 5, 2021 at 12:36 PM Zacchaeus Leung > wrote: > > > > the timer_create() method can use CLOCK_MONOTONIC but there was no test > for this > > > The commit message nee

Ticket #4203 clarification

Hello! I'd like to begin working on 4203. It involves improving the exception output I'd like to know how I spot exceptions that could be reported better by the system? How do I also know how do I test it and what BSPs i can test with only my computer Also joel told me The list of exception num

Re: Ticket #4203 clarification

Say i find an exception (ex format string printing a decimal.) How do I test that my improvement works? Thanks Zack On Fri, 3 Sept 2021 at 01:36, Joel Sherrill wrote: > On Thu, Sep 2, 2021 at 8:01 PM zack leung > wrote: > > > > Hello! > > > > I'd like to

Re: [PATCH] improve the format error reporting on i386

- thread id is printed as a hex value - EBP ESP is now printed as a address pointer %p - Program counter is printed as a pinter Part of ticket #4203 On Wed, 8 Sept 2021 at 00:17, Zacchaeus Leung wrote: > --- > cpukit/score/cpu/i386/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Ticket 4503

I was wondering about ticket 4503. I was wondering where The required functionality should be in the underlying score/ capability used can be found to write this function. Also how does this relate to Add common malloc family extension method malloc_usable_size()

Re: [PATCH] improve the format of error reporting on i386

Thread ID is now a hex value part of ticket #4203 On Wed, 8 Sept 2021 at 23:58, Zacchaeus Leung wrote: > diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c > index 77b7a7161c..06af57418d 100644 > --- a/cpukit/score/cpu/i386/cpu.c > +++ b/cpukit/score/cpu/i386/cpu.c > @@ -21

Re: Ticket 4503

From: Joel Sherrill Date: Wed, 8 Sept 2021 at 20:30 Subject: Re: Ticket 4503 To: Gedare Bloom Cc: zack leung , rtems-de...@rtems.org < devel@rtems.org> On Wed, Sep 8, 2021 at 11:02 AM Gedare Bloom wrote: > Hi Zack, > > https://devel.rtems.org/ticket/4503 > > Th

Subject: [PATCH] improve the format error reporting on i386

score/i386: improve the format of exception reporting Updates #4203."Updates #4203." --- cpukit/score/cpu/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..06af57418d 100644 --- a/cpukit/score/c

Re: Subject: [PATCH] improve the format error reporting on i386

> On Thu, Sep 9, 2021 at 6:00 PM zack leung > wrote: > > > > score/i386: improve the format of exception reporting > > > > Updates #4203."Updates #4203." > > --- > > cpukit/score/cpu/i386/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 de

[PATCH v4] improve the format of error reporting on i386

Thread id is now a Hex value. Updates #4203 --- cpukit/score/cpu/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..06af57418d 100644 --- a/cpukit/score/cpu/i386/cpu.c +++ b/cpukit/score/cpu/i386/

Re: [PATCH v4] improve the format of error reporting on i386

Gedare told me just to change the ID when I submitted the other I sent you in discord. Sorry for things bouncing back and forth. On Mon, 13 Sept 2021 at 23:44, Joel Sherrill wrote: > On Sun, Sep 12, 2021 at 7:02 PM zack leung > wrote: > > > > Thread id is now a Hex value.

Re: [PATCH v4] improve the format of error reporting on i386

p0); Before I send my patch here is what i'll change . So i can do this for example format the hex values with 0x and have the thread id as a hex value. On Wed, 15 Sept 2021 at 15:18, Gedare Bloom wrote: > On Mon, Sep 13, 2021 at 6:10 PM zack leung > wrote: > > > > Gedar

[PATCH v4] improve the format of error reporting on i386

Thread id is now a Hex value. formatting improved for hex values Updates #4203 --- cpukit/score/cpu/i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..0f17cf0148 100644 --- a/cpukit/score/

Re: [PATCH v4] improve the format of error reporting on i386

Where am i missing it? Zack On Fri, 17 Sept 2021 at 23:15, Gedare Bloom wrote: > Hi Zack, > > I think you have also missed Joel's request to add an 8-character > width specifier. > > On Thu, Sep 16, 2021 at 6:19 PM zack leung > wrote: > > > > Thread id i

Re: [PATCH v4] improve the format of error reporting on i386

Bumo Il ven 17 set 2021, 19:57 zack leung ha scritto: > Where am i missing it? > > Zack > > On Fri, 17 Sept 2021 at 23:15, Gedare Bloom wrote: > >> Hi Zack, >> >> I think you have also missed Joel's request to add an 8-character >> width specif

Re: [PATCH v4] improve the format of error reporting on i386

printk(" EAX = 0%08" PRIx32 "EBX = 0%08" PRIx32 "ECX = 0%08" PRIx32 "EDX = 0%08" PRIx32 "\n", should it look like this gedare? will send once you give the ok On Sun, 19 Sept 2021 at 17:42, zack leung wrote: > Bumo &

[PATCHv5] improve the format error reporting on i386

all hex values now have 8 character width thread id is now hex --- cpukit/score/cpu/i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..786cf8b0b6 100644 --- a/cpukit/score/cpu/i386/cpu.c +

[PATCHv5] improve the format error reporting on i386

ll hex values now have 8 character width thread id is now hex updates #4203 --- cpukit/score/cpu/i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..786cf8b0b6 100644 --- a/cpukit/score/cpu

Re: [PATCHv5] improve the format error reporting on i386

I can send an example of the exception if you want. zack On Wed, 22 Sept 2021 at 18:01, Gedare Bloom wrote: > Joel, > > This looks good to me. I don't know if you can easily test it? > > Gedare > > On Wed, Sep 22, 2021 at 11:26 AM zack leung > wrote: > > >

Re: [PATCHv5] improve the format error reporting on i386

bump On Thu, 23 Sept 2021 at 00:21, zack leung wrote: > I can send an example of the exception if you want. > > zack > > On Wed, 22 Sept 2021 at 18:01, Gedare Bloom wrote: > >> Joel, >> >> This looks good to me. I don't know if you can easily test it

Re: Ticket 4503

bump On Thu, 9 Sept 2021 at 02:17, zack leung wrote: > >Thanks! I guess i'm really unsure about how the pointer relates to the > amount of memory that you can use. I assume the Malloc keeps track of the > sections being used in the heap. Does this function Allocate 2 blocks si

Ticket 4429

For relative times, the clock identifier is not used to select the clock and instead always the CLOCK_MONOTONIC is used. A side-effect is that sleep() and nanosleep() use the wrong clock (CLOCK_MONOTONIC instead of CLOCK_REALTIME). I don't understand how the monotonic clock is not being used. I kn

Scope of variables flagged by code inspector

Hello, I recently was invited to look at a new code review tool by Joel. It's used to help with reducing technical debt. It suggests various fixes and highlights various possible errors. One of them relates to the fact that some of the variable scopes and be reduced. For example, we can define var

[PATCH] fix memory leak within calloc.c libtests

fix came from github code inspector, flagged by one of the analysis that was done --- testsuites/libtests/POSIX/calloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/testsuites/libtests/POSIX/calloc.c b/testsuites/libtests/POSIX/calloc.c index bd04faa800..a7537c8cc4 10064

Re: Ticket 4429

bump On Wed, 6 Oct 2021 at 00:30, zack leung wrote: > For relative times, the clock identifier is not used to select the clock > and instead always the CLOCK_MONOTONIC is used. A side-effect is that > sleep() and nanosleep() use the wrong clock (CLOCK_MONOTONIC instead of > CL

Re: Ticket 4503

bump On Sat, 25 Sept 2021 at 00:26, zack leung wrote: > bump > > On Thu, 9 Sept 2021 at 02:17, zack leung wrote: > >> >Thanks! I guess i'm really unsure about how the pointer relates to the >> amount of memory that you can use. I assume the Malloc keeps track

Re: [PATCH] fix memory leak within calloc.c libtests

bump On Mon, 18 Oct 2021 at 23:46, zack leung wrote: > fix came from github code inspector, flagged by one of the analysis that > was done > --- > testsuites/libtests/POSIX/calloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/testsuites/li

Re: Ticket 4503

bump On Mon, 18 Oct 2021 at 23:58, zack leung wrote: > bump > > > On Sat, 25 Sept 2021 at 00:26, zack leung > wrote: > >> bump >> >> On Thu, 9 Sept 2021 at 02:17, zack leung >> wrote: >> >>> >Thanks! I guess i'm really unsure a

Re: Ticket 4429

bump On Mon, 18 Oct 2021 at 23:47, zack leung wrote: > bump > > > On Wed, 6 Oct 2021 at 00:30, zack leung wrote: > >> For relative times, the clock identifier is not used to select the clock >> and instead always the CLOCK_MONOTONIC is used. A side-effect is that >

Re: New validation test suites

What tasks can I do that can help with ECSS compliance? Zack On Mon, 13 Dec 2021 at 21:40, Chris Johns wrote: > On 14/12/21 1:53 am, Sebastian Huber wrote: > > Hello, > > > > the ESA activity to pre-qualify parts of RTEMS according to ECSS > requirements is > > nearly complete. There is a short

Malloc tests

Helllo , I'm working on a patch for malloc_get_usable size right now so far i have this test case for malloc, I just make sure that the value is null and i just malloc an int and then i make a call to the function malloc_usable size and then i compare it like this. static void test_malloc_usable

Re: Malloc tests

the current block? On Thu, 6 Jan 2022 at 21:28, Joel Sherrill wrote: > On Thu, Jan 6, 2022 at 2:55 PM Gedare Bloom wrote: > > > > On Tue, Jan 4, 2022 at 6:10 PM zack leung > wrote: > > > > > > Helllo , > > > I'm working on a patch fo

Re: Malloc tests

There a way to get the same values used to make the calculation in malloc get usable size? Bump Il ven 7 gen 2022, 21:25 zack leung ha scritto: > I think that the malloc tests is calculated differently than alloc_size+ > allocsize mod it looks like this > *alloc_size = (uintptr_t) n

[PATCH] added malloc usable size and test

--- cpukit/include/rtems/libcsupport.h| 8 ++- cpukit/libcsupport/src/mallocusablesize.c | 28 +++ spec/build/cpukit/librtemscpu.yml | 1 + testsuites/libtests/malloctest/init.c | 15 +++- 4 files changed, 50 insertions(+), 2 deletions(-) crea

[PATCH] added malloc usable size and test

--- cpukit/include/rtems/libcsupport.h| 5 ++- cpukit/libcsupport/src/mallocusablesize.c | 47 +++ spec/build/cpukit/librtemscpu.yml | 1 + testsuites/libtests/malloctest/init.c | 13 +++ 4 files changed, 65 insertions(+), 1 deletion(-) create mode 10

[PATCH] added malloc usable size and test

diff --git a/cpukit/include/rtems/libcsupport.h b/cpukit/include/rtems/libcsupport.h index f4be4cfc9a..ec385bb71a 100644 --- a/cpukit/include/rtems/libcsupport.h +++ b/cpukit/include/rtems/libcsupport.h @@ -73,7 +73,10 @@ extern size_t malloc_free_space(void); * Find amount of free heap remainin

Re: [PATCH] added malloc usable size and test

ping * On Sun, 20 Feb 2022 at 02:55, zack leung wrote: > diff --git a/cpukit/include/rtems/libcsupport.h > b/cpukit/include/rtems/libcsupport.h > index f4be4cfc9a..ec385bb71a 100644 > --- a/cpukit/include/rtems/libcsupport.h > +++ b/cpukit/include/rtems/libcsupport.h > @@ -73,

Re: [PATCH] added malloc usable size and test

ping On Sat, 26 Feb 2022 at 02:42, zack leung wrote: > ping > * > > On Sun, 20 Feb 2022 at 02:55, zack leung wrote: > >> diff --git a/cpukit/include/rtems/libcsupport.h >> b/cpukit/include/rtems/libcsupport.h >> index f4be4cfc9a..ec385bb71a 100644 >> -

[PATCH] added malloc usable size and test

--- cpukit/include/rtems/libcsupport.h| 5 +++ cpukit/libcsupport/src/mallocusablesize.c | 48 +++ spec/build/cpukit/librtemscpu.yml | 1 + testsuites/libtests/malloctest/init.c | 15 ++- 4 files changed, 68 insertions(+), 1 deletion(-) create mode 10

[PATCH] added malloc usable size and test

closes #4503 --- cpukit/include/rtems/libcsupport.h| 5 +++ cpukit/libcsupport/src/mallocusablesize.c | 48 +++ spec/build/cpukit/librtemscpu.yml | 1 + testsuites/libtests/malloctest/init.c | 15 ++- 4 files changed, 68 insertions(+), 1 deletion(-) c

Re: [PATCH] added malloc usable size and test

Ping Il ven 4 mar 2022, 21:58 zack leung ha scritto: > closes #4503 > --- > cpukit/include/rtems/libcsupport.h| 5 +++ > cpukit/libcsupport/src/mallocusablesize.c | 48 +++ > spec/build/cpukit/librtemscpu.yml | 1 + > testsuites/libtests

[PATCH] rtems_shell_main_mmove problem

Closes #4556 --- cpukit/libmisc/shell/main_mmove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_mmove.c b/cpukit/libmisc/shell/main_mmove.c index 38731b10a2..0029882d62 100644 --- a/cpukit/libmisc/shell/main_mmove.c +++ b/cpukit/libmisc/shell/main_m

Re: [PATCH] rtems_shell_main_mmove problem

Bump On Wed, 14 Dec 2022 at 20:12, zack leung wrote: > Closes #4556 > --- > cpukit/libmisc/shell/main_mmove.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/libmisc/shell/main_mmove.c > b/cpukit/libmisc/shell/main_mmove.c > index 38731

[PATCH] rtems_shell_main_chmod problem

Closes #4751 --- cpukit/libmisc/shell/main_chmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 1f646d92d4..9a42cbd940 100644 --- a/cpukit/libmisc/shell/main_chmod.c +++ b/cpukit/libmisc/shell/main_c

[PATCH] rtems_shell_main_chmod problem

Closes #4751 --- cpukit/libmisc/shell/main_chmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 1f646d92d4..9a42cbd940 100644 --- a/cpukit/libmisc/shell/main_chmod.c +++ b/cpukit/libmisc/shell/main_c

[PATCH] rtems_shell_main_chmod problem

Closes #4751 --- cpukit/libmisc/shell/main_chmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 1f646d92d4..9a42cbd940 100644 --- a/cpukit/libmisc/shell/main_chmod.c +++ b/cpukit/libmisc/shell/main_c

Ticket 4364

Hello, I'm currently looking at ticket 4364. It says that there is a difference between the test results printed by the console and what is emailed to @devel. I don't see a difference and i'm just wondering if it has been fixed Zack ___ devel mailing li

[patch] medit problem

fixes #4557 --- cpukit/libmisc/shell/main_edit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index 191eefa19d..71bb1d931b 100644 --- a/cpukit/libmisc/shell/main_edit.c +++ b/cpukit/libmisc/shell/main_ed

[patch] fixes 4557

fixes 4557 user can't cut using ctrl e and x in medit --- cpukit/libmisc/shell/main_edit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index 6e954639e2..8317452b7b 100644 --- a/cpukit/libmisc/shell/main_e

[patch] medit issue

libmisc/shell: User can't cut using ctrl e and x in medit Closes #4557 --- cpukit/libmisc/shell/main_edit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index 6e954639e2..8317452b7b 100644 --- a/cpukit/li

[PATCH] fixes 4557

From: zack Closes #4557 --- cpukit/libmisc/shell/main_edit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index 6e954639e2..8317452b7b 100644 --- a/cpukit/libmisc/shell/main_edit.c +++ b/cpukit/libmisc/s

readdir issue 4674

- hi guys i am working on #4674 - currently i'm not able to get it to produce the error - my code looks like this - #ifdef HAVE_CONFIG_H #include "config.h" #endif #include #include #include #include #include #include #include #include #include const char rtems_test_name[] = "FSREADDIR

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

hi, so do you want me make this change? On Wed, 12 Jul 2023 at 10:54, Gedare Bloom wrote: > On Wed, Jul 12, 2023 at 8:06 AM Joel Sherrill wrote: > > > > > > Pavel this was filed as https://devel.rtems.org/ticket/4903. The ticket > submitter > > didn't give a patch, just a code change snippet an

Re: [PATCH] fixed warning related to spstdc17

hi! sabestian did you mean the size of the structure? On Mon, 23 Oct 2023 at 10:20, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Zack, > > there is a bit more work to do to fix this warning. The warning fix > should not result in a size increase of the uniprocessor RTEMS >

Re: [PATCH] fixed warning related to spstdc17

ue, 24 Oct 2023 at 08:31, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 24.10.23 14:02, zack leung wrote: > > hi! sabestian did you mean the size of the structure? > > Yes, one option to get rid of the empty structures is to just provide > typedefs,

Re: [PATCH] fixed warning related to spstdc17

ping On Tue, 24 Oct 2023 at 22:17, zack leung wrote: > that didn't work but i'm thinking of defining a char array that is equal > to the size of the processor lock and the isr lock? i figured that the > processor lock is 64 bits and isr lock is a one bit? > I'm con

Re: [PATCH] fixed warning related to spstdc17

:40, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 27.10.23 03:43, zack leung wrote: > > ping > > > > On Tue, 24 Oct 2023 at 22:17, zack leung > <mailto:zakthertems...@gmail.com>> wrote: > > > > that didn't work

Re: [PATCH] fixed warning related to spstdc17

ler.h file which is where the struct is defined. On Mon, 30 Oct 2023 at 03:04, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 29.10.23 02:44, zack leung wrote: > > ./../../cpukit/include/rtems/score/schedulerpriority.h:87:21: error: > > field '

Re: [PATCH] fixed warning related to spstdc17

ping On Tue, 31 Oct 2023 at 22:07, zack leung wrote: > Sorry either I lack knowledge in C or lack knowledge in working with > rtems. Do you mean if rtems smp is defined then we make sure that scheduler > context base type is defined? I don't quite understand why it would be >

Re: [PATCH] improved error checking in ticks per timeslice

; > I'm cc'ing Sebastian because you edited the text in a generated file. He > > should be able to point us to the right place to fix it. > > > > On Mon, Feb 12, 2024 at 8:26 PM > <mailto:zakthertems...@gmail.com>> wrote: > > > > Fro

Re: [PATCH] improved error checking in ticks per timeslice

ping On Sun, 18 Feb 2024 at 21:15, wrote: > --- > cpukit/doxygen/appl-config.h | 2 +- > cpukit/include/rtems/confdefs/clock.h | 6 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h > index bd7cde628f..

Re: [PATCH] improved error checking in ticks per timeslice

ping On Tue, 20 Feb 2024 at 20:25, zack leung wrote: > ping > > On Sun, 18 Feb 2024 at 21:15, wrote: > >> --- >> cpukit/doxygen/appl-config.h | 2 +- >> cpukit/include/rtems/confdefs/clock.h | 6 ++ >> 2 files changed, 7 insertions(+), 1 d

Re: [PATCH] improved error checking in ticks per timeslice

joel said: +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 && > defined(CONFIGURE_TICKS_PER_TIMESLICE) > + #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" > +#endif > + > > > This is modifying the right file but I think it is safer to check that > it is defined > befor

Re: [PATCH] improved error checking in ticks per timeslice

ping On Tue, 27 Feb 2024 at 21:33, zack leung wrote: > > joel said: >+#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 && > > defined(CONFIGURE_TICKS_PER_TIMESLICE) > > + #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" >

Re: [PATCH] improved error checking in ticks per timeslice

a preference on split #ifs versus compound #ifs but it doesn't > match the style of the surrounding code. > > Kinsey > > On Mon, Mar 4, 2024 at 7:39 PM zack leung > wrote: > >> ping >> >> >> On Tue, 27 Feb 2024 at 21:33, zack leung &g

Re: [PATCH] improved error checking in ticks per timeslice

ping On Fri, 8 Mar 2024 at 22:03, wrote: > From: Zack leung > > --- > cpukit/doxygen/appl-config.h | 3 +-- > cpukit/include/rtems/confdefs/clock.h | 4 > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/cpukit/doxygen/appl-config

Re: [PATCH] improved error checking in ticks per timeslice

Did you check in the code? Il mar 12 mar 2024, 21:55 Kinsey Moore ha scritto: > Sorry, I missed this in the deluge of emails. Looks good to me. > > Kinsey > > On Tue, Mar 12, 2024 at 8:17 PM zack leung > wrote: > >> ping >> >> On Fri, 8 Mar 2024 at

Re: [PATCH] improved error checking in ticks per timeslice

Do I need to do anything? On Mon, 18 Mar 2024 at 16:38, Kinsey Moore wrote: > Sorry, I didn't realize I had tests turned off in my local build when I > checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well. > > Kinsey > > On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber < > seba